From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Guo Samin <samin.guo@starfivetech.com>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>,
Yanhong Wang <yanhong.wang@starfivetech.com>,
Tommaso Merciai <tomm.merciai@gmail.com>
Subject: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac
Date: Thu, 16 Mar 2023 09:20:03 +0100 [thread overview]
Message-ID: <c716e535-7426-56da-ca6f-51c7d7d69bb3@linaro.org> (raw)
In-Reply-To: <d2bb7fa5-206f-2059-bde0-b65e1acc44de@starfivetech.com>
On 16/03/2023 09:15, Guo Samin wrote:
>>>> interrupts: ???
>>>>
>>>
>>> Hi Krzysztof,
>>>
>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes,
>>> and the JH7110 SoC is also applicable.
>>> Maybe just add reg/interrupt/interrupt-names to the required ?
>>
>> You need to constrain them.
>
>
> I see. I will add reg constraints in the next version, thanks.
>
> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml,
> do these also need to be constrained?
The interrupts on common binding are variable, so you need to constrain
them - you have fixed number of them, right?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-16 8:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 4:37 [PATCH v7 0/6] Add Ethernet driver for StarFive JH7110 SoC Samin Guo
2023-03-16 4:37 ` [PATCH v7 1/6] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Samin Guo
2023-03-16 4:37 ` [PATCH v7 2/6] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Samin Guo
2023-03-16 4:37 ` [PATCH v7 3/6] dt-bindings: net: snps,dwmac: Add 'ahb' reset/reset-name Samin Guo
2023-03-16 7:24 ` Krzysztof Kozlowski
2023-03-16 7:36 ` Guo Samin
2023-03-16 4:37 ` [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac Samin Guo
2023-03-16 7:27 ` Krzysztof Kozlowski
2023-03-16 7:40 ` Guo Samin
2023-03-16 8:02 ` Guo Samin
2023-03-16 8:03 ` Krzysztof Kozlowski
2023-03-16 8:15 ` Guo Samin
2023-03-16 8:20 ` Krzysztof Kozlowski [this message]
2023-03-16 8:28 ` Guo Samin
2023-03-16 9:58 ` Krzysztof Kozlowski
2023-03-16 10:18 ` Guo Samin
2023-03-16 11:35 ` Krzysztof Kozlowski
2023-03-16 4:37 ` [PATCH v7 5/6] net: stmmac: Add glue layer for StarFive JH7110 SoC Samin Guo
2023-03-16 4:37 ` [PATCH v7 6/6] net: stmmac: starfive_dmac: Add phy interface settings Samin Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c716e535-7426-56da-ca6f-51c7d7d69bb3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=tomm.merciai@gmail.com \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®