From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77F7946D56D for ; Tue, 21 Jul 2026 20:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664534; cv=none; b=a/GDa4f9LB/VXhQW2dQ5pf/Ttax9j3XB5QF0aXYXnGG8SINNrjnJEH0s0cJ/DwB1U8XoHR/0UBHKZAV+4nKGXykUMLe0FQ2PLhXRIkqn9eF5Q6CZuZhjG03M9rE7zLW/Dc3dqX+wR6WcIsykIVNRhVFr9mdfdCzyKy46pdu/wAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784664534; c=relaxed/simple; bh=6A9s+Q3K9XnD5uZo86BKF3f/IbQXl/Fgu+fQMHlYs7E=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=UZ/yP/iX/1de7iPJ29Fa1tCTQAFqAMvkrp6NwVR5DtCQWeuV6zdER+kZEJA/FefEMw3YWMMp46Lw4IhCiWraq5lD3WtdQ+DYTSFJyRys96RitBKIyjhhSFzRJGh4ajGzcxqTwzzPQL8NYHp2It0jdkcm2UnjTk/Y6+NMMVU9pFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=g5mTzUWY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=chEA2mGu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g5mTzUWY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="chEA2mGu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784664531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YoOouUI2xFyBZQ4n8b5UEgP4pMR5eMIkpQq69XgErXE=; b=g5mTzUWYg+i/R2ZcWQ4wR/T1s4BSsK1fW5EriQkEeKzKe3kZQnsYwS6toLFKxL+eLEsiq3 F/w/b2pUVSbbzrnsg/At8lBnTn4iogOum2Z14g4ikPab7XBqsNlLodqrdfZE4Gq4fdmmYK SAIswUfsFLKpxSU/9N173HvqXiRHPrA= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-UqSPlHFiMNi-Js2IwU79tg-1; Tue, 21 Jul 2026 16:08:49 -0400 X-MC-Unique: UqSPlHFiMNi-Js2IwU79tg-1 X-Mimecast-MFC-AGG-ID: UqSPlHFiMNi-Js2IwU79tg_1784664529 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8f0867a75ecso132713766d6.3 for ; Tue, 21 Jul 2026 13:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784664529; x=1785269329; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=YoOouUI2xFyBZQ4n8b5UEgP4pMR5eMIkpQq69XgErXE=; b=chEA2mGuhqVC5K+Z18NFguRTQpaQrPuKwh+Fsee1K68GczsT9Ty9yLPn+wLacK4RX6 Y0E26/7Bzvw/gtYbCTF9gCn3AuLm6ABzTMgnVPmHF5ezVWIYVsCT8EBj+L6NFCB3OZcc /6gsFf4mp79G34bSO/W4xvD4XA3pyV7NIWmvbZDbVFGMWa6ikl8Un99yY3zl/YK77NUz i7wl0oxuKNV8KC184B1B0+rhHo4aeH+zlItbOBfNGiuWm6qWwiUgTPimJ1M7rAjhJSMX l/IM5Naa8qQ1gkG3Y1fmufZjKYGNHmyT5cW0yW1wzCDwRY8R73SyOJ9IduvktZPIbxJt cVFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784664529; x=1785269329; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YoOouUI2xFyBZQ4n8b5UEgP4pMR5eMIkpQq69XgErXE=; b=H/6dvQQ0rrH6vir/I7xsFLiGiwXd3OiwILEpTdWcQ++CFhNaBF26zdnp6FfRac1lIF zKZYAq0XbYOxhN3iXb8nfLcEGP0vYGPVyiG/xlJAVmpJ9uZ/MBEbMu+kDjRIyGlA+MjO 4LgPcnTSTBIUPPC2hSh80KjqKjzvL+4CaM+uZTP6LBbj6bi/faHPH/RmiOj61cdndC03 okYB8cNEs9ZaYUTXeJspamz8IydatfQzI8mzkdPgtmnf31AkizbDr7zqGKk5FIdtx4f3 yIyNmLfQy+uvkpWhBKAcVkwijdIAwSRbaPROJE+8lnWrCx4QrElzhcXaIrYaK5cNG+7I KlaA== X-Forwarded-Encrypted: i=1; AHgh+RrdIPDSZeP8W/VVoAUk8L82zWj1SW5SSl43M2jdFHnJKDTmZMpFFjFVcNBFN2obkBGTEBPHibiEB8EjCoU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3Zu7u5E1VJBlqg3bHYMRTLGmJHyFvup8KLhEykgWHBuqPbxqD CA4zH6Cwn9IA9+qZ6hX7KCIYyzRTXLIjz1AK/bMUk146mTZxSgigYid3X8ovoDPSH23JS5Jif5u L0ZvaKTn1DZanXfDNpplPvc2h252PTU+Tlmffi1492+hJzyhujYNtVWreETbk6LW8wg== X-Gm-Gg: AR+sD12ZuEYzos3v/NwdPgtWBW2VkO9TEE1basqUXYdhd3zKC2c/IXzMuJJOKua0/05 ip2x1x8YYuzCr4qvswDzl4dCWmJqFttqTRDv5cculdJyhyKcTwEgHqKFsvAjp9CjVHWs7qJux0c 0CczrWbl1hZmu9yUzJozbw/CcCzLWwVl8/MzEttB9hfv/fRaqIXocE3YJ0dbia0tiiubBgpYd57 HJFTpp3NmaKaBgBB/GGtTq9LNA/UCxUn+9BLxnGmcdHv3qg3EB87ymxdPBxH/H+4I66Xrj1xGMO GyiWMfiAiS+zCk55uqxfg7/yyJTbKkAZTI3hkTGS229V9aIZgapZLZQggvgmX1lyCQY8aHW6 X-Received: by 2002:a05:6214:e87:b0:904:546a:1c47 with SMTP id 6a1803df08f44-907783dbe63mr224352376d6.53.1784664528523; Tue, 21 Jul 2026 13:08:48 -0700 (PDT) X-Received: by 2002:a05:6214:e87:b0:904:546a:1c47 with SMTP id 6a1803df08f44-907783dbe63mr224351876d6.53.1784664528014; Tue, 21 Jul 2026 13:08:48 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907baa27ce6sm3874066d6.45.2026.07.21.13.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 13:08:47 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes From: lyude@redhat.com To: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Faith Ekstrand , Dave Airlie , Leandro Ribeiro , Maarten Lankhorst , Kees Cook , Marco Crivellari , Simona Vetter , Pekka Paalanen , David Airlie , Thomas Zimmermann , Maxime Ripard , Danilo Krummrich , Daniel Stone , James Jones Date: Tue, 21 Jul 2026 16:08:46 -0400 In-Reply-To: <20260720205541.257781-1-lyude@redhat.com> References: <20260720205541.257781-1-lyude@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I had thought that testing this on fbcon would be enough, but there is still more issues with this series I found when adding these to the kernel I dog food on my desktop. Will figure them out and send another respin of this series asap On Mon, 2026-07-20 at 16:43 -0400, Lyude Paul wrote: > Recently a change went into the kernel to ensure that drivers which > expose color formats which have alpha channels. This would cause > nouveau > to hit a WARN_ON when setting up cursors, since they do support > blending > - but we never bothered trying to hook up the controls for it to > nouveau. >=20 > This fixes the issue by ensuring that nouveau always exposes a blend > mode for any planes with alpha channels, regardless of whether or not > we > have control of the blend mode hooked up. If someone wants to add > control for this in the future as well, it should be fairly easy to > hook > up with this. >=20 > Previous version: > https://patchwork.freedesktop.org/patch/741031/ >=20 > Lyude Paul (3): > =C2=A0 drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func > =C2=A0 drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state() > =C2=A0 drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for > =C2=A0=C2=A0=C2=A0 wndws >=20 > =C2=A0drivers/gpu/drm/nouveau/dispnv50/curs507a.c |=C2=A0 3 ++ > =C2=A0drivers/gpu/drm/nouveau/dispnv50/disp.c=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 4 +++ > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndw.c=C2=A0=C2=A0=C2=A0=C2=A0 | 4= 0 +++++++++++++++++-- > -- > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndw.h=C2=A0=C2=A0=C2=A0=C2=A0 | 1= 1 ++++++ > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |=C2=A0 1 + > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c |=C2=A0 1 + > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c |=C2=A0 1 + > =C2=A0drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c |=C2=A0 1 + > =C2=A08 files changed, 55 insertions(+), 7 deletions(-) >=20 >=20 > base-commit: b0a652436b892eb9a036a031b33099dca036faaa