From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751167AbdFANBO (ORCPT ); Thu, 1 Jun 2017 09:01:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:45103 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751083AbdFANBN (ORCPT ); Thu, 1 Jun 2017 09:01:13 -0400 Subject: Re: [PATCH v2 6/8] nvme: provide UUID value to userspace To: Keith Busch Cc: Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , maxg@mellanox.com, Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170601111750.20880-1-jthumshirn@suse.de> <20170601111750.20880-7-jthumshirn@suse.de> <20170601124726.GF2845@localhost.localdomain> From: Johannes Thumshirn Message-ID: Date: Thu, 1 Jun 2017 15:01:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170601124726.GF2845@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/2017 02:47 PM, Keith Busch wrote: > FWIW, tools should have been using the 'wwid' attribute, which returns > either EUI64 or NGUID so a unique identifier can be gotten from a > single file without checking for the existence of either. That should > help not break backward compatibility, but I've no idea if anything > actually relies on 'uuid' returning the NGUID. Yep, that's why I though I'd be clever and place this hack in there. I think we can remove it in 1-2 years or so when most/all userspace has adopted to the change (there shouldn't be too much apart from some hand crafted udev rules anyways). -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850