From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A02534A3A5 for ; Wed, 13 May 2026 18:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696983; cv=none; b=LlMn/Mw8/C/Q22MuRBS/L/9RBATTMBJ/ZiCBO8lX1+GK+/Sk+wi0V2n7yNIM81qf8ru6C/EhjCdK9bxhhWqiPwAPSZ8HgMDRW0yih9g0XdN2iRv/ZJbaR6sH/S1U8ks2GevMKrDGWFr3kiLmlbvrmIxKyvvrZN44G/n4fEU3y+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696983; c=relaxed/simple; bh=SSbr6icbBV2zdg/d2s4UPFh/Wsw0N6w3mEkhzITFHUo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DyHM6zx1H2v5bsRJFOMbLu3Q/b0K2PaAi7f33fTiq6VNbn1Akrzm2HV88vH/y0SFkNxVT9wX3nGS6Y6DGtI3/hN28a3j9eBqx7i9PyGzEnlxWWeYs7MU3fCzykNXdZv1ALgDNk0P8goj0xc0Tg62nXYo98eOqD6VpXNkP79eixA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bfmQ7QcD; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bfmQ7QcD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778696981; x=1810232981; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=SSbr6icbBV2zdg/d2s4UPFh/Wsw0N6w3mEkhzITFHUo=; b=bfmQ7QcDSd0EiTCsMIKsS9fVTaz/aBrXrR1IfSuZrRZmPuRGgKEmqap7 cI3mUDf9WyQXgaqyS4focRzrhjCALnEOVIAOIpl3W/QE3SFDkNdATHy4N +DiT6kHiNxX0lavXNeOeTXjLWCQRQOmJKnzp6jDlf2+C3mo/IjBcoM+nU 2iZSoG4YaTUWaTXTuKjd+CJmfyp+2NwbLHrpVItpn48q/SumFMo8AXS8q CwIpuy9imuZ00LJDtRAxrBP464gCowayjc3F10ycS0Nxyw2PEEjZ8cr04 Dii30iYMkj4vEUyJsPl6Ndo82HSsfJAaHKYiKU75AlqmaSFUvaMZzl80S w==; X-CSE-ConnectionGUID: /XPKrbtTQfimiKntJbSOrQ== X-CSE-MsgGUID: N2f6R983Qg+H/ZUc7bzGSA== X-IronPort-AV: E=McAfee;i="6800,10657,11785"; a="67165210" X-IronPort-AV: E=Sophos;i="6.23,233,1770624000"; d="scan'208";a="67165210" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 11:29:40 -0700 X-CSE-ConnectionGUID: Q2aXvgQHT9imUElNV2ewIA== X-CSE-MsgGUID: P8XNKKSnSwiWdTdh/+d7iQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,233,1770624000"; d="scan'208";a="268494619" Received: from cmdeoliv-mobl4.amr.corp.intel.com (HELO [10.125.108.49]) ([10.125.108.49]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2026 11:29:41 -0700 Message-ID: Date: Wed, 13 May 2026 11:29:39 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mm: Skip global ASID broadcast TLB flush when PCID is disabled To: Tom Lendacky , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Nadav Amit , Rik van Riel References: <6d67675458bfe4ac1ed792beec3ad93dd45848c7.1778695885.git.thomas.lendacky@amd.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <6d67675458bfe4ac1ed792beec3ad93dd45848c7.1778695885.git.thomas.lendacky@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/13/26 11:11, Tom Lendacky wrote: > Booting with "nopcid" clears X86_FEATURE_PCID in x86_nopcid_setup(), > but X86_FEATURE_INVLPGB is left intact. On AMD CPUs that support > INVLPGB, broadcast TLB flushing remains active even though CR4.PCIDE > is off. > > There are two checks that decide whether the global ASID code runs, > mm_global_asid() and consider_global_asid(), that key off of the > X86_FEATURE_INVLPGB feature. Once an mm becomes active on more than > three CPUs, consider_global_asid() assigns it a global ASID, after which > flush_tlb_mm_range() takes the broadcast_tlb_flush() path. The > broadcast_tlb_flush() function calls invlpgb_flush_single_pcid_nosync() or > invlpgb_flush_user_nr_nosync() with kern_pcid(asid), which expands to > (asid + 1). Both helpers set INVLPGB_FLAG_PCID and place the non-zero > PCID into EDX[31:16] of the INVLPGB instruction. Issuing INVLPGB with > INVLPGB_FLAG_PCID (RAX[1]) and a non-zero PCID (RDX[27:16]) while > CR4.PCIDE is not set results in a #GP: Just to be clear, the APM says there's a #GP if: "CR4.PCID =0 and EDX[PCID] is not zero." I don't think INVLPGB_FLAG_PCID (RAX[1]) is supposed to play a role. Although the architecture doesn't care, it's also at least a _little_ funky to be setting INVLPGB_FLAG_PCID here: u8 flags = INVLPGB_FLAG_PCID | INVLPGB_FLAG_VA; when PCIDs are disabled. How about we add a: static const struct cpuid_dep cpuid_deps[] = { ... { X86_FEATURE_INVLPGB, X86_FEATURE_PCID }, and be done with it? If you don't have PCIDs, you don't get INVLPGB at all. Yes, you could theoretically use INVLPGB for kernel mappings without PCIDs. But all actual CPUs that have INVLPGB presumably also have PCID support. Then we never have to worry about cases where INVLPGB==1, but PCID==0 at *all*.