From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A18F73ACA66 for ; Mon, 30 Mar 2026 09:57:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774864642; cv=none; b=pc4zhc4CLnI3CNJyyl0oGMSDQnWaNm6fbFaDYP1UZbyven9RWW47RS4czxUJW0VIpAXPTloSc9YElFdJLw7YAtgpSVu3ZpQF/zKOjrfhQIn7AvuuIpHPEaqo8/HAfAw2YQslYnJcUJo2+bp4RKKI7nRT8CqtgEv5euWs/g3xGQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774864642; c=relaxed/simple; bh=BIZ2xVvrz7ufWQZCnlXQg4j8fC0K5mDKmmIaC6nKUy0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uhRcaf2NTErdgip5uy+e8nsC5/27TBnju21WAVyvBb83/7g7stTfGfeF7APQDx8lyxsZSM0lfmcc9ufB13d/Qf2x3pv6A035MISm6LUQwc3v4z8TPTX76sR64kdmEY2qlt0MUzzLmIQpX/ZkGS4kZIYQNuXkpKSyprRsN6R/LTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pSwlnorm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b9yccywp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pSwlnorm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b9yccywp" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U3hscn4088648 for ; Mon, 30 Mar 2026 09:57:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U+q+5RHoG05AQakEjF3RsKZ6QTb82SYW8BIOn7cpF4Q=; b=pSwlnormFTICBJC1 YN17+71CfmPcq9N6kqRvKF9dcIJ9K3K/SJb4UCVH8BT6X3M/crTNdLyaCLayPNE/ 5tuyTF6yVJCX51sRLMk+PKRTRqJGr8rjpxgDOJyu8hvWMiyq2qhzKtgQ7lvAWhq4 2ZQTti2UWrX5YJFoqtkHmAxJbpSB1NuHICBTYgkeowWx/1ATG3r83TDJNnyo+Ntm FrupbIVi5GQLwABPhsReaQlI+WIyDZRPG0IdrItSVgSQ726s2JV3X3mGaqkZnckJ h/yX63q/trLJThX4QT70pCAj1bKPaFEFtelF1OLZ2DtohMacD4BYiRx5sgzgT/0S uGGpuQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d67715jsr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 09:57:20 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82c675116f1so8646981b3a.2 for ; Mon, 30 Mar 2026 02:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774864640; x=1775469440; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U+q+5RHoG05AQakEjF3RsKZ6QTb82SYW8BIOn7cpF4Q=; b=b9yccywp79tWNu2pq/MsEtnitooyW/F9KcdRJLPsy0JhP2fvbUc2JeJ1LYSp6xf6s8 WtuhpqIaxiqSMneZKMat+ajXe18SvJDicEamf7PXg60ovLzNDWE6k75GRk/AWCvIm9b8 k07xkDMolIKo2CQm2T2yEaTAH8VKTITQCWTPTVW8b4fo+P9k38clB915u12Soc2sAj+b 5JU6N+Ysjn3tS6Gv8xz1P6YXk12JqgVlHwG/QdWxoU6yt6vWTGGjIW/92ZbqximcrU/v 8qbds7ksoYzO6qLv4Xbas8PQxfb1HTfxUo6XXmu9qX+dJySzT73CJEg4sMQ0mTvGQwad /h7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774864640; x=1775469440; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U+q+5RHoG05AQakEjF3RsKZ6QTb82SYW8BIOn7cpF4Q=; b=P8x0oluQOn+t4fRY9myMtEcpUsaejToUce+g5VJ8rVy5Z/WxuhaPpNRs5cURE1cxoW d7uBg79Cg5A23pEiYM6r8zIJ9Ve14vSq1HqvkTrYvscrKNRBQPcMlk8h4EPbuE7Pxmn1 10/MWNuTd65W4k/EVGkTkW95qtRVq3YWxOxFNLUm4UXojeGxD3Ji4jaXuXLcJG0mcDUv y3MaZJYrIEUAA6TDkpNljFg7RcBPVurivbcvxKodWChvdHAuuEtQeMVgf+z0uHf6REN7 4y3SpinxFAySdtmrc85uMXWIsgpRqHy/d8zUJNOFOof9Nn8J+kIpbvLEY3V3tonavo5b fhWg== X-Forwarded-Encrypted: i=1; AJvYcCV3wJgMowEin84m2DchqSSSUqvDB5FOKAL9SqhGx+jULRGoyTVCMfKa/gZMEi1cb657YGBBb5Kn1VSQVxU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1BaQdMAc2AdlEfE267FiZJ1GYeYNVHjkhiPmHw9yKVpSCKrm/ C5JyDHg7pIGQ1XGKsMSlwppkicolDwhSzdPMJ5QHM6kUNif+p8T6iUcBSI4yph0cZV8AIJId0X4 cbt9oxuc4VJwHWHITF4TO+JAe2RJa43Xd7UCizbKpX+SIqdjRbCTEYjZOEo9yRq7jqlk= X-Gm-Gg: ATEYQzyPKAc+IT7YAUm2GEFfsGIQpsd033FTya8X0MjP5ID5HD6yir7d+IxOLI/WqKu d/SGwQRAAsYTx7ujLmeCSnYV2HMVvOoDSFe8ZUk2X4GQ+/OAQ0F+BjkIv0qrRwrRD1hu1sebAcM C+gW0bHDUXy5Tw04xPwoHe4QKiYRGa5yoBNXKhI8C00ZVndpnQqmv/i/A87A5IdAmrfA6PfgQUw WxXnlp4AmJnL1Yt3cnQRrvnkSrmSQM/lQ1EAeWPsDepsp40PdXKYjE5EvtmZONl3jy9OZqsrcMt yDGMzaE7zfH+UivfG0/560nqilesaVGEkhNVfuCNTNAdFzFIIa2ytUuzxOUL1r5J/gYY7toW/if IODOnszzvyXe8e/s3ho5JJ7nIfzdMe2Zm1yVeAQdkN5RtWrsw X-Received: by 2002:a05:6a00:f8a:b0:81f:43fe:988c with SMTP id d2e1a72fcca58-82c959d4bb4mr10970711b3a.6.1774864640008; Mon, 30 Mar 2026 02:57:20 -0700 (PDT) X-Received: by 2002:a05:6a00:f8a:b0:81f:43fe:988c with SMTP id d2e1a72fcca58-82c959d4bb4mr10970675b3a.6.1774864639520; Mon, 30 Mar 2026 02:57:19 -0700 (PDT) Received: from [10.64.69.173] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85fc756sm6320616b3a.47.2026.03.30.02.57.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 02:57:19 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 17:57:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/38] drm/msm/dp: introduce max_streams for DP controller MST support To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-12-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Z9JrgbXZkPyKkAjQ7TTsZwJGmyT44B-P X-Authority-Analysis: v=2.4 cv=efYwvrEH c=1 sm=1 tr=0 ts=69ca4900 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=_fflomLE3yKvlCkzeqkA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: Z9JrgbXZkPyKkAjQ7TTsZwJGmyT44B-P X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA3NyBTYWx0ZWRfX7JWvpo9ZuUou BKBqnObs4l3m082bizbScPuWI7Hqgyeu+bJ1H3A9w3ywdMNSFL7QzyooBoqAxrJu0vcZuPPLdlC HJJxRRgb2INJ1SvG2j1rgclEnIdr0N0Silb5sMJXv8Fz3TGV4lkHHESLkPJAmH3ud6OlY5eGm3V NsAIdjSuKAAC14bRfN16gVqtdFPpNvMjXLjVb2wy0LOoqb649Bc03Won//ekTUk+uvKY84oJaKn qpgs+CMoaQ2Hkg/+DPfmnQVAP51aT9Q3pe/z5AXib44ZcbWkkc0W3yUue81pqxzdTts9AyR+Ekn aOorI+3mIvOZLnZ0B0vgNXMq6KUGbLrGANCyQQGQPGsYVaq07o53cNcd/66rD18DeCfTTfflL52 amCqKEY/zAPmvp2q6ZBLEpq2St8KAdCazlh3gKj9U8lA7iZYXXSO164OpSHFn4qMZiZWsdd9Pyk dGdPn4vUcnm6UpQqj8A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300077 On 8/26/2025 1:42 AM, Dmitry Baryshkov wrote: > On Mon, Aug 25, 2025 at 10:15:58PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> Introduce the `mst_streams` field in each DP controller descriptor to >> specify the number of supported MST streams. Most platforms support 2 or >> 4 MST streams, while platforms without MST support default to a single >> stream (`DEFAULT_STREAM_COUNT = 1`). >> >> This change also accounts for platforms with asymmetric stream support, >> e.g., DP0 supporting 4 streams and DP1 supporting 2. > > How? > Each DP controller have it own msm_dp_desc ... >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 21 +++++++++++++++++++++ >> drivers/gpu/drm/msm/dp/dp_display.h | 1 + >> 2 files changed, 22 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index 78d932bceb581ee54116926506b1025bd159108f..a8477a0a180137f15cbb1401c3964636aa32626c 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -33,6 +33,7 @@ module_param(psr_enabled, bool, 0); >> MODULE_PARM_DESC(psr_enabled, "enable PSR for eDP and DP displays"); >> >> #define HPD_STRING_SIZE 30 >> +#define DEFAULT_STREAM_COUNT 1 >> >> enum { >> ISR_DISCONNECTED, >> @@ -52,6 +53,7 @@ struct msm_dp_display_private { >> bool core_initialized; >> bool phy_initialized; >> bool audio_supported; >> + bool mst_supported; > > Why do we need the separate boot field here? Isn't it enough to check the max_stream? > If remove mst_supported, condition "mst_streams > 1" will appear in multiple places. >> >> struct drm_device *drm_dev; >> >> @@ -84,12 +86,15 @@ struct msm_dp_display_private { >> >> void __iomem *p0_base; >> size_t p0_len; >> + >> + int max_stream; >> }; >> >> struct msm_dp_desc { >> phys_addr_t io_start; >> unsigned int id; >> bool wide_bus_supported; >> + int mst_streams; >> }; >> >> static const struct msm_dp_desc msm_dp_desc_sa8775p[] = { >> @@ -1213,6 +1218,15 @@ static int msm_dp_display_get_io(struct msm_dp_display_private *display) >> return 0; >> } >> >> +int msm_dp_get_mst_max_stream(struct msm_dp *msm_dp_display) >> +{ >> + struct msm_dp_display_private *dp; >> + >> + dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); >> + >> + return dp->max_stream; >> +} >> + >> static int msm_dp_display_probe(struct platform_device *pdev) >> { >> int rc = 0; >> @@ -1239,6 +1253,13 @@ static int msm_dp_display_probe(struct platform_device *pdev) >> dp->msm_dp_display.is_edp = >> (dp->msm_dp_display.connector_type == DRM_MODE_CONNECTOR_eDP); >> dp->hpd_isr_status = 0; >> + dp->max_stream = DEFAULT_STREAM_COUNT; > > Just use 1 it's not that magic to define it. > Will fix it. >> + dp->mst_supported = FALSE; >> + >> + if (desc->mst_streams > DEFAULT_STREAM_COUNT) { >> + dp->max_stream = desc->mst_streams; >> + dp->mst_supported = TRUE; >> + } >> >> rc = msm_dp_display_get_io(dp); >> if (rc) >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/dp_display.h >> index 37c6e87db90ce951274cdae61f26d76dc9ef3840..7727cf325a89b4892d2370a5616c4fa76fc88485 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.h >> +++ b/drivers/gpu/drm/msm/dp/dp_display.h >> @@ -29,6 +29,7 @@ struct msm_dp { >> bool psr_supported; >> }; >> >> +int msm_dp_get_mst_max_stream(struct msm_dp *msm_dp_display); >> int msm_dp_display_get_modes(struct msm_dp *msm_dp_display); >> bool msm_dp_display_check_video_test(struct msm_dp *msm_dp_display); >> int msm_dp_display_get_test_bpp(struct msm_dp *msm_dp_display); >> >> -- >> 2.34.1 >> >