From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF4C1268FDE for ; Tue, 8 Apr 2025 10:36:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744108612; cv=none; b=bDidKO7EWMiGCV9eIsdjylezY6p8OBHoKEYJPFvnw2J1EyvKf1pg3Pw6ub0wil1kt+H34rlTOtDgF0Kff0HF/YJhEPzzEoRObGHPGS4wzGtMRsPrtlfUEMia/qZP2PuLjsT51m1gYY4G/vgoXB47Whh/Non0W3htj48sRxUrhP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744108612; c=relaxed/simple; bh=wzJvWLjTqiJYfQ5XdcRzN/rVMxfu+Qr9nqKFKHXaH7U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IDZ3utGcPDQJ6EYRJCUqHvKhYDDeFvM6Bv9UbSsc2yODrlevU8Jg6wS59HjGpAoCX7Recyg7/c4+rycloKBmv5iirxaXBPUf0VvsplhLMMNLHXGR17ITtkljSyfwy8cqnBDeo70QwkURujNa4Xde/UHdX6U2wEJ3ZWKz+v4gFp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NLniHdUJ; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NLniHdUJ" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43d0c18e84eso27641325e9.3 for ; Tue, 08 Apr 2025 03:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744108609; x=1744713409; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+O8LIaQE6WLNSGODkrJEsZ72gySO7jid8n0Swavjxzs=; b=NLniHdUJXbcXaaa7RX9s84+MOKL4uWFm0cUNDMaGv7WrTXXMdHscmleYNqpwNK0wPI CuIDF+Cn78ulxZIXAQDuqOXDcoiVFLQ5Dqy7DY+QsPfwehNFC+JzuwoiJUfvezVlIASK WCI6WFNXrmfSwSL6s+7F37/Vu4g+wg86Sdq6QfS6KacgUE7FWI854n/c/ygp/LSQe9gv xUQ/RQW5dL8IWTdRN9gYBvbUbcyrdF9i0vSrB2OB6XZ2YFrWLNrV58lKyr97Iol/FGjF ByVZ9CCeGJsagnHgWSQka987ooPgm2QCFe7gCqB76GR18xG8D961Ns0PZllHQgoLfJgR 1plw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744108609; x=1744713409; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+O8LIaQE6WLNSGODkrJEsZ72gySO7jid8n0Swavjxzs=; b=GmtUsthpmK8NK45RkM9DPQNUxi+ZGKl0RR6fW/4iaKShSdIaR2ILFTcvV0Hv0ymyHD 3rIPUWt95b90Jd1DrtVFGBz9eB22wCNLYO4Lt630D0zYMoYm6WjXzRr7ccMYS56GBYtU mTYDKXRtvAJw515Y6hyYSNIDeGdGMQgVXmX9ng3Rjv016frU+ChWtEr8nYB/MgHc1Vea NPiDJys25Wka+35og/jZDUZggx/9E5RLfgpQT1qxuNcplREm8Rfrp7BNAX1og3Fd6uoF +rrAR8qn9QssK4z/m7l0fTrKkbUtB/cPe/rLGf8FT0z9gFIFEi3wskJFHzacWh+Yk1oi OtmA== X-Forwarded-Encrypted: i=1; AJvYcCXHgHA6PrXP5D/1QEvOCNzdvrzKammrtuy6it4R9Z6ewP8R2FP58c5+WsvMskb5ZaEmgprPJYhu+3q/sJs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4KorX+sTgUuuaZ0HfBQ9LXNN9oqvQifkPhEoR29UNF1xjo7qe 7HzLOsntVxP1+YoNKGt6m6wC/pJ3JX0a74nWWLPcYI2CFFGedP/c0sRRTv7vpJo= X-Gm-Gg: ASbGncvyj92xHyqnDlSqMTKcaOS44VPmAxQHYWsg5sSSrfx76fp1TECn0sL28b7eYkG zcutZ54BOlUvxrKl2gPHO1ubkG9eAJwgyC/jDyratzG2PIdVXm+bfBJgSDfTRc6jhsY5upd5DKP JTC1ZhM5Br24at29G/siULfldgRFxJOCjT7hk+dqXCPbRnO8IQ+31M8K/uibgXHjKLvndwiuRW3 WGabYf+j6q4AkS0cuXA7m3MypEQDDBOHEJVcpUYJE/ZlkvXVRRo6JbSo17cIYbtXcovgOMZnrLQ fbLs1lnyMrTdTZiP3jWrYOVOV6IUVn4FqrVu/tdBBMKExvwdCA== X-Google-Smtp-Source: AGHT+IGOw9Xy8oGk0GJfiu7VaitjR/t55edX0t5tshdnocYA+5fRdb4Pypir8G5VxuDaVk6MtoCiMg== X-Received: by 2002:a05:600c:3494:b0:43c:f8fc:f697 with SMTP id 5b1f17b1804b1-43ed0bc8d96mr155476115e9.9.1744108608941; Tue, 08 Apr 2025 03:36:48 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39c30095ea8sm14397521f8f.20.2025.04.08.03.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 03:36:48 -0700 (PDT) Date: Tue, 8 Apr 2025 12:17:54 +0300 From: Dan Carpenter To: "Peng Fan (OSS)" Cc: Sudeep Holla , Cristian Marussi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Peng Fan Subject: Re: [PATCH v4 3/7] firmware: arm_scmi: imx: Add i.MX95 LMM protocol Message-ID: References: <20250408-imx-lmm-cpu-v4-0-4c5f4a456e49@nxp.com> <20250408-imx-lmm-cpu-v4-3-4c5f4a456e49@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250408-imx-lmm-cpu-v4-3-4c5f4a456e49@nxp.com> On Tue, Apr 08, 2025 at 04:44:27PM +0800, Peng Fan (OSS) wrote: > +static int scmi_imx_lmm_protocol_attributes_get(const struct scmi_protocol_handle *ph, > + struct scmi_imx_lmm_priv *priv) > +{ > + struct scmi_msg_imx_lmm_protocol_attributes *attr; > + struct scmi_xfer *t; > + int ret; > + > + ret = ph->xops->xfer_get_init(ph, PROTOCOL_ATTRIBUTES, 0, > + sizeof(*attr), &t); > + if (ret) > + return ret; > + > + attr = t->rx.buf; > + > + ret = ph->xops->do_xfer(ph, t); > + if (!ret) { > + priv->nr_lmm = le32_get_bits(attr->attributes, SCMI_IMX_LMM_NR_LM_MASK); > + if (priv->nr_lmm > SCMI_IMX_LMM_NR_MAX) { > + dev_err(ph->dev, "i.MX LMM: %d:Exceed max supported Logical Machines\n", > + priv->nr_lmm); > + return -EINVAL; This needs to call ph->xops->xfer_put(ph, t) before returning. > + } > + dev_info(ph->dev, "i.MX LMM: %d Logical Machines\n", priv->nr_lmm); > + } > + > + ph->xops->xfer_put(ph, t); > + > + return ret; > +} regards, dan carpenter