From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
To: mcgrof@kernel.org, linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, error27@gmail.com,
kernel-janitors@vger.kernel.org, arnd@arndb.de,
dan.carpenter@linaro.org
Subject: Re: [PATCH] module: Fix use-after-free bug in read_file_mod_stats()
Date: Wed, 17 May 2023 12:03:39 +0530 [thread overview]
Message-ID: <c7253c5f-248c-2f01-c518-f7dd747e274a@oracle.com> (raw)
In-Reply-To: <20230428055933.2699308-1-harshit.m.mogalapalli@oracle.com>
Hi,
On 28/04/23 11:29 am, Harshit Mogalapalli wrote:
> Smatch warns:
> kernel/module/stats.c:394 read_file_mod_stats()
> warn: passing freed memory 'buf'
>
> We are passing 'buf' to simple_read_from_buffer() after freeing it.
>
> Fix this by changing the order of 'simple_read_from_buffer' and 'kfree'.
>
Friendly reminder to review this patch.
Thanks,
Harshit
> Fixes: df3e764d8e5c ("module: add debug stats to help identify memory pressure")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> Found with statis analysis, only compile tested.
> ---
> kernel/module/stats.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/module/stats.c b/kernel/module/stats.c
> index ad7b6ada29f2..6ab2c94d6bc3 100644
> --- a/kernel/module/stats.c
> +++ b/kernel/module/stats.c
> @@ -276,6 +276,7 @@ static ssize_t read_file_mod_stats(struct file *file, char __user *user_buf,
> struct mod_fail_load *mod_fail;
> unsigned int len, size, count_failed = 0;
> char *buf;
> + int ret;
> u32 live_mod_count, fkreads, fdecompress, fbecoming, floads;
> unsigned long total_size, text_size, ikread_bytes, ibecoming_bytes,
> idecompress_bytes, imod_bytes, total_virtual_lost;
> @@ -390,8 +391,9 @@ static ssize_t read_file_mod_stats(struct file *file, char __user *user_buf,
> out_unlock:
> mutex_unlock(&module_mutex);
> out:
> + ret = simple_read_from_buffer(user_buf, count, ppos, buf, len);
> kfree(buf);
> - return simple_read_from_buffer(user_buf, count, ppos, buf, len);
> + return ret;
> }
> #undef MAX_PREAMBLE
> #undef MAX_FAILED_MOD_PRINT
next prev parent reply other threads:[~2023-05-17 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 5:59 Harshit Mogalapalli
2023-05-17 6:33 ` Harshit Mogalapalli [this message]
2023-05-22 21:21 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7253c5f-248c-2f01-c518-f7dd747e274a@oracle.com \
--to=harshit.m.mogalapalli@oracle.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®