From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 515461A071C for ; Thu, 19 Dec 2024 19:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734636748; cv=none; b=J6pxckUn1TYpI0n5wKdiqIjWoav/Z7YBUPy17IpvbeyaZSnUQq/D7I+QegC22727ywx+KhJpQk6HWZ+LRv3S9n+38Bizns1VEEIH/JYVwCqyGgrOMZcbejyvwFrhxJZO7LmimaLScWs457EVbGvL7MUSRLLuXeTpc2Rz4kdphT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734636748; c=relaxed/simple; bh=XisdETZGt1xGd/tAcysR1gf7SJZ+Q0OQ6PAQF/dE/QU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=md/3YmF6/CjUYoj55fEE34LcEHk0ehc79mnvyoO5b3gU7VmVTJkZfRXLm/D0NEVAbrNMUTKWHYSeKis6yrtWga4ML1Y13BU9U4VTq7cnVnTXLfK4PCQesMC4IFqqwwoRAg34ElZ/6MWrDfOsA28i+TgWDIWN+9SONvlB6iKIPzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UVoS8Tnq; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UVoS8Tnq" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-53e395932c6so81647e87.2 for ; Thu, 19 Dec 2024 11:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734636744; x=1735241544; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IW/1H+wBsYHEd+yu91SFC/VMNkW4y30uxY2FjxFoA0k=; b=UVoS8Tnqvuihmed2kUERhKZeQvCpgyWsPVaDN7L9hyd6tUbSpenigE12GRuJFJZhvq tFQy2fSgsZ+9iAStZ7rDB6gw9nzmd4fGCIgx5Z7OzWDQmKA6Z8mHTeBPb9cfmGJTQdc/ opaTLmKM8igS7ONiZ5wTj8RIip2RAZ1K8jva0b0Eck3fClr/mwl/PDIHUc0/H4EeP/6v ZqRTPBSSaw/q06TFFOLTnXZmd3Sa7QblVGyZfVrE8sXO3XESwe/cPFJkTwnvKbyKnYuo LSvkLxn7RRh4BWKIccHXv4+thDs7VxPa6OY5h1NJPG/Xirn1kZvfzrMG0ShIw5nGSe9Z 5j5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734636744; x=1735241544; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IW/1H+wBsYHEd+yu91SFC/VMNkW4y30uxY2FjxFoA0k=; b=afq5uka7zCttETxTiG7cYRX3GLfxkYK+6lTyVk772Szb60luS8HOkPzSlRcCAN4VXT /+i2TsYyDvtgpKY2jdSWnm8sqDfBPGk5aaqNKdCZcGTvwkF0qm3xJ/cobIr0bjU243R7 BNAQl5gCNq22kzocKak/NC69VszLvVE50Ta1S2zOOgpT3CSeCdfDum3hbUoRDsyVBQml JHgGDYGXift81yBI+3y3QcWgdkxhdvmGiLYjZimhwe4trTMfQnYq56vmGKRn+SnT2qpV eSe+mQAj+xQlptf4ZD0kpqb/qEyymadTdfLUBCACboawHnDAXkQZEcsEkybcJ8jjA2aZ cArA== X-Forwarded-Encrypted: i=1; AJvYcCVl4CIO8ZDcGZyMaIRzx9VEG4cQp+vHmz0MPiDk4cu85wC4136SExyC/422xLMD6udRX5gJn42ajDR8V4s=@vger.kernel.org X-Gm-Message-State: AOJu0YwocDH7aWB87zQ9Pzhx1H2JNul/nslrzUOjhSjH31aFRPVaOMy/ VtSRqXWu6LKaVOa8gQB2VkDYipMx2PTXc+tr8OcemjqHuAcyLDBIyOfZtP5angg= X-Gm-Gg: ASbGncuY1n4xbZ/sssHfgtHO8jIuyDQRMQJl57aJFkK4cA9DT3b0X8r/lG6phOUkwNI 1nC0s8h8w44Cfd0yyLZYMeMyzlWvoS6JMPTC4NO1/Edy0KOIahdtBjnpH1Jqp6KxWA+uK7lSDpP 6rrLmcvaNoCCBHnWnuZTdNMl0k7gQrje5NCGOUev43ZQdFFMlbVyFXOsZ7MJ8vEWS1DD1KXgCxR yn0WQbQCsTUkSf7kerGzpwfo1nn/xAK7AofJvD5alO/RnGiAL1ulIH4dcNBfLr1TNKwkdwMSTcR ade53731Oi2xEuErEq9PNYZ33/jgtNsB7FE= X-Google-Smtp-Source: AGHT+IHUvBst8RiUn9IST8/5AjNtAtHUWTb9tBGd8LLvhOk3TajPDIYTYMQtaGEJvz/fTfQPjsQaIg== X-Received: by 2002:a05:6512:398d:b0:540:2aeb:5d3c with SMTP id 2adb3069b0e04-541e673d7c7mr950150e87.2.1734636744478; Thu, 19 Dec 2024 11:32:24 -0800 (PST) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-542235f5d88sm256403e87.15.2024.12.19.11.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 11:32:23 -0800 (PST) Message-ID: Date: Thu, 19 Dec 2024 21:32:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 4/4] arm64: dts: qcom: qcs6490-rb3gen2-vision-mezzanine: Add vision mezzanine Content-Language: ru-RU To: Konrad Dybcio , Vikram Sharma , rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, akapatra@quicinc.com, hariramp@quicinc.com, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20241217140656.965235-1-quic_vikramsa@quicinc.com> <20241217140656.965235-5-quic_vikramsa@quicinc.com> <22479c27-9265-4994-8974-9739ecbae5ee@linaro.org> <99cf5f7e-43f6-4ac4-a4a2-dc731b695572@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <99cf5f7e-43f6-4ac4-a4a2-dc731b695572@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/24 21:06, Konrad Dybcio wrote: > On 17.12.2024 3:40 PM, Vladimir Zapolskiy wrote: >> On 12/17/24 16:06, Vikram Sharma wrote: >>> The Vision Mezzanine for the RB3 ships with an imx577 camera sensor. >>> Enable the IMX577 on the vision mezzanine. >>> >>> An example media-ctl pipeline for the imx577 is: >>> >>> media-ctl --reset >>> media-ctl -v -V '"imx577 '19-001a'":0[fmt:SRGGB10/4056x3040 field:none]' >>> media-ctl -V '"msm_csiphy3":0[fmt:SRGGB10/4056x3040]' >>> media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]' >>> media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]' >>> media-ctl -l '"msm_csiphy3":1->"msm_csid0":0[1]' >>> media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]' >>> >>> yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0 >>> >>> Signed-off-by: Hariram Purushothaman >>> Signed-off-by: Vikram Sharma >>> Signed-off-by: Trishansh Bhardwaj >>> Reviewed-by: Bryan O'Donoghue >>> Reviewed-by: Konrad Dybcio >>> --- > > [...] > >>> + rst-pins { >>> + pins = "gpio78"; >>> + function = "gpio"; >>> + drive-strength = <2>; >>> + bias-pull-down; >>> + output-low; >>> + }; >> >> I have doubts that it's proper to embed a reset gpio into driver's >> pinctrl suspend/resume power management. >> >> Konrad, can you please confirm that it's really accepted? >> >> I'd rather ask to remove this reset pin control. > > There's certainly some appearances of this in the tree. > > You could make the argument that it makes sense to prevent misconfiguration > (i.e. the bootloader may set the pin in input mode), but then the counter > argument is that the (Linux) gpiod APIs request OUT_LOW/HIGH, and we would > expect that the driver uses that if the GPIO is requested through > e.g. reset-gpios. > > I'm not particularly sure what to recommend here. Krzysztof? > I'm worried by a possibility that a device reset/shutdown control GPIO could be turned off by entering the "sleep" pinctrl setup. If a particular GPIO/pin is off, is it still continuously functional as a control GPIO of some device? I believe it is not anymore in general, this is my concern here. -- Best wishes, Vladimir