From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EDD01A2851 for ; Wed, 21 Aug 2024 07:08:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724224112; cv=none; b=fHJPBiyriWyC9/QpzJp91XuauLFCC3pjrJ8M1aeV+2Fplt9B9YpBUGN5Ve9zeGW7ucWktMYUdbvu1yVp9Y0PKE7F4DVz6HDxET3odnZHDJb7yPr2a3hxbRPha8omoCNtZjCzM7psPlaekGzHnKUulsH5Pf1yARxhYdOOzRSjeg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724224112; c=relaxed/simple; bh=CLEdfv65cmZ7yOiRS4fBiMrgUE1o5HGN+bVab4VE4Dw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rlcr2PofixzcKJU2kKyN8JQcNSo+mDlxG/xgokvMxn4moYD9iMay9aO2+H4NihHjazhy46nmYSeHMcGijzLNOKsR2C+M4mgAIn97y+YGo/XtwAQ0ZyaksZDf5M75OoCeqLPRp+DdGwSaaYUb0Od3mOmrNFi7r6q26vJ7FDYhm1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IIUNDe8t; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IIUNDe8t" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20202df1c2fso3093375ad.1 for ; Wed, 21 Aug 2024 00:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1724224110; x=1724828910; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XMySUmxyXV0NOwpl4IYLel9pKasMWHD/SNyRw5xpg6U=; b=IIUNDe8tnfZRDi7sAWxlsPZwOxyflrIy+4Vx/U1tWU0Y7aVuEUA/SW71zXr+/RdR8y xTUDmVVmCOQNntWXFlt5jutWXXknZr6UU4c24ZtHwL39KzcUS0qlDdgEnSCDzTrkBTuY QckW9INcdw5BbyOBQXi5WSoxmh+CZsaMGlyYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724224110; x=1724828910; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XMySUmxyXV0NOwpl4IYLel9pKasMWHD/SNyRw5xpg6U=; b=K3sA0r3r5HkB/eJkXOoXRwTyLt5ON53tJWxmJ1APduwmALudhjey//Omac3MQPv1kx vLOus02EWSjyu/+3SBmCzvl9TbuW987l3bWiQ58fWyTw/Cpkd//hZIadLAw5cfjbvXwm MNb7g7XnUhpaeDKzebElSZ4KXX4Lb8ZPb6YpMTkMwXXOU5T9kFlhLOH3z0LFDMGDJJb1 lNC3/KjJUIZ6vcFpJxxfv6fvF0l+wy4yGbZI/WAL9fA1TV2bpqLgdh4Eh4qH9QBvDGiE qub8PVVA18tXPhATsVRmNoNd63p1oMDQ0OqNW7heDW3rzcjbdi1MG+HwVngoHm2Elvw9 n/LQ== X-Forwarded-Encrypted: i=1; AJvYcCUCRGBKGDU/VGfgjQW+zPrcd4OU9dDrOnzfb6N2L5o8sQTtyEnwPSOI2uNmvC6uAIlC+7eRIG4pSIOz1Q4=@vger.kernel.org X-Gm-Message-State: AOJu0YyjjUyH8zIyeQe1B/N+5z1JYvNZ9QKsPU2yYx5uVTSxaKWBajXg ukFgqj3Q0zYwXZojji4XMZzNSBl9xRnbaqx1ifZFXflW8/rBVleFrYqoPdli+SM= X-Google-Smtp-Source: AGHT+IHrSweQAP5MHApPfx8uzHjaXvrxcGV1j8LFNsPci/5pjmOxrBTZPRenC8Fnbcs7qh+Tk05sYg== X-Received: by 2002:a17:903:2352:b0:1fd:70a6:ffbf with SMTP id d9443c01a7336-20367ac9444mr30836105ad.2.1724224110169; Wed, 21 Aug 2024 00:08:30 -0700 (PDT) Received: from [172.20.0.208] ([218.188.70.188]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201f0302e84sm87841825ad.32.2024.08.21.00.08.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 00:08:29 -0700 (PDT) Message-ID: Date: Wed, 21 Aug 2024 01:08:25 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2][RFC] Add SWIG Bindings to libcpupower To: "John B. Wyatt IV" , Greg Kroah-Hartman Cc: linux-pm@vger.kernel.org, Thomas Renninger , Shuah Khan , Linus Torvalds , linux-kernel@vger.kernel.org, John Kacur , Tomas Glozar , Arnaldo Melo , "John B. Wyatt IV" , Shuah Khan References: <20240724221122.54601-1-jwyatt@redhat.com> <1f5c24b6-f3ee-4863-8b7a-49344a550206@linuxfoundation.org> <2024080405-roundish-casket-2474@gregkh> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/20/24 00:40, John B. Wyatt IV wrote: > I wanted to follow up on this since I am close to sending out the v2 of > this patchset. > > 3 points I wanted to raise: > > 1) Does everyone understand, is okay with the SWIG license, and wants to > proceed with me sending in a more complete version of this as a candidate for > upstreaming? > > 2) About maintainership: if I am to be the maintainer of this, how would > myself and John Kacur be listed? As a CPU POWER MONITORING SUBSYSTEM > maintainer, a separate category below it called CPU POWER MONITORING SUBSYSTEM > PYTHON BINDINGS maintainer, or is not needed to be listed at this time? > > A quick search for bindings shows what I believe to be all of them for device > tree. This may establish a new precedent. > > If I was to be added, I assume it would be a separate commit in the v2 > submission? > > 3) I had to comment out powercap_set_enabled > > SWIG reported this symbol not being found despite being in powercap.h. I did a > quick search and was not able to find it's implementation in powercap.c. The > get equivalent powercap_get_enabled is in powercap.c. Wanted to check on this > just in case it is a bug or part of future functionality. I am assuming the > latter; I would send it v2 with that declaration commented out with a note > explaining it for users if there is no objection. Yes please send a complete version for review. thanks, -- Shuah