From: Markus Elfring <Markus.Elfring@web.de>
To: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>,
linux-clk@vger.kernel.org, Brian Masney <bmasney@redhat.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] clk: st: clkgen-pll: Add cleaup in clkgen_c32_pll_setup()
Date: Thu, 15 Jan 2026 13:27:46 +0100 [thread overview]
Message-ID: <c72b1bfa-706d-4ef0-913e-38c42a49d182@web.de> (raw)
In-Reply-To: <20260115044439.632676-1-lihaoxiang@isrc.iscas.ac.cn>
> In clkgen_c32_pll_setup(), there exists several leaks if errors ouccers.
occur?
> Add iounmap() to free the memory allocated by clkgen_get_register_base().
> Add clk_unregister() and kfree to do the cleaup for clkgen_pll_register().
() calls? cleanup?
Please avoid such typos at more places (including the summary phrase).
> Add a while to do the cleaup for clkgen_odf_register().
> Use distinct variable names for two register calls' return values.
I would find such sentences a bit nicer with a formatting for enumerations.
Regards,
Markus
next prev parent reply other threads:[~2026-01-15 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 4:44 Haoxiang Li
2026-01-15 12:27 ` Markus Elfring [this message]
2026-01-15 12:34 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c72b1bfa-706d-4ef0-913e-38c42a49d182@web.de \
--to=markus.elfring@web.de \
--cc=bmasney@redhat.com \
--cc=lihaoxiang@isrc.iscas.ac.cn \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®