From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838B6402BB3 for ; Tue, 24 Mar 2026 15:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774365501; cv=none; b=e2M6EcArxYymwDyM0HoorkGi/+rCNDTO0doUAJdLyEhiJ709+792ccsVT/PrMSqJrOnjrK/H2V8++vNcJIyP7SCHS35zePb5kLkDs6Q6CADepI7m96c0Luex2weNQGR0qAgO0azi+ssvXOWAzqtrIfUSrX6gusxYHzjWJ6C0i24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774365501; c=relaxed/simple; bh=bo1tIVwKXcsfTJvBYLLU0MhLGgWxzZPvo83Lt0ymvjQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j3aBHpZB/DBA/t1+D0K2Mh0IhqPxXxC//+qqBS8tyvpynMdmPe6ohnlNKFgOOuC82wUNnhO1vswNLQFa2MMyqa6WJgkAI6rhR3ymvl8pacJKx7pvIrbBOd/9Vl6G1SxguXqRAiRm8XVNBohfzPG1DHxD31XlYtyn6j8qIiCvidM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=pCU6nPgn; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="pCU6nPgn" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62OEYcxo3559585; Tue, 24 Mar 2026 15:17:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=f3OTHy tKuvDipWBXDZMqSX0aVAx6IXCWrgqyxj3ydJo=; b=pCU6nPgnPlEai+yNjr4vqO izYJD65R8Yqnm4MgZ1jIT/vQufPVK3JtvxDqH1+RbAewNouplF3WlXdDVgsgBgBy weTYwAATWc89XVyCT9N8OJe7pr6u+k5yXuOpMq3eoFiblRBsEV4Eqvo7l2Wa+Hoy fS7Bwstm68yMsNas/9DFT3RInBms7BLLT4mHe8Q9cA3MxMs+yK7SOAE1amiOdVOp NFKjYjuXT8AnnH0mnnk48nIJCla3yF1ab1Buk0YOzAAuDRyKAWc7bqW1nkV0p0xl +mWwnKq/o51ydaSKJRw8Ka9Btszj4N5VteYqkNnCy7smzRqrU+urNe+vlcBZEnag == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1ktuukrv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Mar 2026 15:17:37 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62OCXkw8026797; Tue, 24 Mar 2026 15:17:36 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d275ktcxx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Mar 2026 15:17:36 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62OFHYFE30540408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Mar 2026 15:17:34 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C23152005A; Tue, 24 Mar 2026 15:17:34 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 41AB82004B; Tue, 24 Mar 2026 15:17:27 +0000 (GMT) Received: from [9.39.25.102] (unknown [9.39.25.102]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 24 Mar 2026 15:17:27 +0000 (GMT) Message-ID: Date: Tue, 24 Mar 2026 20:47:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v8 05/10] sched/isolation: Mark housekeeping_overridden key as __ro_after_init To: Valentin Schneider , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Arnaldo Carvalho de Melo , Josh Poimboeuf , Paolo Bonzini , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Sami Tolvanen , "David S. Miller" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Mel Gorman , Andrew Morton , Masahiro Yamada , Han Shen , Rik van Riel , Jann Horn , Dan Carpenter , Oleg Nesterov , Juri Lelli , Clark Williams , Tomas Glozar , Yair Podemsky , Marcelo Tosatti , Daniel Wagner , Petr Tesarik References: <20260324094801.3092968-1-vschneid@redhat.com> <20260324094801.3092968-6-vschneid@redhat.com> From: Shrikanth Hegde Content-Language: en-US In-Reply-To: <20260324094801.3092968-6-vschneid@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: lh1l74MIxKV7Fg_fwq_BieQeDYV6h-gv X-Authority-Analysis: v=2.4 cv=aMr9aL9m c=1 sm=1 tr=0 ts=69c2ab12 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=20KFwNOVAAAA:8 a=7_2Gcuf7Guj4Ce4GsV0A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDExOSBTYWx0ZWRfX1/ZffR5oMZ7x a32Hf/e+ABZBoL23PyRlPV/2b7h7Kc39ci3+3xosDrv48bm5ihck6SH2fd7JTy/wf7M4ucdS0PZ ekCKE/Inl+Z1wcta4U5JVFl7ZcoKPDeMub0yPBBqyDVMmjOtsjWbStRjqct4/TYeNUDgm26kHri ToburL5ciKtQge7yPQidqSJlpRSNbt6z6zHbK/lhgvpnxCzSQRkgq81WuZws61MJy8u7JtBo5Zm HmLpep3RfRR8yLIORnyLfw9+DnIj7NB8xkdeHhJ7ZQOyuHCsrSSZv2e+HHsU+cHvC5vlHqH8MP9 Qn0CThDarfzCNoiv0cY00YTb4wqF3OFn5uOxn1CdviXff6iYKIvCeLOz5J84FwRYyspK4zC45/j zExG2xX5Dd8v+fidhbt8YJKOD3kld8LVCmH7OhZrg3MDB3ozFdy1Oj1199ySD/vNyrhKn4QeEVQ t39FmEiG6w/+gsu9gZw== X-Proofpoint-GUID: fs3pHPZOFeMxFT6VksEiHD_LbNcsVRBv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_03,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1011 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240119 On 3/24/26 3:17 PM, Valentin Schneider wrote: > housekeeping_overridden is only ever enabled in the __init function > housekeeping_init(), and is never disabled. Mark it __ro_after_init. > what about housekeeping_update which could be via isolated_cpus_update when creating isolated cpusets. > Signed-off-by: Valentin Schneider > --- > kernel/sched/isolation.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/isolation.c b/kernel/sched/isolation.c > index 3ad0d6df6a0a2..54d1d93cdeea5 100644 > --- a/kernel/sched/isolation.c > +++ b/kernel/sched/isolation.c > @@ -16,7 +16,7 @@ enum hk_flags { > HK_FLAG_KERNEL_NOISE = BIT(HK_TYPE_KERNEL_NOISE), > }; > > -DEFINE_STATIC_KEY_FALSE(housekeeping_overridden); > +DEFINE_STATIC_KEY_FALSE_RO(housekeeping_overridden); > EXPORT_SYMBOL_GPL(housekeeping_overridden); > > struct housekeeping {