From: Joe Perches <joe@perches.com>
To: Anirudh Rayabharam <anirudh.rayabharam@gmail.com>,
gregkh@linuxfoundation.org, hadess@hadess.net,
hdegoede@redhat.com, Larry.Finger@lwfinger.net,
dan.carpenter@oracle.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: core: fix line over 80 characters warning
Date: Wed, 27 Mar 2019 19:13:16 -0700 [thread overview]
Message-ID: <c732d470fe9ceec03b65cb92ea997e6db4e6385d.camel@perches.com> (raw)
In-Reply-To: <20190327181836.GA37876@auvm>
On Wed, 2019-03-27 at 23:49 +0530, Anirudh Rayabharam wrote:
> Checkpatch.pl complains that these lines are over 80 characters. Use the
> "psecuritypriv" pointer for consistency, remove unnecessary parantheses
> and fix the alignment.
>
> This patch just cleans up a condition, it doesn't affect runtime.
[]
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
[]
> @@ -2336,8 +2336,8 @@ void rtw_ap_restore_network(struct adapter *padapter)
> Update_RA_Entry(padapter, psta);
> /* pairwise key */
> /* per sta pairwise key and settings */
> - if ((padapter->securitypriv.dot11PrivacyAlgrthm == _TKIP_) ||
> - (padapter->securitypriv.dot11PrivacyAlgrthm == _AES_)) {
> + if (psecuritypriv->dot11PrivacyAlgrthm == _TKIP_ ||
> + psecuritypriv->dot11PrivacyAlgrthm == _AES_) {
> rtw_setstakey_cmd(padapter, psta, true, false);
> }
You could remove the unnecessary {} braces here too
next prev parent reply other threads:[~2019-03-28 2:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 18:25 [PATCH] " Anirudh Rayabharam
2019-03-27 6:36 ` Dan Carpenter
2019-03-27 18:19 ` [PATCH v2] " Anirudh Rayabharam
2019-03-28 2:07 ` Dan Carpenter
2019-03-28 2:13 ` Joe Perches [this message]
2019-03-29 16:13 ` Greg KH
2019-03-30 11:58 ` Anirudh Rayabharam
2019-03-29 21:16 ` [PATCH] " Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c732d470fe9ceec03b65cb92ea997e6db4e6385d.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=anirudh.rayabharam@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome