From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14D08392837 for ; Tue, 14 Apr 2026 08:39:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155949; cv=none; b=DdwZUxPJCIJUSU2HcNboDuKi9U+ChN5OHhpuoCB1G5GLUSV9uQBwMxTDwkKVahC6bPnG35WCIbYtvklwlfDbyxOMfEeUbJiOmzFbP6F8bLmV3k1W5sOkXpzaI2pkoIqneI/7ZErdCRUiPiGYvjjLBpSjL4m4qaoeGEoFQp3dhGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155949; c=relaxed/simple; bh=2OM0Bj5MdJC/WW/lvYXymofwjCsnlyzXjNUwgtvtWvo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pNQknixPp/7nEpOhdhUV6vHC3sQQdgrH7xrCpkSp9MzLi3zqqWrYIrEr1zGW4+HPwXamGTir1V2CFTkvCzrJpJxsU+ARSHADCi04fKnu95TzJtH36mPIGfX+Z8I2taRgTkMQzpFKYPPs/AdvF6eG49L9Xww9V9nyMvo6+hM9zgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fh05gK9Z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gSHfdmQJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fh05gK9Z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gSHfdmQJ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6lxQS1478949 for ; Tue, 14 Apr 2026 08:39:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OHglZFOx9lNBJSLn5k6IqHh65sPfy2JLY48LcxRXXXs=; b=Fh05gK9ZTOAAKx+N +HIRuU5AzjaBQoWUKfh0GyjyiP61ilvHbjrbM2OCdc7BdRZEdMFWCNUHaxzfai9C MkowhfReTY55qoq3HMIeKgaKOLeicZiYOmQ1QmLJ5O3y1KqyBed77oWAzGIxTDmL NHa1s8E1J4WQmVyOml6cFUpwnwDissCHfq5i9A77BLhn8v44WrikSLbkxoKev87Q 2mHKROmeD5kAr68V6jkh/vqSeM3uq4aBrkVOxILa/Xjn0GK5cirNUpvEFBD8g4Kv eGlPN1X8fwenm3+kOczaUhFsWSJCdB8B6okOl8cp68Z8QaMYnQa0jOqt1s8Y9V5T eYMNMA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh87j1u3f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 08:39:07 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50b27636835so10237311cf.3 for ; Tue, 14 Apr 2026 01:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776155946; x=1776760746; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OHglZFOx9lNBJSLn5k6IqHh65sPfy2JLY48LcxRXXXs=; b=gSHfdmQJKyVlkOKZv+c1qLaip7VEzFlSEY5iOR8d/HPxmJSDQGNuwPRPJjfHeCWETI J1M2zuOxjlxTER3MCoAjdAD2g/LTG2wPjKyvX1RFuViG3yfY8SSNK4o/ZQQL+gClRZI0 68jOp93Cm8Y/kpyZoEejsMGsPuxQ/FAIXknkl6QlmQOmV578SaoetkoLCqwPz7ZaHGhJ LzPXRUhkKRz1sQbX+ukgB0D/7N4Dq++lQVPGN/S8J9dHNCUSAMpp9ceUtuVD2yU+1CN4 M16DwnvJOQYbOz0b20676IFplfRGCcQ5lhi7P/7NqayxXvNwWujdywo7m/fIR1Yf9YYv Dj4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776155946; x=1776760746; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OHglZFOx9lNBJSLn5k6IqHh65sPfy2JLY48LcxRXXXs=; b=FBvmxXD6Ngc/ScaRo80SEbltgzY/kkMCzbAxTlvUDFr430uZeWEcVZAuRQvxpXQmGK /Io8o6q7t0LHyqJCuS2wA+Ee9m4DCw5sT4EgcE5bMRe8yA6r26wtHx6iJcCWiNLhNODh UxjUozp4Xya163J2BhNJxg+mgz86Gqa96n9s1Z6WPfmuN30mzvn7ZOjj47WHps/UBCnf OM3/Rvg4nW4WUkFkzCnII43u5dJUTa5CsmWSnvp/qwcMm/73z0IsUTwcx8dj2ZefY6VW dgyOr3B/aV7mZBbjkB2qphC1iyHq1aDSTPn6E1WLbCxDqfIYZp2CjPpR3xtfctZc0q2h 8knA== X-Forwarded-Encrypted: i=1; AFNElJ9xwfiKcCJBznKEU5SpFNSAR74SiEQSKzKZsYISTldP+ZimTVb7Ay49JKMjjjtA/273ghPerQTuGs0W8Ng=@vger.kernel.org X-Gm-Message-State: AOJu0YzT2hrafQJHhyduxpDM3jhRLc5rz8k/g1LBnPhZaNqQLMG3GH2m +FOahgmZxm8K3OXfQzv/GPirTiOyeuvIeLKHtzD6dvFfUy8KpIXuZfLB2cNJwMku0IISIb0YnA2 kOt4N+w2aWqe+6Nj6UqTBRsjOaunLgKPH0Xz2Iv4QyI2csNiR2zhxwZOpOoT14rDOR7g= X-Gm-Gg: AeBDietNHbo6YQYQJLb8U2xQbMULFpPGs585kqsS444tWVlAIzmvB808tSgYKprCCDz 70mXCy3U3ddpOOrOb4h8/skQDGTklkPqdc4kNZ9dkz7hccE+r1gnUyg4/KGo7VtWAXCj1tzop/J dA8JCvC7KiLKLYUR7Mv6I/26TRweTD3KFjXDzmldOK8XROM/+by5cux4jfFfTWMlXL2sfp7cLol F37G03UpzNvhacwfbUtQ3JQ+YF59b9BqxN6PbIJJiBcc8/+z1NZQ7voPknCi9cfEz5yGabSJzze zfg5M5TkewFxPgHpop/CGM1+kkQmN/IrqI3uRMtZMQsu876HEXifImmt+zCUnSTepNej0TKbppB iFDqAgK8Qdl5JGLVDU+18fzLA8plelAewhpNCxqQ3EGGWOwC8LLKvAcsM8GQtbVRooXjZZYAooL AHVZynGCLhYMcyJQ== X-Received: by 2002:a05:620a:1721:b0:8cf:d68a:9a96 with SMTP id af79cd13be357-8ddceab5d14mr1619129385a.4.1776155946523; Tue, 14 Apr 2026 01:39:06 -0700 (PDT) X-Received: by 2002:a05:620a:1721:b0:8cf:d68a:9a96 with SMTP id af79cd13be357-8ddceab5d14mr1619126885a.4.1776155946105; Tue, 14 Apr 2026 01:39:06 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-671d70c9656sm350209a12.31.2026.04.14.01.39.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 01:39:05 -0700 (PDT) Message-ID: Date: Tue, 14 Apr 2026 10:39:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] pinctrl: qcom: lpass-lpi: Fix GPIO register access helper return types To: Ajay Kumar Nandam , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com References: <20260413122233.375945-1-ajay.nandam@oss.qualcomm.com> <20260413122233.375945-3-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260413122233.375945-3-ajay.nandam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: SD3REkOapkauqyfyXyZ9XoTn20ugIQLT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA3OSBTYWx0ZWRfX7R/plj6zqnBp fgRCF7uC2594lQr7kgFISLdC4Quke2lN6XFVgrW0PuJc0fRwoF87M5FUX/Tt3/OfEcdbM8SZ22u Z7HNObUbnMBtkhFZZeLt0KmRsEK+6O5VgS7od9dAiLq8O3VzVNgugpX7uroyam5ls3gpkILt2I5 dmmwOWstSiltlauIRjcgQtBvHUMv7Qh1GrWu0UYC8mG8D1Fz2vXahzh8sJfsEG0Bq1FDXZW1wlL uB4VIV+e5X1VWp4dOejgqGNZ7wVOnx51WFFQ964LeDAYsyJyVs/ot4lWq6z5IjIf83cIqoJweRb lwrRYTqTJNm0Fx74EzpoHDw56+En3+n7iXKEOfPa1J0EaEVEFy0g1YrOwbaIwybZP4a0QWueZs+ qqALZx22EqoPLu1fJh8AtexILwFz+v+XzgvU9MzSszLhy9+w/7gnAMXnXSTqeQtga/G7hBD6Aoh iXgSwqmWGea5cqnrJ/Q== X-Proofpoint-ORIG-GUID: SD3REkOapkauqyfyXyZ9XoTn20ugIQLT X-Authority-Analysis: v=2.4 cv=DrpmPm/+ c=1 sm=1 tr=0 ts=69ddfd2b cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=lehnMraD3ed_Nmqd2dEA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140079 On 4/13/26 2:22 PM, Ajay Kumar Nandam wrote: > The LPI GPIO register access helpers previously returned the value from > ioread32(), even though their return type was int. This mixes data > return with status and is inconsistent with common kernel helper > conventions. > > Rework lpi_gpio_read() and lpi_gpio_write() to return an int status and > use output parameters to pass register values. Update all callers to > match the new helper interface. lpi_gpio_read/write() can never fail, let's just make _read() return a u32 and _write() a void Konrad