From: Guenter Roeck <linux@roeck-us.net>
To: JuenKit_Yip@hotmail.com, jdelvare@suse.com,
krzysztof.kozlowki+dt@linaro.org, conor+dt@kernel.org,
broonie@kernel.org, vincent@vtremblay.dev, michal.simek@amd.com,
geert+renesas@glider.be
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: <hwmon>: add sht3x devicetree binding
Date: Sat, 24 Jun 2023 09:36:34 -0700 [thread overview]
Message-ID: <c7422c2d-1a78-32a0-86a9-225d5880cbc2@roeck-us.net> (raw)
In-Reply-To: <DB4PR10MB626179DE1C511B10ECA74D209220A@DB4PR10MB6261.EURPRD10.PROD.OUTLOOK.COM>
On 6/24/23 09:01, JuenKit_Yip@hotmail.com wrote:
> From: JuenKit Yip <JuenKit_Yip@hotmail.com>
>
> add sht3x devicetree binding files
>
> Signed-off-by: JuenKit Yip <JuenKit_Yip@hotmail.com>
> ---
> .../devicetree/bindings/hwmon/sht3x.yaml | 31 +++++++++++++++++++
This isn't needed if the compatibles are added to trivial-devices.yaml
(and it really only makes sense if there are additional properties
besides compatible).
Guenter
> .../devicetree/bindings/trivial-devices.yaml | 4 +++
> 2 files changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/sht3x.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/sht3x.yaml b/Documentation/devicetree/bindings/hwmon/sht3x.yaml
> new file mode 100644
> index 000000000000..8ff0b8d41f91
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sht3x.yaml
> @@ -0,0 +1,31 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +% YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht3x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SHT3x-DIS humidity and temperature sensor
> +
> +maintainers:
> + - JuenKit Yip <JuenKit_Yip@hotmail.com>
> +
> +properties:
> + compatible:
> + enum:
> + - sensirion,sht3x
> + - sensirion,sts3x
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +addtionalProperties: false
> +
> +examples:
> + - |
> + sensor@4a {
> + compatible = "sensirion,sht3x";
> + reg = <0x4a>;
> + };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index ba2bfb547909..b2369d1fad68 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -331,6 +331,10 @@ properties:
> - sensirion,sgp30
> # Sensirion gas sensor with I2C interface
> - sensirion,sgp40
> + # Sensirion SHT3x-DIS humidity and temperature sensor
> + - sensirion,sht3x
> + # Sensirion STS3x humidity sensor
> + - sensirion,sts3x
> # Sensirion temperature & humidity sensor with I2C interface
> - sensirion,sht4x
> # Sensortek 3 axis accelerometer
next prev parent reply other threads:[~2023-06-24 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230624160148.218786-1-JuenKit_Yip@hotmail.com>
2023-06-24 16:01 ` [PATCH 2/3] hwmon: (sht3x) add device-tree support JuenKit_Yip
2023-06-24 16:34 ` Guenter Roeck
2023-06-24 16:01 ` [PATCH 3/3] dt-bindings: <hwmon>: add sht3x devicetree binding JuenKit_Yip
2023-06-24 16:36 ` Guenter Roeck [this message]
2023-06-24 17:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7422c2d-1a78-32a0-86a9-225d5880cbc2@roeck-us.net \
--to=linux@roeck-us.net \
--cc=JuenKit_Yip@hotmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowki+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=vincent@vtremblay.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®