From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754518AbdDQPQo (ORCPT ); Mon, 17 Apr 2017 11:16:44 -0400 Received: from mout.web.de ([217.72.192.78]:57615 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754246AbdDQPQl (ORCPT ); Mon, 17 Apr 2017 11:16:41 -0400 Subject: [PATCH 06/25] net: mvpp2: Improve two size determinations in mvpp2_probe() From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Mon, 17 Apr 2017 17:16:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:2wyzm5xUY8XXOPKotkoHXLf53XN30jsrs1E0F4pGokyf0nylA/8 jLySIyMRhR8JnTBKqPSyZn+0TMH4AWjcGLEEN+LV5XPlHhOKWEA8uunpmn11cnSPAZlOw/o 04SODjEjZfaXO4gazWa+lNPW19BNUrvOAb55d/8/JfJbkXpCjSQdBNgfqGp+xWgBLGugNGi Ao+GLIT5aK7ecl6cZR2/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:b0ASNWXimhM=:9aO2TinIJY5KwNDoAP5wJf sYPvX+rISQTMbKpfthZbosfou/Uwg088CSjkVFByeAv3+Bpks9o1Co8KWOK4XYgPU5wSwImPq Rsk6Zc2dxL8yPJWAcx6yBwpyfbpMtqIGuN9RzIrJ3iLBbY35aj5P5HFYZayw4MRgmArE5chj3 pLc86QuLFJ4d45rYP3in7+69urPcoH4Z3lIvdaygscRfAeAF3NccKDRyNbiFu+LqUwb2Woxb8 wQdQ/HVLz19X8G9nfBpyw7MVEQNeq+HjYf+Mt7qi5iiSyC1uIcIxFhL63oKkfWo9F5kbu+jLZ vyrnziV86uEgiSwLISWRsCxKYOq+WYdcNlGYWy7X5sU/s5YMKI4zTavOUMzGxwY1qB826+COE W+iK74N2QdIgiReswCn9OOlTXaEVKCyLImyofiTEl2365o0g2Ehrj9WrDFitUQUAPH4BHUytJ 82q8XRqUTjRYIrcjIZdIS1sWqgWndqNIUgEideJjUmS9qKqzmqvY23q2S5kOjoQ5zSrPQCWAR QgIm6DenhoZjrm9KMdSPtGjavBR+KgC3BIbP/gP0J/dQB+gaKPM5zqdqzeDMBdEWs5ifQqj8O L2JNgiyRy9nB4pFv57aRCElCTS966Rv2+g0IZQ287L0R5wKVuB+kArXxcAdsJQdtgH5NM7+EA jpLoqvVK+5uCZeSOkuMjXezpbAPtxjPL0Kb+S/kZe/Hcb4Ka/JO3/9394CXuBPPvQRMpwI+lX N9y4Cw5FRY4cLPIa+sTLtKCQOxP3kKcBtpHHGCLmTAVQ0/a7FDWXZ9JlET/cYqnNMKyvjM9L9 mfDWasT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 17 Apr 2017 08:38:32 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index a86d9111c476..04aba2307b60 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -6873,7 +6873,7 @@ static int mvpp2_probe(struct platform_device *pdev) int port_count, cpu; int err; - priv = devm_kzalloc(&pdev->dev, sizeof(struct mvpp2), GFP_KERNEL); + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; @@ -6970,8 +6970,8 @@ static int mvpp2_probe(struct platform_device *pdev) } priv->port_list = devm_kcalloc(&pdev->dev, port_count, - sizeof(struct mvpp2_port *), - GFP_KERNEL); + sizeof(*priv->port_list), + GFP_KERNEL); if (!priv->port_list) { err = -ENOMEM; goto err_mg_clk; -- 2.12.2