mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sagar Cheluvegowda <sagar.cheluvegowda@oss.qualcomm.com>
Subject: Re: [PATCH net-next v4] net: phy: aquantia: Poll global status register for provision ID
Date: Mon, 16 Nov 2026 14:33:36 +0100	[thread overview]
Message-ID: <c7467c7c-a8eb-4a23-a1a4-20d6ae6dc7d0@lunn.ch> (raw)
In-Reply-To: <20261116-aquantia-poll-global-status-register-v4-1-1b44fe85db5a@oss.qualcomm.com>

On Mon, Nov 16, 2026 at 07:14:50PM +0800, Hongmei Xu wrote:
> According to the AQR113 PHY databook, after firmware reset, a 20ms
> timer needs to be engaged to allow the supplies to settle prior to
> allowing the PHY to boot. The working flow is:
>   -After the 20 ms timer has completed, hardware state machines
>    designed to guarantee PLL and band-gap stability engage.
>   -After the PLLs and band-gap are locked and functioning properly,
>    the processor and digital circuitry are released from reset.
>   -The PHY image is then loaded through MDIO boot-load and the
>    processor boots.
>   -After the processor boots, any provisioned register values are
>    set, and the PHY enters the provisioned operating state.
> 
> Starting subsequent firmware operations before the provision ID is
> valid leads to steady link failures; this has been observed during
> AQR113 PHY bring-up.
> 
> Poll VEND1_GLOBAL_RSVD_STAT1 on AQR113/AQR113C until the provision
> ID field is non-zero before returning from aqr_wait_reset_complete().
> A timeout indicates a hardware-level provisioning failure that
> software cannot remediate; the warning is logged to flag the hardware
> problem, but probe is not failed since a timeout does not necessarily
> prevent link establishment.
> 
> Co-developed-by: Sagar Cheluvegowda <sagar.cheluvegowda@oss.qualcomm.com>
> Signed-off-by: Sagar Cheluvegowda <sagar.cheluvegowda@oss.qualcomm.com>
> Signed-off-by: Hongmei Xu <hongmei.xu@oss.qualcomm.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

      reply	other threads:[~2026-11-16 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 11:14 Hongmei Xu
2026-11-16 13:33 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7467c7c-a8eb-4a23-a1a4-20d6ae6dc7d0@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=hongmei.xu@oss.qualcomm.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sagar.cheluvegowda@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®