From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7EF39280C for ; Wed, 25 Feb 2026 14:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772030295; cv=none; b=fGYzCQl88Kj+vfA3qwH9jiNPZZN85rJnjq0Y71Gp2/mQH26uYB/VRa/ibSeQQyKuFBXKkNOcGsYMuXb6NyRL44d6EJKjO3QX5BSd5QfZBazqqeRHLMZ7h0m3vhcgspZn4a/etBm+JufbMlILoAoD8xzW0uNs9AV9i6KdqnotN4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772030295; c=relaxed/simple; bh=digNdhj5ymvK93iQkbJJBvbVfxcIm31TqcqnBr+Bogw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eZ5WixjygXo5hX7Yh2eQ9ZpZAXmdZ8GJF4Q24CJEMF5AjIfrN50oJhT7yiPLEuVZHaeAvEKQ5Jkx95hCMc0t6jZnBUjxWGGadQlxYZ7CR74RyjFzQ9DEJJn5CFFG6QSPKSUkhulQCfy8NFVLKVRIvzCWALZPzj7oJCORjsNnA7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XjNagOxF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=is/INAKc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XjNagOxF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="is/INAKc" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61P9RuYR3056460 for ; Wed, 25 Feb 2026 14:38:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ICZwg1StmPCHqHGLiPJjTvu8ue8fmrDu8Hu6winZYZg=; b=XjNagOxFxIzW/NW6 AWWksZKNcBl1H9VOudepKSFFYINVSKZxHJAWlBgyPYFh17CC/UhndiRDummVi8s1 PGUz3uvWU+gllG0vyCJsmlLFkfEKFM9bNb6wEXvsp272Gzaem+ZSGhxcFVsr2TC0 0JgShWdFhP6/3FfMXkno34eN/4ucLmKeEa9RK66uJROJ2ykbWlBL3ZLtYRkWOCxv oSB5YNhMo781na4aErDPzxtSWr3KWaO/GaIdwgpKNacDwjG6Z4JB6p77wPyxUlCZ R/Fx9T9fXpLjggG+/5FQXEMZ52rmsDD0MxfM7V88FReyVIceGsiAGzhMXJpL04os BIzA+w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chx39gxyr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 14:38:12 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8954ab64c65so72471216d6.3 for ; Wed, 25 Feb 2026 06:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772030292; x=1772635092; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ICZwg1StmPCHqHGLiPJjTvu8ue8fmrDu8Hu6winZYZg=; b=is/INAKcgtxdGdaJEK3c7TOUpx2wLSGARiDkHlxSvQjQIm6lXHFVR5C/USa7Zo00Ap gkba/4WboH1o5bl4S4NcelchfalGuid06P7FSbVOKPtp1e2D/8QI0Ay90aLGLZzyzgL0 AmyMjoe8NFEPDms+21mdGF/GWGHK7OTjqGaibuqoJrWHE9beCfJ6pzAQranlTQuX9a7H vZhNVBU+VEXDsadBPkPEfxI0q9d1u/8gkGQmpLrCnAgEvNLW7Me2nBTBTdO07txqgGIh 9YtOCX9Mx+NHZk2CGDdO0oq1tA7udM3EKwAcHUfRlP81lU8PP++81gKqtMSFOKZRbBwp x83A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772030292; x=1772635092; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ICZwg1StmPCHqHGLiPJjTvu8ue8fmrDu8Hu6winZYZg=; b=N4AmgCTI3XNGxPwkeR6iYWQX7NKPSK3SgrSvvyox4voyZ6wnEeKgT6y8iVo4S1p0eY aUx9QgaBpFZJ+YMvb8Ym+sIHTNIQD0eXEmWLDwhKh4X+zPwAM57t+i5tQmQL/WJYXlr/ cCbi75KrSaQTYBDaLXZmHPSR3XXJDFILiDpkgLi4YGFAUOzVFzbPoefwx9WZAN0siFNS GR3FGpdzO2WYD28kGGiKKTrP91F+b6ppAQ0tySFZuwq+4kNYxBelXX27GwsrK7xUxv+f r/WtgYlqz70/YYcH4Hqzf9KVemOcHqOn0H/GAw502kJftwO/jA+/zzat0Zh3GzSW8QxM k6ZA== X-Forwarded-Encrypted: i=1; AJvYcCUXQlDb8odaEdnfwypIfadjvFxVYJBbL3P6+81psLUPazUeAtZ1u+XUeLtYvdoKRh+VFZbTFBMRJrK1mXU=@vger.kernel.org X-Gm-Message-State: AOJu0YxmM9Ua4N9VXFuYrjrNEPvyKoZ4TPknmEJ7xzGCt4uFvwLTk3tN GmyypyJGH5gePBqZ3iQKXIkoIn70CHnmJBeUJmiXceLdNceThlKMCdzvt8qiqwb6YBywd88DXZX NMXvzvjcpwlybEr05M6795bNdiDrSAyRV8viMCsZvhYvoQT3yCkKUpYT5HMvNr99DFbw= X-Gm-Gg: ATEYQzzkvywUw5we+YdYk7R25IcB42p5qLfoPMTcD8FGFqnlDQcry3LCBH1ryNrKyEh 8rAURb/CwX7vE2UHwwJFhrImDcoHy1LIgEZHO+ZOWOvF8DrcEKrqCI0faafvuMesHmR+vPzVOaL 6ZtZVbaizvU1RfLapVOe0+XsSyeMSFETYHUlHIAm/LZZyRR8NYAH8njQ1KM5p+OM/WVEBRpHbgi xzsxTOWhtpeIrKpZ8oxzq4PB4U3tTMKhoLyURmvjEbyCsA6YRl6SP4dvGHGWQdLNgfi7x6X9dOG As6+mEqyBb0L/aXmHbPbkcL1DW7XUQWfEPvQMcmzzNcDeRP0H4znVw0GgL1aCbZurz8UlmaLe1q SPCfbFmdkXHxQWGi7ckk+JUKrVQCCYOn4+wQTp82leqtSy7yhKKoGEPebD93D6WcO2la4r83OUY FQXGM= X-Received: by 2002:a05:620a:4154:b0:8c7:1b40:d096 with SMTP id af79cd13be357-8cb8ca8a757mr1520292185a.9.1772030291524; Wed, 25 Feb 2026 06:38:11 -0800 (PST) X-Received: by 2002:a05:620a:4154:b0:8c7:1b40:d096 with SMTP id af79cd13be357-8cb8ca8a757mr1520287485a.9.1772030290963; Wed, 25 Feb 2026 06:38:10 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9084eb912dsm536073366b.55.2026.02.25.06.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 06:38:10 -0800 (PST) Message-ID: Date: Wed, 25 Feb 2026 15:38:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/13] soc: qcom: geni-se: Add resources activation/deactivation helpers To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> <20260206174112.4149893-6-praveen.talari@oss.qualcomm.com> <05340972-2013-45b6-801c-7e52fe48cef0@oss.qualcomm.com> <9b49a776-a65b-4210-b335-627a296049a3@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <9b49a776-a65b-4210-b335-627a296049a3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDEzOSBTYWx0ZWRfX7ZBaLc8nEYpe vebaHxR8A3nbpaSdXfnF64QJ0nJD0zCY8ijqKeGR/GiFPozU1AEv3rxCuTt3c8yzr/8G9rrQ+hj xXdXetHFAwYNaZHVOHuQIHeku/zuRo1wWmCuK0pMLJxArLTPr4IYfiX2PP4cBab/UvylPqP2set tCacJlKrW7si52FJDZLUnKrZOYuZqU4wm1IwOFZuPBRfJSRstqvMT7LqbjxlTVj4xIqtGdQeoY1 95GJcvGzBrjPlnHOJU55tpsrbyBjxtawmvc7NzuQNZzkC9BomkUPqPNmprL+kaQVG5S/aa8US3v /67Ne2uW2PHTYGGkhhdCODbmAQc6JkWRzjk8HCZPk37UJiBDkeraGDr/YQftrXhVLx3SbpayYX1 0d0fma/i3g01rMlyP2/Oi5ku3//c47rvij2lD8tlhZt6xs9PVW9odFqw3Wd3/XVIVnreTa1SvLx F0wxrPtKfp5MjIL17mA== X-Authority-Analysis: v=2.4 cv=FvoIPmrq c=1 sm=1 tr=0 ts=699f0954 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=pvrQjcnNlfa1hpXBJfkA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: muepiOPBa5AlLsx-WX7pQjfdx90YtXmP X-Proofpoint-ORIG-GUID: muepiOPBa5AlLsx-WX7pQjfdx90YtXmP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250139 On 2/23/26 2:39 PM, Praveen Talari wrote: > Hi Konrad, > > On 2/17/2026 5:32 PM, Konrad Dybcio wrote: >> On 2/6/26 6:41 PM, Praveen Talari wrote: >>> The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource >>> activation/deactivation sequences independently, leading to code >>> duplication. >>> >>> Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to >>> power on/off resources.The activate function enables ICC, clocks, and TLMM >>> whereas the deactivate function disables resources in reverse order >>> including OPP rate reset, clocks, ICC and TLMM. >>> >>> Signed-off-by: Praveen Talari >>> --- >>> v4 -> v5 >>> Konrad >>> - updated return value as 0 for geni_se_resources_activate(). >> >> I would really like you to include that kerneldoc bit I mentioned it >> >> https://lore.kernel.org/linux-arm-msm/ff9a2aa3-1b2b-4001-82ce-198c61a4b637@oss.qualcomm.com/ > > I hope the below works for you. Tracking the rate internally with drivers potentially doing more work to change it introduces more room for error. I'm fine with the current state of this patch, so long as you > +/** > + * geni_se_resources_activate() - Activate GENI SE device resources > + * @se: Pointer to the geni_se structure > + * > + * Activates device resources for operation: enables interconnect, prepares clocks, > + * and sets pin control to default state. Includes error cleanup. Skips ACPI devices. use this kerneldoc and include a paragraph saying: "Unlike geni_se_resources_deactivate(), this function doesn't alter the connected genpds' performance states, which must be additionally handled." We may find a better solution to this down the road, perhaps including a factoring-out of the clock configuration writes in the non-scmi case (they seem largely similar), but that's an improvement that doesn't have to block this series Konrad