Re: [PATCH 2/2] arm64: dts: qcom: qcs615: Enable camss for qcs615-adp-air

[Wenmeng Liu <quic_wenmliu@quicinc.com>]

On 2025/5/21 21:07, Bryan O'Donoghue wrote:
> On 20/05/2025 09:56, Wenmeng Liu wrote:
>> This change enables camera driver for QCS615 ADP AIR board.
>>
>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/ 
>> boot/dts/qcom/qcs615-ride.dts
>> index 
>> 2b5aa3c66867676bda59ff82b902b6e4974126f8..be8b829ec508d7de7a4cd6be6d1d4e83b09734bb 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -211,6 +211,13 @@ vreg_l17a: ldo17 {
>>       };
>>   };
>> +&camss {
>> +    vdda-phy-supply = <&vreg_l5a>;
>> +    vdda-pll-supply = <&vreg_l12a>;
>> +
>> +    status = "ok";
>> +};
>> +
>>   &gcc {
>>       clocks = <&rpmhcc RPMH_CXO_CLK>,
>>            <&rpmhcc RPMH_CXO_CLK_A>,
>>
> 
> I think there's some confusion.
> 
> I'm willing to accept CSID and VFE changes with the minimum proof of TPG 
> driving it.
> 
> But - CSIPHY in CAMSS which is only proven by TPG is obviously not a 
> proof and again I agree with the consensus here - there's little value 
> to an end-user in just having the TPG for a camera.
> 
> No sensor:
> CAMSS::CSID
> CAMSS::VFE
> 
> Just about acceptable
> 
> No sensor:
> CAMSS::CSIPHY
> DTS::CAMSS enable
> 
> Is too much of an ask.
> 
> Just publish your sensor code ! We need more sensor enablement upstream 
> anyway.
> 
> ---
> bod


Hi bryan,

I will upload the sensor code together in the next version.

Thanks,
Wenmeng