From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCDDAC32772 for ; Tue, 23 Aug 2022 17:21:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbiHWRUX (ORCPT ); Tue, 23 Aug 2022 13:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231295AbiHWRTw (ORCPT ); Tue, 23 Aug 2022 13:19:52 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A790AE852 for ; Tue, 23 Aug 2022 06:43:17 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id m3so14060002lfg.10 for ; Tue, 23 Aug 2022 06:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=h32xyk5qVyHWCWQbdLOYmYDB3SfGv1Ihtw0UlxutFSs=; b=j7WUm0iTG96tPDzGkHP6hVuPCpr84UKH3TJFLWMgVEmePKBlnIJ84/ybGASHI/Mra0 RWoBVYr8ozv7fj7kVw9sz/+jeSaeJmZhqxjpClB6Y4Pc+TyxU6fwxL69LB6ZsgZVRpt4 +67/Na/EvQDPdnAMEKtFkqfBZswAXsGGgVkMUrh3xQhkqgayWbeoGv4EiDoKTDvt+g8m 7hnjfSGwI1hsTBEgbKg1rbjlb+j9eohQ8kbCn3L4Yx3sUt5sRi6aT75MLtTIBbihnk1+ mBcHTr2H03kYnjC9aBF8s/sJoqSZF4kD1p4pgs+Euu2pRgwNJ8d/HJ5bsCMgn8mWlLbR +QmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=h32xyk5qVyHWCWQbdLOYmYDB3SfGv1Ihtw0UlxutFSs=; b=zKQqtVSzkENgcIcG8gj+jSC/TKIzNrQQyLMfSetTX3Cq7ozUtT62fS4TvevHV53xRU GAMMuiH1bEho7pr0PxLqotVQhgA2CMi1x/uf44VssKrwOlgRkXB4FkOt0xN4GYUXNJOM ojMIcjSKnlem1ski8yNEfpSlroGEA+cBatvgq73pSbAKF5TRtqNVLr/pWlUysbaQFMx2 nwwnbbBdiPiRYV4SpRnlCVXzo1IcvtbzhdGJsOotn2zPgdw4OVPNWug9eY9i3UEVUYWe DzEjPeSDUvAOlL7jbWvCe7m9ciBrEspWHy8PFtjd7bebrt2a4mKMhTEWZZL06ZYJMOeP E1Ng== X-Gm-Message-State: ACgBeo2X6Me7kSjmO5QoMZP+qSxAPX6JSq9mnrZXOtAqljuFa7Tu2u9I Tht5DOtCrK42YLZ7H5OxxhnNVg== X-Google-Smtp-Source: AA6agR5RZdIPZVcwdu1iI8zwdbElK6Q10jk3CELdg44yE6uN2YcKJda0sTTtvNcx5OKPyyPxtJP3ow== X-Received: by 2002:ac2:5097:0:b0:493:109:f190 with SMTP id f23-20020ac25097000000b004930109f190mr355159lfm.180.1661262195492; Tue, 23 Aug 2022 06:43:15 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id f1-20020a056512360100b00493014c3d7csm107114lfs.309.2022.08.23.06.43.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 06:43:14 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 16:43:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4 Content-Language: en-US To: Dario Binacchi , linux-kernel@vger.kernel.org Cc: Alexandre Torgue , Amarula patchwork , Marc Kleine-Budde , michael@amarulasolutions.com, Dario Binacchi , Krzysztof Kozlowski , Maxime Coquelin , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com References: <20220820082936.686924-1-dario.binacchi@amarulasolutions.com> <20220820082936.686924-4-dario.binacchi@amarulasolutions.com> From: Krzysztof Kozlowski In-Reply-To: <20220820082936.686924-4-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/08/2022 11:29, Dario Binacchi wrote: > Add pin configurations for using CAN controller on stm32f469-disco > board. They are located on the Arduino compatible connector CN5 (CAN1) > and on the extension connector CN12 (CAN2). > > Signed-off-by: Dario Binacchi > Signed-off-by: Dario Binacchi Do not ignore review. This is not correct. You are mixing copyright with SoC... > > + can2_pins_b: can2-1 { > + pins1 { > + pinmux = ; /* CAN2_TX */ > + }; > + pins2 { > + pinmux = ; /* CAN2_RX */ > + bias-pull-up; > + }; > + }; > + Don't ignore review. That's second one, so that's a no.. :( Best regards, Krzysztof