From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755196AbdEKHo6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 11 May 2017 03:44:58 -0400
Received: from mail-wr0-f196.google.com ([209.85.128.196]:36486 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754863AbdEKHoz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 11 May 2017 03:44:55 -0400
Subject: Re: [PATCH] KVM: x86: Fix load damaged SSEx MXCSR register
To: Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
References: <1494411564-76243-1-git-send-email-wanpeng.li@hotmail.com>
 <6d515b93-e7e2-fbae-a91c-12b98fe923de@redhat.com>
 <CANRm+Cz28VrLXvzhwhUmFZLPLsjv0ZrEdJ4nHT0RMg1cjAmdLw@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <c74fe092-bbe2-d6d8-5366-2404c091fd72@redhat.com>
Date: Thu, 11 May 2017 09:44:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.0
MIME-Version: 1.0
In-Reply-To: <CANRm+Cz28VrLXvzhwhUmFZLPLsjv0ZrEdJ4nHT0RMg1cjAmdLw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 11/05/2017 02:56, Wanpeng Li wrote:
>> Hmm, thinking more about it, maybe use mxcsr_feature_mask instead of
>> digging into vcpu->arch.guest_fpu?  If you send v2, please remember to
> ERROR: "mxcsr_feature_mask" [arch/x86/kvm/kvm.ko] undefined. So we
> should dig into vcpu->arch.guest_fpu.

Yes, you need to export it.

Paolo