mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Abhishek Thomas Varghese <tessolveupstream@gmail.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: talos: Add RPi Touch Display 2 5-inch overlay
Date: Mon, 31 Aug 2026 09:30:44 +0200	[thread overview]
Message-ID: <c751ed46-03ee-49c1-ac73-06bf32963b0d@oss.qualcomm.com> (raw)
In-Reply-To: <20260827-talos-rpi-touch-display-v1-1-911705fe6d6d@gmail.com>

On 8/27/26 10:58 AM, Abhishek Thomas Varghese wrote:
> Add a DT overlay to connect the Raspberry Pi Touch Display 2 5-inch
> panel to DSI0 on the Qualcomm IQ615/QCS615 EVK.
> 
> The overlay describes the display controller, panel, touch
> controller, power supplies, and backlight. Disable the ADV7511
> bridge to avoid a conflicting device on DSI virtual channel 0.
> 
> Display output, touch input, backlight control, and concurrent
> DisplayPort operation have been tested.
> 
> Signed-off-by: Abhishek Thomas Varghese <tessolveupstream@gmail.com>
> ---
> This single-patch series adds support for the Raspberry Pi Touch
> Display 2 5-inch panel on the Qualcomm IQ615/QCS615 Talos EVK.
> 
> The overlay describes the ILI9881C-based panel, Goodix GT911
> touchscreen, display controller, power supplies, and backlight.
> It also disables the ADV7511 bridge to avoid a conflicting device
> on DSI virtual channel 0.

Copy-pasting the commit message yet again doesn't add value to the
email

[...]

> +&i2c1 {
> +	clock-frequency = <400000>;
> +	status = "okay";

Let's uniformly keep an \n before 'status', file-wide> +
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	hdmi_bridge: bridge@3d {
> +		reg = <0x3d>;
> +		status = "disabled";
> +	};

And let's not define new nodes with hopes that it will resolve to an existing
one. Let's just do:

&hdmi_bridge {
	status = "disabled";
};

Konrad

      reply	other threads:[~2026-08-31  7:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27  8:58 Abhishek Thomas Varghese
2026-08-31  7:30 ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c751ed46-03ee-49c1-ac73-06bf32963b0d@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tessolveupstream@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®