From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4208C001E0 for ; Mon, 31 Jul 2023 15:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231952AbjGaPjZ (ORCPT ); Mon, 31 Jul 2023 11:39:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbjGaPjX (ORCPT ); Mon, 31 Jul 2023 11:39:23 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60E97D8; Mon, 31 Jul 2023 08:39:21 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 991E85C0115; Mon, 31 Jul 2023 11:39:20 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 31 Jul 2023 11:39:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690817960; x=1690904360; bh=3sigVTCHFGVp6funFXn9uMuJRWZKuRcAdPw XsFRL79U=; b=euvsBWRLUcgYzXOv1gUR1dh6GsWM/6vgxNlLxFaWlFVPxBRK+Y5 vh2ASC2d2M/80LiY9f/xB9tqCii5mb6xmIGqOlzvlZCyyS8uJImpF5z909mG2RvD 4Yb+5faz+AGFAn05IIwkGQD7+pVTbO2z23gqA/MTSyFWSVZdKi+9YJRf4LS9aKIu Xpvw8IbIZpVOOGCQH5P3/53IQc8VH5CtCe9mpcAhvRejuVevHS0VArXpmQPNuSeh f7gjGEncdVNwVhUpoFueY3kBYVbknAaCyfbhtTV7AC8+EZ9s7Brhxj87YG/b3SoC yI/aNBgtMLYUk4azI6ida25VQTdv6523X+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690817960; x=1690904360; bh=3sigVTCHFGVp6funFXn9uMuJRWZKuRcAdPw XsFRL79U=; b=HyWGJiXZ+MNH2y46FO1+cigNi91kIU4365wFjuNjNMtMGeumAf1 K5gjGXK6lndpZUxYot6IDZ7jH/k8dvYOHqCTqddLCImU0CPjNdShIOnGfVXgYuWE mR0HQiceO2GsvtfsGm1QS7ah7G8hsVL7NerNtH7ayETLiic3ADu7voN97pzk1Y0c phGWV+tPcrLVc5xnRspm7x3L+feofd19kq9lorOdzfWPjyM8V1fCH3rclBMq7TRq bEyojzgHEeDYtpDjReh1Eq4HJLnUOHJTgxTzrDpDbXdnpZ/Xt8w6xqP12zhlViU7 A4+Vsd7mM9G3PsXmUtlKOwTpZVby9pY2PlA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeeggdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudektdfg jeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0CAB4B60089; Mon, 31 Jul 2023 11:39:20 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b Mime-Version: 1.0 Message-Id: In-Reply-To: <7C51AA15-DEBE-486B-9788-F84B260F8880@gmail.com> References: <20230731110239.107086-1-clamor95@gmail.com> <20230731110239.107086-3-clamor95@gmail.com> <7C51AA15-DEBE-486B-9788-F84B260F8880@gmail.com> Date: Mon, 31 Jul 2023 17:38:59 +0200 From: "Arnd Bergmann" To: "Svyatoslav Ryhel" , "Jonathan Cameron" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Greg Kroah-Hartman" , "Samu Onkalo" Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] misc: adps990x: convert to OF Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 31, 2023, at 16:58, Svyatoslav Ryhel wrote: > 31 =D0=BB=D0=B8=D0=BF=D0=BD=D1=8F 2023 =D1=80. 16:18:16 GMT+03:00, Arn= d Bergmann =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=B2(-=D0= =BB=D0=B0): >>On Mon, Jul 31, 2023, at 13:02, Svyatoslav Ryhel wrote: >>> Add ability to use device tree bindings keeping existing setup. >> >>I see that there are no more in-tree users of the old >>apds990x_platform_data, so I think it would be best to completely >>remove that codepath and merge that structure into struct >>apds990x_chip, to simplify the probing and avoid the extra >>allocation. > > Thank you very much for your review, but is it mandatory to drop pdata=20 > in this particular patch set? To be honest this driver needs serious=20 > upgrades and refactoring, and I have no dedication to invest my time=20 > into refactoring it, moreover, I am not a maintainer of this driver,=20 > nor a full time kernel maintainer of any kind. I am doing what I am=20 > doing only because one of my devices uses this als but it is not=20 > something crucial. We have a lot of drivers that are lacking the cleanup I'm asking for, so I don't think I'd mandate it at this point, but I don't actually expect the patch to be any more complicated in the end, so just try it out. I think at the minimum, please remove the include/platform_data header and move the contents into the driver itself, I'd be fine with that. If you can easily do further cleanup by dropping the separate allocation and folding the apds990x_fw_probe() function back into apds990x_probe(), please do that, just stop at the point where you feel it gets too complicated. Arnd