From: Guenter Roeck <linux@roeck-us.net>
To: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: dober@lenovo.com, wim@linux-watchdog.org,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo SE30 platform
Date: Fri, 31 Jan 2025 07:44:36 -0800 [thread overview]
Message-ID: <c7571180-c643-42e9-b2b8-4da07c9394c1@roeck-us.net> (raw)
In-Reply-To: <20250116182912.1844-1-mpearson-lenovo@squebb.ca>
On 1/16/25 10:29, Mark Pearson wrote:
> Watchdog driver implementation for Lenovo SE30 platform.
>
> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
...
> --- /dev/null
> +++ b/drivers/watchdog/lenovo_se30_wdt.c
...
> +
> +static int lenovo_se30_wdt_set_timeout(struct watchdog_device *wdog,
> + unsigned int timeout)
> +{
> + wdog->timeout = timeout;
> + return 0;
> +}
> +
This function, as implemented, is unnecessary. See watchdog_set_timeout()
in drivers/watchdog/watchdog_dev.c.
Guenter
next prev parent reply other threads:[~2025-01-31 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 18:29 Mark Pearson
2025-01-31 15:04 ` Mark Pearson
2025-01-31 15:44 ` Guenter Roeck [this message]
2025-01-31 16:17 ` Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7571180-c643-42e9-b2b8-4da07c9394c1@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dober@lenovo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®