From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035B7392C32 for ; Wed, 3 Jun 2026 09:26:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780478776; cv=none; b=OjW0MdJ8m0GVMg4yCJtFUp776+TFdiZyJpvO3BERI8O5C8r9tSEjNvwBA7EencbzMlExXp1hFBu+y2XVKuB9SRXtg+VhsV0YdG7zf3lDTUd4xClKv7bePgSCM1zdMRLlWzIxqYmrFUuN6qNpA2nz9az2qFgs+rLFzuqPciOexgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780478776; c=relaxed/simple; bh=IRixWQMwizXFdhkvvgBqMpo7g1d2nL7BH7+e0C+a08c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T3YOl/Xb/9FDUkWsDKLENbhJHLN3fFNztShsljU5TU5bbVyIApyF7GyYKBbWWLnos2hHCIgjhMdOpRamMmmQ6zEruThWKTUbeHc8hREp+4F1XIQTJc70Pe2uSsZUjkGoGKoeZ0Js0S7TSjSxG0cQrmd126L+MMKS73YR2nJDZZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lTFed7pm; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lTFed7pm" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490b12270b3so12203175e9.1 for ; Wed, 03 Jun 2026 02:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780478773; x=1781083573; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LVv22gZyTmtymIxhoGte2pKFNDZ9dT7qVuNtoXNbMUA=; b=lTFed7pmMZ9uNCoZyARWr5g75M74ezYc785BMdLbnW3+GprgZFXL2z7BiQMkkClVQy kE0iWjhW/CCeFhJORITaU0rp7nqJo0uF1x1xyeg8komFjBHumA6y+wjMuuktiw0u2dHt hjotIolEewzWLC1X+8uvAK4/jrwTQNrqL6SHEIACpfNQwJCKKTcp8hW4gxN2HcbGWzuL gCs35UAASBnHOSmjRoJ9uWtApnrrnUpTc4kpGKnghjOSml/WecpQWqkTSbV8BpyA780j jOQuE2YvFApmYQJl7O1Gk5sfcvkcx/a/kBC9Qm1cdkAiPYIMzVqCWlRX2g+ee/kS+G8i SQmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780478773; x=1781083573; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LVv22gZyTmtymIxhoGte2pKFNDZ9dT7qVuNtoXNbMUA=; b=n9mTuear+2r49Fjb4h9SIJkwMeZQLIkPDhwoM/69fRwdJGw2Xq/SD+vW2glCP8T9V7 4HysE/L6bV0s5U1c5lObZWSeyf95mMDOIuOISKPKA3gI4hrS/wpildrxuro+kBU47UCv dvOzXWSI40zGWoksu45g1r4AYnpkLm8hy5ElQqPkjyKu3xZIJWDpePEQsCma63xrClny JJvW+V6onYnv/1bzgNP45nkXNyYVKAVXVBoZkfEPCCFBc946fkV8IaUzLYMJXWzljGHT JU0YTmdMbAEjoa23yHZtO4T4vEn7pOAtf9f5TEaDEEEtUnRC30GJb2xJppHrQczV7+UE QdjA== X-Forwarded-Encrypted: i=1; AFNElJ/m3pk1TqWtn0Ft/TuehaTjhznjCcOCt8Q5sC0LV+fo2q/bWOWKXQ9csy1kv1dOP/war7QiAQcDKEnwgbk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0tTd+fyC5OYo/adesY5cWzw9E+C+dAJPLn/+zq5oF9a5zkbXn ZaE2MLIDfANXDlEvfX8lpYKnHYKEc30e8e0REnnVNNwK/F76Kcbdv886DAEz0G2mtoY= X-Gm-Gg: Acq92OFSxxxMnXSa+60luSH3lxfS0SPHjN1abAzNSb8Ois1vN1QSKvFiodO3yjkkDIl fdNttPCJOtqhW/fmzBigbRjfxth9txwU28mBYO6yMfdI95vzgJM/KdCd5Kzu3CYkTZobOMAvlnU Y3W4hJHDndz2WXnk49eXuk6xpSczkMUAanN5EA1VAvi8OselR+wN8CsTDDP+WhepRqPDSIM7dSF mZw8l18rPnL7YNCEtQbj/LX0BPzEJL+jxZ1hLZNb5HIlka7LfKyIKj9sNS9Xv2efomVJTSSFD2K o1n0qYNHhwfWGF/55hCtzyWP67pJTRjaScBT8kS1GxRObG/yoqbyJKd3/+yl7okIuXSysi/jbMl RNOquNZqezS1e1fZ6YnqZyS7WOm9dGv5XSstT3s4nTSGuDHU3UuGtbtsIJCf8HXlvQHzo8rjSo7 sAm5ahC9QpSwIr/q9iLR8OZrV4cqwd6yXkNc5/qLMmDw== X-Received: by 2002:a05:600c:45d4:b0:490:5074:651e with SMTP id 5b1f17b1804b1-490b60ef350mr41726765e9.25.1780478773360; Wed, 03 Jun 2026 02:26:13 -0700 (PDT) Received: from [10.11.12.110] ([82.76.215.73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b79d64e8sm35451535e9.0.2026.06.03.02.26.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 02:26:12 -0700 (PDT) Message-ID: Date: Wed, 3 Jun 2026 12:26:08 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/5] thermal: samsung: Add Exynos ACPM TMU driver GS101 To: Alexey Klimov , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Kees Cook , "Gustavo A. R. Silva" , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Alim Akhtar Cc: jyescas@google.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski References: <20260602-acpm-tmu-v7-0-8047dd54b0e9@linaro.org> <20260602-acpm-tmu-v7-2-8047dd54b0e9@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/2/26 10:49 PM, Alexey Klimov wrote: > On Tue Jun 2, 2026 at 6:00 PM BST, Tudor Ambarus wrote: >> Add driver for the Thermal Management Unit (TMU) managed via the Alive >> Clock and Power Manager (ACPM), found on Samsung Exynos SoCs such as >> Google GS101 (and Exynos850, autov920, etc.). >> >> The TMU on utilizes a hybrid management model shared between the >> Application Processor (AP) and the ACPM firmware. The driver maintains >> direct memory-mapped access to the TMU interrupt pending registers to >> identify thermal events, while delegating functional tasks - such as >> sensor initialization, threshold configuration, and temperature >> acquisition - to the ACPM firmware via the ACPM IPC protocol. >> >> Signed-off-by: Tudor Ambarus >> Acked-by: Krzysztof Kozlowski >> --- >> drivers/thermal/samsung/Kconfig | 19 ++ >> drivers/thermal/samsung/Makefile | 2 + >> drivers/thermal/samsung/acpm-tmu.c | 618 +++++++++++++++++++++++++++++++++++++ >> 3 files changed, 639 insertions(+) >> >> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig >> index f4eff5a41a84..383ae3f56cbb 100644 >> --- a/drivers/thermal/samsung/Kconfig >> +++ b/drivers/thermal/samsung/Kconfig >> @@ -9,3 +9,22 @@ config EXYNOS_THERMAL >> the TMU, reports temperature and handles cooling action if defined. >> This driver uses the Exynos core thermal APIs and TMU configuration >> data from the supported SoCs. >> + >> +config EXYNOS_ACPM_THERMAL >> + tristate "Exynos ACPM thermal management unit driver" >> + depends on THERMAL_OF >> + depends on HAS_IOMEM >> + depends on EXYNOS_ACPM_PROTOCOL || (COMPILE_TEST && !EXYNOS_ACPM_PROTOCOL) I forgot to drop "|| (COMPILE_TEST && !EXYNOS_ACPM_PROTOCOL)", ACPM is NOT optional for this driver. I will comply this way with Arnd's solution from: https://lore.kernel.org/linux-samsung-soc/178006367096.55906.16678510397337205828.b4-ty@b4/T/#t >> + default ARCH_EXYNOS >> + help >> + Support for the Thermal Management Unit (TMU) on Samsung Exynos SoCs >> + (such as Google GS101 and Exynos850). > > This driver doesn't support Exynos850. There is no initialisation sequence > and etc, moreover the next section is also not entirely correct for Exynos850. > Not sure why it is mentioned here in such way. > (Not even mentioning that ACPM TMU part is not aligned for Exynos850) > Okay, I'll drop the reference to e850. Cheers, ta