From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=40.107.130.63 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1795004269; b=EQLf53yRCQ95Q6Ij4St1ODU2nHiO/5coaD4+y8PiwR4SjkjyrKZ5yT/QYnXzRi2BKjVx fJjyh553wEOyGGgjbd7aa07VFwajctFSq6KLkKRrCKxHRzpGNqE+xd5Nj89B7cbrP6st9 DwizY5uFb9FW19sOBm8a9fIZgkZIAYQUbOQEY1nenTltNiOf/hwGhTiQkX82to6h+DRgz kOEalYuONBH6TJgC43js6R7ryDrDJ1o4KOWYoZhlYHy6N8g7Ixu+DgtNPqOWoDMTkLs8k rMlmvMUZz1IaNpGXHX8svCBDQozUVRHl7UQ+lllz8bn5MD8NuVZgtV9cWyqtGf6yKjw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795004269; h=DMARC-Filter:DKIM-Signature:Received:Received: X-MS-Exchange-Authentication-Results:Received-SPF:Received:Received: Received:Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC: References:Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy: X-EOPAttributedMessage:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-Id: X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=lCbOLlp39It0oRF/JMEXeED1kazwdZBz59iHTid9KAs=; b=crfweGTNxUmTNBpI+jq/IIKN3Zw6hHDHRQkMEI3TFQsukCTtCkblluNA3MHcTX3aVryk 6d/Z2hchg6sy/LYC/FuwiO/4owlzTS29NhJr4+/je7TfA8HMQVphuuCaXmFkyiJmlWdPS t+UrfaAceOhsn7kkemO/j6upY/JsYYBK9mrDlgf6bPsyItgDCfdUeBwn62OZ+OOdlUSQa 3LUc72xxG4A8P2WBOzNagIc+I0tOnzSLwwRgQMCahW6iU73LoWfw5Amseg0MvVW3+4kBm /ycbhAE7D+FTg5Dh6KV4OOLW0Dxm5LzC3a9Bl30Fr/K9ihyVd98gz8Wwh3c7RfJjtAw== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256 header.s=selector2 header.b="VL+/Fb+R"; arc=pass header.oldest-pass=0 smtp.remote-ip=40.107.130.63 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011063.outbound.protection.outlook.com [40.107.130.63]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96799606A33E; Wed, 18 Nov 2026 12:17:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 96799606A33E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256 header.s=selector2 header.b=VL+/Fb+R ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NZ49HktXgIswRMBwghFLkpVGDbldijTsW1TAE/q1lUWm0x3fqXW5OmruYmSbuDHoXaiImqBqy1uHWqiEIPSUxx4cOhTWc++kIwEsMHXZfixvhOgH//9rB9WXhL7HOitDYHLGnpQyvbdqQCGrcDnOwZZ7g+vkTWAg/8OelxHNRNe06T4wLQBJaRqZZpRvKx3Od9A59iUOs6RiRY4fbDS96BRpq+v2MW3b65aG1i/DBkvnQY4Tc6/zXEEQtg+knHioriVuUpQ+oeoKje/MHYUIZvFNTVamyyKfTWgFOa1wynmaW/NEl9jh6RsUY+TMVY83R6LeOQNT117UjNwyovGcSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lCbOLlp39It0oRF/JMEXeED1kazwdZBz59iHTid9KAs=; b=vHJ04npvqBVLe2gRCnKb16iCB9wg7Rm/rtGHmMM0fIndGKDphmzSv3/TpUOX45qKGNhT1ZQUKDghhrB6bHJ6NWyk9nykrQtP5QMnAgvsnoLUycGwPBiA1KAus417TN+7mf46LkhVtcXcXP0+Bpac3KpN7hdTsDhf4XYAFyRDUSinbrbIxTr2x1W22zV/WwORA5fDoEpjlh1Cic2duomJ53kQv+3Y6+XgJ9bM1JjoMBjYFL++RQBl62zI++uUMwVZVz9N7nMM0Jz3eA431LXuCQefPbRyWoAoYOgAw/ldhzmnhBTY2Kbn09lD/evGrSY6tMCdY6lqt5+DptoacCuwDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lCbOLlp39It0oRF/JMEXeED1kazwdZBz59iHTid9KAs=; b=VL+/Fb+RToc54iTXitKYB6tqKJAfVQY1KtjePEW7zbpa/DPO98AhnG8WOOfugEKGDs503pb9bmOL+xXIUPnD0Ahnje9FU+StILTRlpnerQLvUrNvFfGdzCEuge8VH3PI7TDJAVmr7ak8o5uN1llKOWCbiuCRr9dpzzBwkjAa2tXZUJO3GHX9LakD67bIFL9F8YOFjXl23uJCAZLDpZP3aY8xjgmFgsMaKR56WdAP2JeMJG//EHZTiXum8EacVvq30Y39GQp0AKSBz24eYEKgHJSl3QqsSQSPiXsnRPcxBYkm3YaV6w6Zse7AVPrd7BbtbcEhelPMzY7X/05Z38pLTQ== Received: from AS4P251CA0015.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d2::17) by GV1PR10MB9015.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:1d1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.639.8; Wed, 18 Nov 2026 12:17:41 +0000 Received: from ZR1PEPF0000E464.eurprd04.prod.outlook.com (2603:10a6:20b:5d2:cafe::8) by AS4P251CA0015.outlook.office365.com (2603:10a6:20b:5d2::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.615.14 via Frontend Transport; Wed, 18 Nov 2026 12:17:41 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by ZR1PEPF0000E464.mail.protection.outlook.com (10.167.241.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.639.5 via Frontend Transport; Wed, 18 Nov 2026 12:17:40 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.56; Wed, 18 Nov 2026 13:18:41 +0100 Received: from [10.252.6.76] (10.252.6.76) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.46; Wed, 18 Nov 2026 13:17:38 +0100 Message-ID: Date: Wed, 18 Nov 2026 13:17:38 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: clock: Add STM32MP25 SYSCFG clock controller To: Krzysztof Kozlowski CC: Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Christophe Roullier , Dario Binacchi , , , , , References: <20261110-ups_mp25_clk_syscfg-v2-0-624559bb8ec7@foss.st.com> <20261110-ups_mp25_clk_syscfg-v2-1-624559bb8ec7@foss.st.com> <20261113-charming-admirable-pronghorn-bdc26c@quoll> Content-Language: en-US From: Gabriel FERNANDEZ In-Reply-To: <20261113-charming-admirable-pronghorn-bdc26c@quoll> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E464:EE_|GV1PR10MB9015:EE_ X-MS-Office365-Filtering-Correlation-Id: e0fc533b-59b8-4c86-39f6-08df456df0c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|82310400026|376014|7416014|1800799024|18002099003|22082099003|261009223027099003|3023799007|11063799006|56012099006|261026140227099003|10067099003|4143699003|261102123227099003|261028144727099003|261026121527099003|261021121427099003|261021135927099003|261022105027099003; X-Microsoft-Antispam-Message-Info: KH/w+UDF4g23V9bnEWsKI1QfbPxbT6MUIh0ec55rC7oIFRx/i66eFulOdt4amuspoISIwAIYbzyadwcAAAYg4MTUx+g1pWbZrfnywNJH4NIvv9dsl7/l7hI2MRF7PU/KFvrux1GsbEsgCVepgHPh1MX7iEdxuZ5zihhKG1K1OpvhvpnTFU/QojjLUj1wBAkUDv9AMbLDZnUV/FwxJ2DWDx3qHb+L11CFq+a9qUV+JT8RSThZNb/neu0CaUeTOSgMgZvdBcRZ/Xfn5wHy25Voqj7LDtGhTPPc8fUkiL9Ph3gskTg7xMJBnd0aVosbl30AnwAq4I5OuciGFZmWpEA84EFM6MJMB9kqk8lhCSAiOTi0Un0IFyYKFEWNyxTtdHUqcOOynS/ioJIFrlTpKXhefzeWGTJgyvKjkODySrW3WGYNhQZGOd9AMNRRsfhB87fB3/ysBKymgroZJlyykckEqGJQCMzJxMPnfdC6k5MkwynaiGixJ+gQcLlGHvQYINwgyIPaoOlyLW2LRpal++hkVR0mbbfoJ+1rJl2XgL7KVzllwvU/LD3BKZtlAxtKT9Gzm3x8/fwqIZgVtsbvLzWmYW3UPxzO63YDNI2Ofb1mX9H1652dom09kR876/O9fsg9/B4Y5gl8YhKHl6CtZjZNgA== X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(82310400026)(376014)(7416014)(1800799024)(18002099003)(22082099003)(261009223027099003)(3023799007)(11063799006)(56012099006)(261026140227099003)(10067099003)(4143699003)(261102123227099003)(261028144727099003)(261026121527099003)(261021121427099003)(261021135927099003)(261022105027099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7R2ew1OV35C/h6A6b4rvh3yNTXoPgK6FkIpiGwF22iTUXVFbK+QT6RUrzRVhzz0T5ouesZWXcAJ/2U4wp6WXMZJM/l8u3EklC7ZhuebgXcpLV9prx1owu1TGoBrORUTDrmE3CNiwwzMGFCvAV9pWdyq08GAxjglEc0oLBVgSIMoZtX/hu5BhqReXMNiF/iUy3gRh62M6QVEImbSVe578Q6soiRSoH6nIDP3pWf/tVOIWn1Yzd37TYWkT4tNXF0VBDLwRzVu5+8ze2mUD9KJJD7rQ0Oim1fyVchTu9fz018wa0OstmHw4W9MMV/yRMD71r3ymnHDX1arazU6YX5uF8uahkxzhxn6Pg2E0H1/rJizJQMxf7PrBFr4zctX8Y7bfFYbMO4qR9C6jbADkhSNKIc2J9eZb1Ak+2fbCQlkSBZkHnM5MnPYk5PtVlG9U7430 X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2026 12:17:40.3046 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0fc533b-59b8-4c86-39f6-08df456df0c9 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E464.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB9015 Hi Krzysztof, On 11/13/26 09:22, Krzysztof Kozlowski wrote: > On Tue, Nov 10, 2026 at 02:10:21PM +0100, Gabriel Fernandez wrote: >> The SYSCFG of the STM32MP23x and STM32MP25x SoCs selects the LTDC pixel >> clock among the LTDC kernel clock, the LVDS PHY pixel clock and the DSI >> PHY byte lane clock. >> >> Add the binding for this clock controller, described as a >> clock-controller sub-node of the SYSCFG node, along with the header >> defining the identifiers of the provided clocks. >> >> A sub-node is needed since the inputs of the mux can't be described by >> the "clocks" property of the SYSCFG node: the SYSCFG is a syscon, whose >> first clock is taken as the clock of its registers and enabled around >> each register access. >> >> The inputs are listed in the "ltdc", "lvds", "dsi" order so that the >> ones missing on a SoC (no LVDS nor DSI on STM32MP231/233 and >> STM32MP251/253) can be omitted at the end of the list. "#clock-cells" >> is 1 so that the other clocks of the SYSCFG can be added later without >> changing the binding. >> >> Signed-off-by: Gabriel Fernandez >> --- >> .../bindings/clock/st,stm32mp25-syscfg-clk.yaml | 61 ++++++++++++++++++++++ >> .../dt-bindings/clock/st,stm32mp25-syscfg-clk.h | 12 +++++ >> 2 files changed, 73 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml >> new file mode 100644 >> index 000000000000..027d14f28b0c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml >> @@ -0,0 +1,61 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/st,stm32mp25-syscfg-clk.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: STMicroelectronics STM32MP2 SYSCFG clock controller >> + >> +maintainers: >> + - Gabriel Fernandez >> + >> +description: | >> + The SYSCFG of the STM32MP23x and STM32MP25x SoCs provides clocks, described >> + by a clock controller sub-node of the SYSCFG node. >> + >> + The provided clocks are identified by the macros defined in >> + include/dt-bindings/clock/st,stm32mp25-syscfg-clk.h: >> + - CK_SYSCFG_PIX_LTDC: LTDC pixel clock, selected in the DISPLAYCLKCR >> + register among the LTDC kernel clock, used by the RGB parallel output, >> + the LVDS PHY pixel clock and the DSI PHY byte lane clock. >> + >> +properties: >> + compatible: >> + const: st,stm32mp25-syscfg-clk >> + >> + "#clock-cells": >> + const: 1 > So you have 1 clock, thus drop the header and here you have cells=0. Done in v3 [1]: this binding and the header are dropped, and the SYSCFG node keeps '#clock-cells = <0>'. >> + >> + clocks: >> + minItems: 1 > Why is this flexible? Device either has or has not these inputs. Because each SYSCFG compatible is shared by SoCs which don't have the same inputs: "st,stm32mp25-syscfg" is used by STM32MP251/253, which have neither LVDS nor DSI, and by STM32MP255/257, which have both. The same applies to "st,stm32mp23-syscfg" with STM32MP231/233 and STM32MP235. The inputs are thus listed in the "ltdc", "lvds", "dsi" order: stm32mp231.dtsi and stm32mp251.dtsi only describe the LTDC kernel clock, and stm32mp235.dtsi and stm32mp255.dtsi add the two others. In v3 these properties moved to the SYSCFG binding with the same constraint, which is explained in the commit message of patch 1/6. [1] https://lore.kernel.org/r/20261118-ups_mp25_clk_syscfg-v3-0-935de791a4ce@foss.st.com Best regards, Gabriel > >> + items: >> + - description: LTDC kernel clock >> + - description: LVDS PHY pixel clock >> + - description: DSI PHY byte lane clock >> + >> + clock-names: >> + minItems: 1 >> + items: >> + - const: ltdc >> + - const: lvds >> + - const: dsi >> + >> +required: >> + - compatible >> + - "#clock-cells" >> + - clocks >> + - clock-names > Best regards, > Krzysztof