From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98589C433FE for ; Mon, 24 Jan 2022 17:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244160AbiAXRKA (ORCPT ); Mon, 24 Jan 2022 12:10:00 -0500 Received: from foss.arm.com ([217.140.110.172]:41092 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244090AbiAXRJ6 (ORCPT ); Mon, 24 Jan 2022 12:09:58 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 76333D6E; Mon, 24 Jan 2022 09:09:58 -0800 (PST) Received: from [192.168.99.12] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DB3C03F73B; Mon, 24 Jan 2022 09:09:57 -0800 (PST) Message-ID: Date: Mon, 24 Jan 2022 17:09:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 03/60] drm/malidp: Add support for the nomodeset kernel parameter Content-Language: en-US To: Javier Martinez Canillas , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Liviu Dudau References: <20211215010008.2545520-1-javierm@redhat.com> <20211215010008.2545520-4-javierm@redhat.com> From: Carsten Haitzler Organization: Arm Ltd. In-Reply-To: <20211215010008.2545520-4-javierm@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seems fine to me. Reviewed-by: Carsten Haitzler On 12/15/21 00:59, Javier Martinez Canillas wrote: > According to disable Documentation/admin-guide/kernel-parameters.txt, this > parameter can be used to disable kernel modesetting. > > DRM drivers will not perform display-mode changes or accelerated rendering > and only the systewm system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/gpu/drm/arm/malidp_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index 78d15b04b105..5da4168eb76d 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -938,6 +938,9 @@ static int malidp_platform_probe(struct platform_device *pdev) > struct device_node *port; > struct component_match *match = NULL; > > + if (drm_firmware_drivers_only()) > + return -ENODEV; > + > if (!pdev->dev.of_node) > return -ENODEV; >