From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934179AbcIVDRF (ORCPT ); Wed, 21 Sep 2016 23:17:05 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:35956 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933184AbcIVDRD (ORCPT ); Wed, 21 Sep 2016 23:17:03 -0400 Subject: Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module To: sean.wang@mediatek.com, john@phrozen.org, davem@davemloft.net References: <1474511636-11644-1-git-send-email-sean.wang@mediatek.com> Cc: nbd@openwrt.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, andrew@lunn.ch, keyhaede@gmail.com, objelf@gmail.com From: Florian Fainelli Message-ID: Date: Wed, 21 Sep 2016 20:17:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474511636-11644-1-git-send-email-sean.wang@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 21/09/2016 à 19:33, sean.wang@mediatek.com a écrit : > From: Sean Wang > > By default, GMAC0 is connected to built-in switch called > MT7530 through the proprietary interface called Turbo RGMII > (TRGMII). TRGMII also supports well for RGMII as generic external > PHY uses but requires some slight changes to the setup of TRGMII > and doesn't have well support on current driver. > > So this patchset > 1) provides the slight changes of the setup for RGMII can work > through TRGMII > 2) adds additional setting "trgmii" as PHY_INTERFACE_MODE_TRGMII > about phy-mode on device tree to make GMAC0 distinguish which > mode it runs > 3) changes dynamically source clock, TX/RX delay and interface > mode on TRGMII for adapting various link > > Changes since v1: > - fixed the style of comment which doesn't have a space at > the beginning and end of comment lines > - add support for phy-mode "trgmii" as PHY_INTERFACE_MODE_TRGMII > into linux/phy.h > - enhance the Documentation about device tree binding for trgmii > which is applicable only for GMAC0 which uses fixed-link Looks good to me: Reviewed-by: Florian Fainelli Thanks Sean! -- Florian