From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4617D26738C for ; Mon, 29 Dec 2025 07:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766993907; cv=none; b=AYOrsK2OHqC8iDh6KGzowE1L/HPjJeDtVzq2jjW3pDRSqcu1W8zFXglUj3tWbWwudmbSDhDlSM2NsjBV26iA93mTMQWx9C8GPjNCunixb5UNA7G1MPKRjU+UO4KmtfdqH5n9I6jqLUZufBVOMCQ4fY3Rc7OlbinivSFhvlU6zn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766993907; c=relaxed/simple; bh=A6ejRK49SuhMuZCa+BwdQ3kNeu1BX78ilfSAhlAE7Q4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q/pWHSMETwYrYzoLXpTdHU+0J8YcNXtPiQrd5M68oiyUadkAZCgmxdqDeljCmstgvr8jQ/127V493QZA8+vBJ2ew9eUg/09OnxC2Uf0iWLb3ac9/TE2ppSLzc7eRC1N29eXl5Vi93qvSci+pNE766ZAdhJ0w8yLeaaqQb0COask= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=esAGvfo3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ApwzxeOV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="esAGvfo3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ApwzxeOV" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSNNeab3777454 for ; Mon, 29 Dec 2025 07:38:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IeqJ85GXspwcXvnTLhkXFl4jua0st89l6HElMd/mcbA=; b=esAGvfo3iVVM4fO+ +4huBTzjtMAMs/QUpETM0W16gs5zHM2cwYzCQ+Ia+6lJgr6r/7a+T7/S9oVYo0iE dC8DwVSb+u6k8aP2CTB+XEjzSrXhX0kYIjx5UQMQNhT4R0SDGateoogCIa0xh/2f ZccrTGkPfDbtOHrU1E7SsD1gve5ASC+DBNf/shuNdnsHEU1ig3k1j/bvnNUYxAOK mkNDdm0hjskG/c7eesnYrt4+hBjb3EIcuh1LufimP13HV4Wd1yNDVKNZW1f/wm65 WNg39bCvtAgu2oyqhLYWtJUgrs8M0oAhE5M8NMIHkUcBQfqkeHdAmBjVXnlUVaBQ mMYlFg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bbc8yryay-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 07:38:24 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-29f2b45ecffso146574165ad.2 for ; Sun, 28 Dec 2025 23:38:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766993904; x=1767598704; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IeqJ85GXspwcXvnTLhkXFl4jua0st89l6HElMd/mcbA=; b=ApwzxeOVrUGgPsgTq6fwLKD3gL9UQUk9VY9JR8p2OLnP177Bq0cCcWRfA2DiBY0YWT lDYsCO9zeG4GYz7agWWh4m67mUfQxY72xF8956tdd/Jcb5HnB4m8sLL/VASduTKP4OFb xihEr2sA60S+cHgRLQKN1WxV7BfX5DJGFE8XAZa7Dw5P3pC14dIrOXViEWidrwCcStmS SdVm0WMJjnGundhscYREKFd/D8Ko5b3Q+ZCaH2gFdEtkPB99gJy2t2jZnt3Hqg8j6sJJ pg/zjwg0o5ZxRQrtf2tnCZCMQHaxTuHNPaJdNarmj7MdgsE5pvb/VNrMy1oo9ia/IZ62 IV7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766993904; x=1767598704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IeqJ85GXspwcXvnTLhkXFl4jua0st89l6HElMd/mcbA=; b=Qi2wbw08BfzwOfLxQqaiaZKZJbDDh1uFv2CCkKWthGzdp8WrUysQrOmzNgeIjEjlxs uP1zKkXB1ALMFyTPHlx7aYnsD588rC679BmbgCrOlW/s67VE9qfzCtzzkGszMNrASMyC 7vaIrphMp2W86dlXukats46R3XTgN5bJE41Erpf4+KK3mEAacWU2SWXz0allWP2h+Zj0 kl4TJAunPcskIjSjom3Pk6CrTP7SAQE0ZAvHnOHeTJeV9p5JOgKfuJJmhuDJuTD268oU bp0Yd6Kz4Ik1k8CHH1wlkPAuDhLv+JOyU+nLy12C2fQ9+xNYYsz1mo7w81RI4/FcZsqz ZbWw== X-Forwarded-Encrypted: i=1; AJvYcCXM2FeENnSDPjQZUBkUosZ03O2shLNaUVXhWO8K40QrV+w/gDGHdIj88MWbidt8ZRzfW7jE4KmnJEO+YTc=@vger.kernel.org X-Gm-Message-State: AOJu0YwVyg2tBsqyDpDbrIXAFOyiZp6OW+UCDV2KJN7fpODMfw1XkIDd +eCQdvdoQVYOLNZ4PAcbSVb/h7kDkWZSzL7/zpglO/GFKxCmtZtTTVrhFG5gEs1+eM228uhuaSl OcxcYpBQ4qn+ngpJJdf3KGogX01LRseSyUJd+7Nj6i0grgDswe84wK9zBCjA5IwPU2YM= X-Gm-Gg: AY/fxX5JtvGAgmZi/K1V1voRhOFGaWYjG3ogSefRUh8ydvfbVGktP9eGawdfu/ur8cR cVIt5Vn3cXvv+Hu+jeafHUkYWnABpBlPWHXrQzbHM3XDmMfOItpc0upVCYIpsCpxkrHQp5basOV /ysJpTorYohsjgjmNuGv+A2eBq4z62hWETAi3SFIuixbv5o6LARzxO1cVgiuNoDo/9Azk1DnGKA WuGeU4O6lQngG+RJBxryIqno512bhTnuNo3raiZ1dV8oTKe5nekk4a8MOzgI2twedPxZOXdCqo3 PTXT2TWIfv+oXBWLajf7armGI0pFLYYAT2B9+Aks14MoINs8rnpqOkGjNNBce0NiiuXecyoU+R0 CsbhrFy2ioLAtImcx9iL34bSHjqrQzbi1XzRIITMjbIWejjC0N1FEsZu2rsXNHxPN5A== X-Received: by 2002:a17:903:ac4:b0:2a0:d5bf:b27c with SMTP id d9443c01a7336-2a2f2a4f768mr260346745ad.45.1766993903676; Sun, 28 Dec 2025 23:38:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIkbp/IyCi5N96ovsXaSD8oVoJm3V6p//w+/eGQXqn4O+KWJZzHzirEXCYZKkXI01vBhSIGw== X-Received: by 2002:a17:903:ac4:b0:2a0:d5bf:b27c with SMTP id d9443c01a7336-2a2f2a4f768mr260346585ad.45.1766993903176; Sun, 28 Dec 2025 23:38:23 -0800 (PST) Received: from [10.133.33.85] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d6ec6bsm260648065ad.87.2025.12.28.23.38.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Dec 2025 23:38:22 -0800 (PST) Message-ID: Date: Mon, 29 Dec 2025 15:38:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: Commonize IQ-X-IOT DTSI To: Krzysztof Kozlowski , Tingwei Zhang Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251222-purwa-v1-0-14ab9316e5ff@oss.qualcomm.com> <20251222060335.3485729-3-yijie.yang@oss.qualcomm.com> <20251222-fluorescent-turkey-of-gallantry-df0906@quoll> <6421f044-2b07-4518-9edc-b9b2ef49f4fb@kernel.org> <8bcf058f-5bf9-46ce-a188-e94954101f2f@oss.qualcomm.com> <4f79d090-7d1c-4fb3-a835-a7e4ff96f79c@oss.qualcomm.com> <448f2efa-5b1e-4855-a62d-2e375938b36f@kernel.org> Content-Language: en-US From: Yijie Yang In-Reply-To: <448f2efa-5b1e-4855-a62d-2e375938b36f@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA2OCBTYWx0ZWRfX6UEpNbl9ef7W OYyoOLSI9R3YwPEknX2iYQ5KIK0/4KOxB+TmiEO/l5xkwwqUV6C7G8sFdmwMDJsngba2ebJETVE zzPp44swLwDtLtixqpx2CXr6HmxKwesLa4bYYJWYhCyxIPpW4zPuYA5N12zT1GAbCskIeU1ZhXH Viqv6xTnvVkzzb5A1HZxpHijLdWs4Cfe6v+8BN8V5MUH0aXh1tzDFnR9OgeeWe7ZkS3S58ka7Fp GVFxuhAhfElO1Bt6dEYVpa5qcMwgWKvJdBKpFSG0zrNe/XMcT2Ehshb0oUqf9jbYG+7raugwLQ5 9NSq7bx+W7U+CLWpn5eBfKknDicIDZVUyaDrvi1swoi+CFHzQ+cwG+Dvg3BguGLAWCQNQsEdvXn U5sgC53O/m7/bGrya4Iv0MnzPRWIaiZqOaPWnZhBV3w+ePei2+k+0I3Wj6a5j50979HUo6BN5ys 6qnc0ecaThFIJem1kLg== X-Authority-Analysis: v=2.4 cv=cP7tc1eN c=1 sm=1 tr=0 ts=69522ff0 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=0VSGOVfmacAHMTgZEJEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: pAeynTYZz7nMsaJ3UDicIajzq6nLym9F X-Proofpoint-GUID: pAeynTYZz7nMsaJ3UDicIajzq6nLym9F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_02,2025-12-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290068 On 12/29/2025 3:21 PM, Krzysztof Kozlowski wrote: > On 29/12/2025 02:23, Tingwei Zhang wrote: >> >> >> On 12/24/2025 8:12 AM, Tingwei Zhang wrote: >>> >>> On 12/23/2025 9:41 PM, Krzysztof Kozlowski wrote: >>>> On 23/12/2025 04:38, Tingwei Zhang wrote: >>>>> On 12/22/2025 5:11 PM, Krzysztof Kozlowski wrote: >>>>>> On Mon, Dec 22, 2025 at 02:03:28PM +0800, YijieYang wrote: >>>>>>> From: Yijie Yang >>>>>>> >>>>>>> HAMOA-IOT-EVK and PURWA-IOT-EVK share a similar board design. Extract >>>>>>> the common components into separate files for better maintainability. >>>>>> SoMs do not share actual hardware. DTSI does not represent what looks >>>>>> similar to you, but actually common parts. >>>>> Purwa SOM board and Hamoa SOM board share same design. They share same PCB. >>>>> The difference is only on chip. Purwa SOM board has Purwa and Hamoa SOM board >>>>> has Hamoa on it. >>>> I do not speak about boards. Read carefully feedback and respond to the >>>> actual feedback, not some other arguments. >>>> >>>> NAK >>> In this change, the SoM hardware except SoC is described by iq-x-iot-som.dtsi since it's common between Hamoa and Purwa. Hamoa and Purwa SoC hardware is described in hamoa.dtsi and purwa.dtsi. Hamoa-iot-som.dtsi includes iq-x-iot-som.dtsi and hamoa.dtsi. This change could reduce the duplicate code and review effort on a totally new purwa-iot-som.dtsi. If we found any bug, it can be fixed in one common file instead of two separate files. Same idea is used in x1-crd.dtsi. X1e80100-crd.dts include x1-crd.dtsi and hamoa.dtsi. >> Krzysztof, >> Please let me know your opinion on this. This could be a common case for >> Hamoa/Purwa boards share same PCB. Share same dtsi file like x1-crd.dtsi > > It's not the same PCB. You did not really respond to my first message, > so I responded to you - I do not speak about boards. Then again you did > not respond to it and brought some irrelevant arguments. > >> would reduce maintenance effort. > > Does not matter, I do not question this. Why are you responding to some > questions which were never asked? > > DTSI represents actual shared physical aspect and you cannot share SoM > physically. It's not the same PCB, because you do not have a socket on > the SoM. x1e80100-crd and x1p42100-crd are different boards, yet they share the same x1-crd.dtsi. Why can’t we apply the same approach here? > > Best regards, > Krzysztof -- Best Regards, Yijie