From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52457306D37 for ; Fri, 24 Oct 2025 08:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761296107; cv=none; b=IObiB0r4MXuwC+J70sgaoLYYKjL/mHQu/HOuoyK6iJNT3+J0Ggcip/PdGDQ9aCtMVO/YT4cJyNSIO143w/DH1ggEN/wNXjtodi3C5xmL9BM/bUzzUPnt+7qGRnIpu9BR5r5EQloOd9hbNTdaASo243F18x0QbJgGxntjqb4OPKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761296107; c=relaxed/simple; bh=o9LIHBIMNVuwhtVPKbE8/C7LnK0F6i3Ii4cEm06JTtk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ER9l7K+2F1ovOvHXgp8yGoGYye9YePh8TtaoOYBPAEZY5gnJe9j4Xi0xtaJg3/9wXKWxkBViF2wJ1XvWshANu755UYjcWD6n8Sg4udOzB2vpQVFJt1dwAzDqS6vEw0YkglewPe2p4XwSth2EPEmI1krzZiMzFogZNeSGNXnWwdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bnBri4hg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bnBri4hg" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59O3M6D9010211 for ; Fri, 24 Oct 2025 08:55:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QLEqj8vg3DpwyQO+fKvM+2N23Csi21bAOUajBQu74n0=; b=bnBri4hgoz4+rBAk vFnPyynJEUe9WRgARX+rMqoYM8KaZ/M1MF5QmTz3hudKIaQSTrHo/t25UzM5R1u6 TSsKSke3zTvVtqMX1P0/NGJTE0x+TvUMvucmFGPsfehqjLeZ7d3xxRSvoOQfDM7r 8aNjdp0GJ7IZQkkR7ypwSH+9lgFNJrLUZVHXY94O2Fu3ZtH89SXWRC544xixwdbA ODR6HqY5EFBZIXxv0JCJaD2tbrbYlL41/J2g63OcWa3DaZmzfQ9dzvHKthGAGqaw ZREGW2/Pz2+Ypha/jSoaA52BsObqVMfjKf+vXB6xHpNdNJckD5W33rbyG8mu4BQQ YyerDQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49y524dn19-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 24 Oct 2025 08:55:05 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-87c28cecb4cso5519196d6.0 for ; Fri, 24 Oct 2025 01:55:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761296104; x=1761900904; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QLEqj8vg3DpwyQO+fKvM+2N23Csi21bAOUajBQu74n0=; b=oThcKeYD4roAS5WLlz3R++a49u/9P+DzzPj9GvpPSjxYzUwF76RUQTn2q59mai1Sw1 j11CzqsVXDA3iFJVLgtS7WiFizizg4fGx+lV3GGu2SSZ3YRDm3xPRvyfc0LAiG+RnecJ dl1ci3mdKAn2QlRXmRXpMXT5nY71cXZxt7rFR7xEjyyzbqibUXkOBXtcmZASY+0xV4/7 HlDv6C+yC/SU9sxAhNH9D5WIbonhcRDvpfNk18LnFVnFSO9PHvHvyUQQTIYAwgdH0PlF tr6e751LQ50IQRSVpp6elk3V63qq639ftaFMXpURAT5iPaGL79kZdOoB3G1T28blqJ1+ NvtQ== X-Forwarded-Encrypted: i=1; AJvYcCXBluis54O09HFAl6h8ewyXd7cNiKakoRLXQwpz20qRXt30ATd11OMtmqRHUK2LX0hgILaQ3TLVZKoTzNw=@vger.kernel.org X-Gm-Message-State: AOJu0YxeFZCwN8fF/VPjoFpC/XAshRKB1wcYq/T3zHO7Hlmk18CQojiD Mf0T1ooSBe9kU0n3eFUJMyIEzC6bqQzDIK8xWTlPSWlPt9ZQ2ApXIubldbbMP4hJt91NUjtXF8z tQ0YwaeXPT9QE8bJfvSzr5AoNYjCuOMxblm4F9/stK7qvk0mkCx0bW0JVwQacOkrfJpY= X-Gm-Gg: ASbGnct5HuVox80AOVHNOVM29B4cGdG4tFSrTBrqCB+JASexBIKAzHatDuaOA8i+Hry jdyVZCC4evSx/eUBYTAUPZn6H92EDpo3YJD6F1LY6gnt1w4xKQWqVEhidPGD24zRrDJ7EWWs7wj tb0aYLKvsmQmGqo2wr11jhIE/S1X1KA+ctyBnek4I/k3AD8H3wDf0ScX7+GYLvtsXE/IKo0bF5f L0MPhtUR6UUGXkQR5nvSeJHwnU18WriTAe1DinqmtxXPYXz4hdgmrZHuFQwdFsOoTdQcWohqccM /B2f6Rws7vqk8gzFb0mGcOgy8IN5C7VziZYIlAycwaZMxvDxH3NCYAdezo2UVcXJPegt9OXPpwr FZQeFcbCDwssr9hdSPn3IQCjLPY7N2YYc7deD8WGvt7BJndlifPYSp7kq X-Received: by 2002:ac8:57c2:0:b0:4e8:9af1:366c with SMTP id d75a77b69052e-4ea1177c509mr118203701cf.9.1761296104174; Fri, 24 Oct 2025 01:55:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWZ/AyCKsRVq/DeeaOVV3qlQdtXKIx3PeDH8Nx8c0mJpXsDEkee8YBg64b/7qGPs+6AarhGA== X-Received: by 2002:ac8:57c2:0:b0:4e8:9af1:366c with SMTP id d75a77b69052e-4ea1177c509mr118203471cf.9.1761296103588; Fri, 24 Oct 2025 01:55:03 -0700 (PDT) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d513199d0sm462820166b.37.2025.10.24.01.55.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Oct 2025 01:55:03 -0700 (PDT) Message-ID: Date: Fri, 24 Oct 2025 10:55:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC RFT] drm/msm: adreno: attach the GMU device to a driver To: Neil Armstrong , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251022-topic-adreno-attach-gmu-to-driver-v1-1-999037f7c83e@linaro.org> <5d6e7303-cc57-4a50-a9ad-b45d3c89d045@oss.qualcomm.com> <25e829f8-60b2-4b69-8d57-ded846b5206a@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <25e829f8-60b2-4b69-8d57-ded846b5206a@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDIyMDE1NSBTYWx0ZWRfX1AMcf+JRrWmD qHV/oNB3y/jbRNwcEOtq7nDDa9iRh64mherojNR7NbBGfzp1Jm4ziSAfw2ZeJwcKSTWhJYT1reT 1GeHMm4qXa/5nXoa8Ow45EHvFrszDC5CjuEx+Fcf4FBRMa6E67N2myKl7ocSBPR2xxeRFYotxAs uj7HHPXM1zw05xUuSQQNm5O0iF55N6bZjr/FIvbFaM28gngW/owqiTrcIBv3YRJfxcBBTl7x9tQ YGyO2Q1dn926qqfs4vLdoJPD4NqbynbXViEkn+IKIiVSJmxxkDjWMpMenrd7WBYo+FqYWP2Vk6M +OH4L5FRf08gOgTggbms07OyofCfO6vXd8LjYVuNbg0FJKJTZZZnMSgcV08OhBPqywXYApwfrd1 kgUe/MkiyJ0Q+XlCz1hVy4pEdu+krg== X-Authority-Analysis: v=2.4 cv=Uotu9uwB c=1 sm=1 tr=0 ts=68fb3ee9 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=5e8rntOtLM__4sLSfr8A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: M9GC2DJQq_GPEs2-F4BW7iZd8f18NKMb X-Proofpoint-ORIG-GUID: M9GC2DJQq_GPEs2-F4BW7iZd8f18NKMb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-23_03,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510220155 On 10/23/25 10:27 AM, Neil Armstrong wrote: > On 10/22/25 19:09, Konrad Dybcio wrote: >> On 10/22/25 2:44 PM, Neil Armstrong wrote: >>> Due to the sync_state is enabled by default in pmdomain & CCF since v6.17, >>> the GCC and GPUCC sync_state would stay pending, leaving the resources in >>> full performance: >>> gcc-x1e80100 100000.clock-controller: sync_state() pending due to 3d6a000.gmu >>> gpucc-x1e80100 3d90000.clock-controller: sync_state() pending due to 3d6a000.gmu >> >> Does this *actually* cause any harm, by the way? > > ? > >> >> For example on x1e, GMU refers to 2 GPU_CC GDSCs, GPU_CC refers >> to a pair of GCC clocks and GCC refers to VDD_CX >> >> and I see these prints, yet: >> >> /sys/kernel/debug/pm_genpd/gpu_cx_gdsc/current_state:off-0 >> /sys/kernel/debug/pm_genpd/gpu_gx_gdsc/current_state:off-0 >> >> /sys/kernel/debug/pm_genpd/cx/current_state:on >> /sys/kernel/debug/pm_genpd/cx/perf_state:256 # because of USB3 votes >> >> I'm not super sure where that sync_state comes from either (maybe >> dev_set_drv_sync_state in pmdomain/core?) > > The way we handle the GMU so far is wrong, it abuses the driver model. > > And this is a symptom, whatever the impact it has, it needs to be fixed > in a proper way. > > The sync_state is retained because the gmu device is never probed but > has some clocks and power domains attached to it, which is clearly wrong. Yes I agree, however I'm only debating the commit message claims of 'leaving the resources in full performance', which doesn't seem to be true Konrad