From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Chris Kennelly <ckennelly@google.com>
Cc: nd@arm.com, "Joel Fernandes, Google" <joel@joelfernandes.org>,
Paul Turner <pjt@google.com>, Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <codonell@redhat.com>,
libc-alpha <libc-alpha@sourceware.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
paulmck <paulmck@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
Brian Geffon <bgeffon@google.com>
Subject: Re: Rseq registration: Google tcmalloc vs glibc
Date: Thu, 27 Feb 2020 10:18:32 +0000 [thread overview]
Message-ID: <c79e3622-30df-001f-8f60-5a3edc10f7e5@arm.com> (raw)
In-Reply-To: <982202794.8791.1582743392060.JavaMail.zimbra@efficios.com>
On 26/02/2020 18:56, Mathieu Desnoyers wrote:
> ----- On Feb 26, 2020, at 12:27 PM, Chris Kennelly ckennelly@google.com wrote:
>> I agree that this could potentially violate inviarants, but
>> InitFastPerCpu is not intended to be called by the application.
>
> OK, explicitly documenting this would be a good thing. In my own projects,
> I prefix those symbols with double-underscores (__) to indicate that those
> are not meant to be called by other means than the static inlines in the API.
use a different convention for that, __ prefix is always
reserved for the implementation for arbitrary use.
ideally internals would not be exposed in the user api
and then there is no such issue.
next prev parent reply other threads:[~2020-02-27 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 21:33 Mathieu Desnoyers
[not found] ` <CAEE+ybmTzNoBc9YmK2j48MKtSoPHC_1Mgr+ojPpiOTTc+4E=9g@mail.gmail.com>
2020-02-21 13:07 ` Florian Weimer
2020-02-21 15:49 ` Joel Fernandes
2020-02-21 16:13 ` Mathieu Desnoyers
2020-02-26 3:24 ` Joel Fernandes
2020-02-26 3:38 ` Chris Kennelly
2020-02-26 17:01 ` Mathieu Desnoyers
2020-02-26 17:27 ` Chris Kennelly
2020-02-26 18:56 ` Mathieu Desnoyers
2020-02-26 19:12 ` Chris Kennelly
2020-02-26 21:21 ` Mathieu Desnoyers
2020-02-27 10:18 ` Szabolcs Nagy [this message]
2020-02-27 10:32 ` Florian Weimer
2020-02-26 21:51 ` Mathieu Desnoyers
2020-02-27 21:11 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c79e3622-30df-001f-8f60-5a3edc10f7e5@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=bgeffon@google.com \
--cc=boqun.feng@gmail.com \
--cc=ckennelly@google.com \
--cc=codonell@redhat.com \
--cc=fweimer@redhat.com \
--cc=joel@joelfernandes.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=nd@arm.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®