From: Guenter Roeck <linux@roeck-us.net>
To: Michal Wilczynski <michal.wilczynski@intel.com>
Cc: rafael@kernel.org, andriy.shevchenko@intel.com,
artem.bityutskiy@linux.intel.com, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, lenb@kernel.org,
jgross@suse.com, linux-kernel@vger.kernel.org, x86@kernel.org,
Michal Wilczynski <michal.wilczynski@intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] ACPI: processor: Move MWAIT quirk out of acpi_processor.c
Date: Tue, 29 Aug 2023 06:44:10 -0700 [thread overview]
Message-ID: <c7a05a44-c0be-46c2-a21d-b242524d482b@roeck-us.net> (raw)
On Mon, Jul 10, 2023 at 05:03:29PM +0300, Michal Wilczynski wrote:
> Commit 2a2a64714d9c ("ACPI: Disable MWAIT via DMI on broken Compal board")
> introduced a workaround for MWAIT for a specific x86 system.
>
> Move the code outside of acpi_processor.c to acpi/x86/ directory for
> consistency and rename the functions associated with it, so their names
> start with "acpi_proc_quirk_" to make the goal obvious.
>
> No intentional functional impact.
>
Except for:
ia64-linux-ld: drivers/acpi/acpi_processor.o: in function `acpi_early_processor_control_setup':
acpi_processor.c:(.init.text+0x712): undefined reference to `acpi_proc_quirk_mwait_check'
ia64-linux-ld: drivers/acpi/processor_pdc.o: in function `acpi_early_processor_set_pdc':
processor_pdc.c:(.init.text+0x72): undefined reference to `acpi_proc_quirk_mwait_check'
which breaks all ia64 builds.
Time to retire that architecture yet ? No one but me seems to even
build test it.
Guenter
next reply other threads:[~2023-08-29 13:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 13:44 Guenter Roeck [this message]
2023-08-29 13:54 ` Rafael J. Wysocki
2023-08-29 13:56 ` Wilczynski, Michal
2023-08-29 14:03 ` Rafael J. Wysocki
2023-08-29 14:20 ` Wilczynski, Michal
2023-08-29 14:25 ` Rafael J. Wysocki
2023-08-29 14:38 ` Wilczynski, Michal
2023-08-29 14:53 ` Guenter Roeck
2023-08-29 15:02 ` Rafael J. Wysocki
2023-08-29 15:05 ` Andy Shevchenko
2023-08-29 14:02 ` Andy Shevchenko
2023-08-29 14:44 ` Guenter Roeck
2023-08-29 14:10 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7a05a44-c0be-46c2-a21d-b242524d482b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®