From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757109AbdJKMRJ (ORCPT ); Wed, 11 Oct 2017 08:17:09 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:9806 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752077AbdJKMRH (ORCPT ); Wed, 11 Oct 2017 08:17:07 -0400 Subject: Re: [PATCH][dma-next] dmaengine: stm32: remove redundant initialization of hwdesc To: Colin King , Vinod Koul , Dan Williams , Maxime Coquelin , Alexandre Torgue , , CC: , References: <20171011102822.19166-1-colin.king@canonical.com> From: Pierre Yves MORDRET Message-ID: Date: Wed, 11 Oct 2017 14:16:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171011102822.19166-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG3NODE1.st.com (10.75.127.7) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-11_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2017 12:28 PM, Colin King wrote: > From: Colin Ian King > > hwdesc is being initialized to desc->hwdesc but this is never read > as hwdesc is overwritten in a for-loop. Remove the redundant > initialization and move the declaration of hwdesc into the for-loop. > > Cleans up clang warning: > Value stored to 'hwdesc' during its initialization is never read > > Signed-off-by: Colin Ian King > --- > drivers/dma/stm32-mdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c > index 0db59a7e80e0..d3be6bffdf12 100644 > --- a/drivers/dma/stm32-mdma.c > +++ b/drivers/dma/stm32-mdma.c > @@ -1252,13 +1252,13 @@ static size_t stm32_mdma_desc_residue(struct stm32_mdma_chan *chan, > u32 curr_hwdesc) > { > struct stm32_mdma_device *dmadev = stm32_mdma_get_dev(chan); > - struct stm32_mdma_hwdesc *hwdesc = desc->hwdesc; > u32 cbndtr, residue, modulo, burst_size; > int i; > > residue = 0; > for (i = curr_hwdesc + 1; i < desc->count; i++) { > - hwdesc = &desc->hwdesc[i]; > + struct stm32_mdma_hwdesc *hwdesc = &desc->hwdesc[i]; > + > residue += STM32_MDMA_CBNDTR_BNDT(hwdesc->cbndtr); > } > cbndtr = stm32_mdma_read(dmadev, STM32_MDMA_CBNDTR(chan->id)); > Acked-by: Pierre-Yves MORDRET