mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Engraf <david.engraf@sysgo.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: serio - add writing multiple bytes at once
Date: Wed, 2 May 2018 09:07:59 +0200	[thread overview]
Message-ID: <c7ae7509-a29d-85e1-a8da-41e275e98779@sysgo.com> (raw)
In-Reply-To: <20180430212007.GC54182@dtor-ws>

Hi Dmitry,

On 30.04.2018 at 23:20, Dmitry Torokhov wrote:
> Hi David,
> 
> On Mon, Apr 30, 2018 at 11:03:24AM +0200, David Engraf wrote:
>> The current version only supports forwarding a single byte to the tty
>> layer.
>>
>> This patch adds serio_write_length() to allow a serport driver writing
>> multiple bytes at once. The patch also includes a fallback to
>> serio_write_length() when a driver did not register a single byte function.
> 
> Without users I do not see point for this API.

Here is an incomplete list of drivers calling serio_write() in a loop:

- drivers/media/usb/rainshadow-cec/rainshadow-cec.c
- drivers/input/serio/serio_raw.c
- drivers/input/touchscreen/elo.c

I can simplify these drivers by using serio_write_length() if you want 
to have some users for the new API.

Best regards
- David

      reply	other threads:[~2018-05-02  7:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  9:03 David Engraf
2018-04-30 21:20 ` Dmitry Torokhov
2018-05-02  7:07   ` David Engraf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7ae7509-a29d-85e1-a8da-41e275e98779@sysgo.com \
    --to=david.engraf@sysgo.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®