From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbdEVFs3 (ORCPT ); Mon, 22 May 2017 01:48:29 -0400 Received: from goliath.siemens.de ([192.35.17.28]:37667 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbdEVFs0 (ORCPT ); Mon, 22 May 2017 01:48:26 -0400 Subject: Re: gpio-exar: Why filtering out Commtech devices? To: Sudip Mukherjee , Matt Schulte Cc: Linux Kernel Mailing List , linux-serial , linux-gpio References: <18f4b5cb-cba0-aab4-7958-84a5b8d28935@siemens.com> <7a25751e-931f-b713-dcdd-7a7483aae115@codethink.co.uk> From: Jan Kiszka Message-ID: Date: Mon, 22 May 2017 07:48:18 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <7a25751e-931f-b713-dcdd-7a7483aae115@codethink.co.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-21 22:08, Sudip Mukherjee wrote: > Hi Jan, > > On 21/05/17 12:46, Jan Kiszka wrote: >> Hi Sudip, >> >> why do we carry >> >> if (pcidev->vendor != PCI_VENDOR_ID_EXAR) >> return -ENODEV; >> >> in gpio_exar_probe? This effectively prevents that >> >> EXAR_DEVICE(COMMTECH, COMMTECH_4222PCIE, pbn_exar_XR17V35x), >> EXAR_DEVICE(COMMTECH, COMMTECH_4224PCIE, pbn_exar_XR17V35x), >> EXAR_DEVICE(COMMTECH, COMMTECH_4228PCIE, pbn_exar_XR17V35x), >> >> gain GPIO support. Do those devices lack access to the pins? Or can we >> drop the filter. I don't have access to those devices, just wondering >> because the code is not explaining the reason. > > Same here. I do not have these devices and have no idea if they support > the gpio pins or not. > > Adding Matt Schulte in the Cc list, maybe he can comment. > > If we need to keep the condition, it should be moved over to 8250_exar: there is no point in creating the platform device at all then. But let's wait for Matt's comment. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux