From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from s1.sapience.com (s1.sapience.com [72.84.236.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 068391BAED6; Tue, 10 Dec 2024 15:40:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=72.84.236.66 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733845262; cv=fail; b=fKQzhll3No2Iy5jBrj4pge9UtV21A1BgxFiSyYheDZtKBLC73ghDM2GL3yK7jYI0sfL81+tSumm4CT05JuAdgcxy57HEm25I2OAVXCyar9WtT8ccAz+BM0sBsy3/k4YdqMmzQ4RqSM16XXuYkimgMZBPVAvbF+/fk1t0ABNfTvg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733845262; c=relaxed/simple; bh=xx9OGlyMWA+ZCfEDE/zVSR0WiOZyRnK7g97Awiaf61c=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=fJEX44hjytGivCJRYsCAphcFShsPIWJB207Vtn1ezMIYqKaPQtUVcwLTjuPC9LLf2KnUcw1ZX57BsmqgHeaZhhdUEvGLOTbC47z8jhMAR4E2ZHi2TT7iqkdVmyy3aSwv7VzTvDXnPlJvK/p9pPvDNbRggwfwwayVo3fWwGvcO+o= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sapience.com; spf=pass smtp.mailfrom=sapience.com; dkim=permerror (0-bit key) header.d=sapience.com header.i=@sapience.com header.b=LFTYlwJk; dkim=pass (2048-bit key) header.d=sapience.com header.i=@sapience.com header.b=hbQlnC90; arc=fail smtp.client-ip=72.84.236.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sapience.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sapience.com Authentication-Results: smtp.subspace.kernel.org; dkim=permerror (0-bit key) header.d=sapience.com header.i=@sapience.com header.b="LFTYlwJk"; dkim=pass (2048-bit key) header.d=sapience.com header.i=@sapience.com header.b="hbQlnC90" Authentication-Results: dkim-srvy7; dkim=pass (Good ed25519-sha256 signature) header.d=sapience.com header.i=@sapience.com header.a=ed25519-sha256; dkim=pass (Good 2048 bit rsa-sha256 signature) header.d=sapience.com header.i=@sapience.com header.a=rsa-sha256 Received: from srv8.sapience.com (srv8.sapience.com [x.x.x.x]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by s1.sapience.com (Postfix) with ESMTPS id 24D39480A33; Tue, 10 Dec 2024 10:40:53 -0500 (EST) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=sapience.com; i=@sapience.com; q=dns/txt; s=dk-ed25519-220413; t=1733845252; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : from; bh=viGzOwcqwCLVwVxfAG1ol+YDmxSbec8Tk3SBFWFyYpk=; b=LFTYlwJk5MubDFS20GYYlvcmz2anq5djcHHL3+ZoQtKeXEG45UVD7wKR4ryFKqMDwd2FV A9xp9QYXprDidp2DA== ARC-Seal: i=1; a=rsa-sha256; d=sapience.com; s=arc6-rsa-220412; t=1733845252; cv=none; b=MKY8PRs2U9FDBok0/wh5enK2cwbcvNzLJMUUYKZFdtVVZMNmtPidOsrDCJGANMR1+y1yoyi/vYf6HoxBK4DObYU0Y5h264sW72K2rSms/iz26h875hRSTPENC0Dy8xu/fHvG4aCajcGqecaA2VXqyIgXImBM/KWjBaTZ4J/r+mVwHAXqtv2EGor3dYJxy+6NMfmOhGa/eW+3yW4OJLnyd/oPSpzM3f1YWpEUJzLPVEl3ZT6Iw5siyCvkFYlqU1VHDFSKbppQYaDjfz5UGnv+UPUFYnIJ24VjvTvqbeGVcdlATLBF1khu/GyVQAQcKRHlAF9DziYRoHBpocd2wUQAnw== ARC-Message-Signature: i=1; a=rsa-sha256; d=sapience.com; s=arc6-rsa-220412; t=1733845252; c=relaxed/simple; bh=xx9OGlyMWA+ZCfEDE/zVSR0WiOZyRnK7g97Awiaf61c=; h=DKIM-Signature:DKIM-Signature:Message-ID:Subject:From:To:Cc:Date: In-Reply-To:References:Autocrypt:Content-Type:User-Agent: MIME-Version; b=or5aALtWSbfta0tfHYn3uO+ntBjh2NOpr587v75Cigw7sb195BNDXTz90/20IIVx1vFX62sakhKQTx8Q9B9Wa9zuOeWSK4IdgukQ+/epu8k8ZqlHyZSUEhCHrR3GlSAJcTuGCiC3CUSwUXWVWFAKtHE8oV75yAL2lZzkDe5fbb7ZWYqW+4qUz3McL7KwlUtPWcd0734hoH3y/q8Yw4+ON1IHHu/WHexf5Q9mHg3FjbOEFmIZMCG9ZaXT78QNjrpmIdz8Un6ycoHNPpRufLM102zFnkGvjkU4BkvoMzU55yKmgE2inPyN56/A3vCKKE6iaeNEbzzctN3LDz8UtPjhDQ== ARC-Authentication-Results: i=1; arc-srv8.sapience.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sapience.com; i=@sapience.com; q=dns/txt; s=dk-rsa-220413; t=1733845252; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : from; bh=viGzOwcqwCLVwVxfAG1ol+YDmxSbec8Tk3SBFWFyYpk=; b=hbQlnC90J5pqePwvPC1ZEcTBKYn3/EcftD7z65n+lsikCxvEGhHtlRQVw+1loKiAQagRU 82B/n2q3s5sTiUTmhEWpV+iUv+Y28gMSX/wQ9nnYjntFIfAHk617JG2e0eQtUTqJoDsqbFI TJ08/10/BpcwMCjMtsoPcs3P0V46hdEu7B6z75nIz8Liy4cZpQoHWu1bPLmtkbNdXzBDcC7 fRt+QNT6H5NqGwiGsmUSe7NLQkQIauWjBwQDdQ7aYqaQefFDDjVJ65j5T8g4jzvM+/a5Pbp MUtOp2/TMjIoNKqMuh2JwiF0QVFEaFHXPzSs4Ewqce4E2DB/LK53kznGSlmg== Received: from lap7.sapience.com (lap7w.sapience.com [x.x.x.x]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by srv8.sapience.com (Postfix) with ESMTPS id D57BA280015; Tue, 10 Dec 2024 10:40:52 -0500 (EST) Message-ID: Subject: Re: Linux 6.12.4 - crash dma_alloc_attrs+0x12b via ipu6 From: Genes Lists To: Greg Kroah-Hartman , Jani Nikula Cc: Sakari Ailus , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, stable@vger.kernel.org, linux-media@vger.kernel.org, bingbu.cao@intel.com, Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Date: Tue, 10 Dec 2024 10:40:52 -0500 In-Reply-To: <2024121001-senator-raffle-a371@gregkh> References: <2024120917-vision-outcast-85f2@gregkh> <87seqvzzg6.fsf@intel.com> <87bjxjzpwn.fsf@intel.com> <2024121001-senator-raffle-a371@gregkh> Autocrypt: addr=lists@sapience.com; prefer-encrypt=mutual; keydata=mDMEXSY9GRYJKwYBBAHaRw8BAQdAwzFfmp+m0ldl2vgmbtPC/XN7/k5vscpADq3BmRy5R 7y0LU1haWwgTGlzdHMgKEwwIDIwMTkwNzEwKSA8bGlzdHNAc2FwaWVuY2UuY29tPoiWBBMWCAA+Ah sBBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAFiEE5YMoUxcbEgQOvOMKc+dlCv6PxQAFAmPJfooFCRl vRHEACgkQc+dlCv6PxQAc/wEA/Dbmg91DOGXll0OW1GKaZQGQDl7fHibMOKRGC6X/emoA+wQR5FIz BnV/PrXbao8LS/h0tSkeXgPsYxrzvfZInIAC Content-Type: multipart/signed; micalg="pgp-sha384"; protocol="application/pgp-signature"; boundary="=-Xc8d1025CSmc9deeZWxz" User-Agent: Evolution 3.54.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-Xc8d1025CSmc9deeZWxz Content-Type: multipart/alternative; boundary="=-ATW+YCb9hWsFseu7CJ2a" --=-ATW+YCb9hWsFseu7CJ2a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2024-12-10 at 13:37 +0100, Greg Kroah-Hartman wrote: > > t's a clue nonetheless. >=20 > 'git bisect' would be nice to run if possible... Done: a) One (hopefully) small caveat : the very first bisect hit the 6.12.2 bug of missing commit b23decf8ac91 ("sched: Initialize idle tasks only once"). I applied the commit and continued. b) Result : 6ac269abab9ca5ae910deb2d3ca54351c3467e99 is the first bad commit commit 6ac269abab9ca5ae910deb2d3ca54351c3467e99 (HEAD) Author: Bingbu Cao Date: Wed Oct 16 15:53:01 2024 +0800 media: ipu6: not override the dma_ops of device in driver [ Upstream commit daabc5c64703432c4a8798421a3588c2c142c51b ] DMA ops are a helper for architectures and not for drivers to override the DMA implementation. Driver should not override the DMA implementation. This patch removes the dma_ops override from auxiliary device and adds driver-internal helpers that use the actual DMA mapping APIs. Fixes: 9163d83573e4 ("media: intel/ipu6: add IPU6 DMA mapping API and MMU table") Signed-off-by: Bingbu Cao Reviewed-by: Christoph Hellwig [Sakari Ailus: Fix the commit message a little.] Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin drivers/media/pci/intel/ipu6/ipu6-bus.c | 6 -- drivers/media/pci/intel/ipu6/ipu6-buttress.c | 21 +++++-- drivers/media/pci/intel/ipu6/ipu6-cpd.c | 18 +++--- drivers/media/pci/intel/ipu6/ipu6-dma.c | 195 +++++++++++++++++++++++++++++--------------------------------- drivers/media/pci/intel/ipu6/ipu6-dma.h | 34 ++++++++++- drivers/media/pci/intel/ipu6/ipu6-fw-com.c | 14 ++--- 6 files changed, 156 insertions(+), 132 deletions(-) c) git bisect log git bisect start # status: waiting for both good and bad commits # good: [d390303b28dabbb91b2d32016a4f72da478733b9] Linux 6.12.1 git bisect good d390303b28dabbb91b2d32016a4f72da478733b9 # status: waiting for bad commit, 1 good commit known # bad: [61baee2dc5341c936e7fa7b1ca33c5607868de69] Linux 6.12.4 git bisect bad 61baee2dc5341c936e7fa7b1ca33c5607868de69 # bad: [2bc07714dc955a91d2923a440ea02c3cb3376b10] virtiofs: use pages instead of pointer for kernel direct IO git bisect bad 2bc07714dc955a91d2923a440ea02c3cb3376b10 # bad: [6f2648838ce1a9f2c432e84e38dec5d38412a551] wifi: wilc1000: Set MAC after operation mode git bisect bad 6f2648838ce1a9f2c432e84e38dec5d38412a551 # good: [e20117a105d4174c2daf4d6da17b92d757487e60] media: i2c: max96717: clean up on error in max96717_subdev_init() git bisect good e20117a105d4174c2daf4d6da17b92d757487e60 # bad: [74f21be9990a42dc2357bcf87a13e16c6998b90e] drm/vc4: hdmi: Avoid hang with debug registers when suspended git bisect bad 74f21be9990a42dc2357bcf87a13e16c6998b90e # good: [dfdd0e8ff65dfc4183b622c3ffd8d8c5d572ca34] dt-bindings: cache: qcom,llcc: Fix X1E80100 reg entries git bisect good dfdd0e8ff65dfc4183b622c3ffd8d8c5d572ca34 # good: [b0cd515202cb31c89d7de46b103a7ff2de9de02b] media: ipu6: Fix DMA and physical address debugging messages for 32-bit git bisect good b0cd515202cb31c89d7de46b103a7ff2de9de02b # bad: [3d48d0fbaaa74a04fb9092780a3f83dc4f3f8160] HID: hyperv: streamline driver probe to avoid devres issues git bisect bad 3d48d0fbaaa74a04fb9092780a3f83dc4f3f8160 # bad: [e3692460675bfe07f677711ead09a7a43934aa2f] pwm: Assume a disabled PWM to emit a constant inactive output git bisect bad e3692460675bfe07f677711ead09a7a43934aa2f # bad: [11b0543efe54357b94dccb88dac2099c59358cd4] media: ipu6: remove architecture DMA ops dependency in Kconfig git bisect bad 11b0543efe54357b94dccb88dac2099c59358cd4 # bad: [6ac269abab9ca5ae910deb2d3ca54351c3467e99] media: ipu6: not override the dma_ops of device in driver git bisect bad 6ac269abab9ca5ae910deb2d3ca54351c3467e99 # first bad commit: [6ac269abab9ca5ae910deb2d3ca54351c3467e99] media: ipu6: not override the dma_ops of device in driver --=20 Gene --=-ATW+YCb9hWsFseu7CJ2a Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
On Tue, 2024-12-10 at 13:37 +0100, Greg Kroah-Har= tman wrote:
t's a clue nonetheless.

'git bis= ect' would be nice to run if possible...

Done:

a) One (hopefully) small caveat :
the very first bisect hit the 6.12.2 bug of missing commit b23dec= f8ac91
("sched: Initialize idle tasks only once").
= I applied the commit and continued.

b) Result :

6ac269abab9ca5ae910deb2d3ca54351c3467e99 is the firs= t bad commit
commit 6ac269abab9ca5ae910deb2d3ca54351c3467e99 (HEA= D)
Author: Bingbu Cao <bingbu.cao@intel.com>
Date: Wed Oct 16 15:53:01 2024 +0= 800

media: ipu6: not override the dma_ops of d= evice in driver

[ Upstream commit daabc5c64703= 432c4a8798421a3588c2c142c51b ]

DMA ops are a h= elper for architectures and not for drivers to override the
D= MA implementation. Driver should not override the DMA implementation.
=

This patch removes the dma_ops override from auxili= ary device and adds
driver-internal helpers that use the actu= al DMA mapping APIs.

Fixes: 9163d83573e4 ("med= ia: intel/ipu6: add IPU6 DMA mapping API and MMU table")
Sign= ed-off-by: Bingbu Cao <bingbu.ca= o@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[Sakari Ailus: Fix= the commit message a little.]
Signed-off-by: Sakari Ailus &l= t;sakari.ailus@linux.intel.= com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by= : Sasha Levin <sashal@kernel.org>

drivers/media/pci/intel/ipu6/ipu6-cpd.c | 18 +++---<= /div>
drivers/media/pci/intel/ipu6/ipu6-dma.c | 195 +++++++++++++= ++++++++++++++++---------------------------------
drivers/media/= pci/intel/ipu6/ipu6-dma.h | 34 ++++++++++-
drivers/media/p= ci/intel/ipu6/ipu6-fw-com.c | 14 ++---
6 files changed, 156 i= nsertions(+), 132 deletions(-)

c) git bisect log

git bisect start
# status: waiting for bo= th good and bad commits
# good: [d390303b28dabbb91b2d32016a4f72da= 478733b9] Linux 6.12.1
git bisect good d390303b28dabbb91b2d32016a= 4f72da478733b9
# status: waiting for bad commit, 1 good commit kn= own
# bad: [61baee2dc5341c936e7fa7b1ca33c5607868de69] Linux 6.12.= 4
git bisect bad 61baee2dc5341c936e7fa7b1ca33c5607868de69
# bad: [2bc07714dc955a91d2923a440ea02c3cb3376b10] virtiofs: use pages in= stead of pointer for kernel direct IO
git bisect bad 2bc07714dc95= 5a91d2923a440ea02c3cb3376b10
# bad: [6f2648838ce1a9f2c432e84e38de= c5d38412a551] wifi: wilc1000: Set MAC after operation mode
git bi= sect bad 6f2648838ce1a9f2c432e84e38dec5d38412a551
# good: [e20117= a105d4174c2daf4d6da17b92d757487e60] media: i2c: max96717: clean up on error= in max96717_subdev_init()
git bisect good e20117a105d4174c2daf4d= 6da17b92d757487e60
# bad: [74f21be9990a42dc2357bcf87a13e16c6998b9= 0e] drm/vc4: hdmi: Avoid hang with debug registers when suspended
git bisect bad 74f21be9990a42dc2357bcf87a13e16c6998b90e
# bad: [e3692460675bfe07f677711ead09a7= a43934aa2f] pwm: Assume a disabled PWM to emit a constant inactive output
git bisect bad e3692460675bfe07f677711ead09a7a43934aa2f
= # bad: [11b0543efe54357b94dccb88dac2099c59358cd4] media: ipu6: remove archi= tecture DMA ops dependency in Kconfig
git bisect bad 11b0543efe54= 357b94dccb88dac2099c59358cd4
# bad: [6ac269abab9ca5ae910deb2d3ca5= 4351c3467e99] media: ipu6: not override the dma_ops of device in driver
git bisect bad 6ac269abab9ca5ae910deb2d3ca54351c3467e99
# = first bad commit: [6ac269abab9ca5ae910deb2d3ca54351c3467e99] media: ipu6: n= ot override the dma_ops of device in driver



=
--
Gene

--=-ATW+YCb9hWsFseu7CJ2a-- --=-Xc8d1025CSmc9deeZWxz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYJAB0WIQRByXNdQO2KDRJ2iXo5BdB0L6Ze2wUCZ1hhBAAKCRA5BdB0L6Ze 20+rAP97KbKEdNUT4x2dEC2CJCla1VPNBrE7XB17L954YKeHFQEA+apfQps2aZhO ydg+2W3peknkjwV0D4x6Hjvl13T0Fw4= =AmRv -----END PGP SIGNATURE----- --=-Xc8d1025CSmc9deeZWxz--