From: Guenter Roeck <linux@roeck-us.net>
To: Wenliang Yan <wenliang202407@163.com>,
christophe.jaillet@wanadoo.fr, jdelvare@suse.com
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
corbet@lwn.net, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] hwmon:(ina238)Add support for SQ52206
Date: Fri, 24 Jan 2025 21:01:36 -0800 [thread overview]
Message-ID: <c7c3d35a-e8a5-40ee-9b47-c22d87fa7f71@roeck-us.net> (raw)
In-Reply-To: <20250125030300.1230967-1-wenliang202407@163.com>
On 1/24/25 19:02, Wenliang Yan wrote:
> Add support for Silergy i2c power monitor SQ52206 to the ina238
> driver as those two are similar.
>
> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
> ---
>
> Add new chip SQ52206, the datasheet depends on
> https://us1.silergy.com/cloud/index/uniqid/676b659b4a503
> The password is fx6NEe.
>
> Changes in v4:
> - addressed various review comments.
> - Link to v3: https://lore.kernel.org/linux-hwmon/20250117082017.688212-1-wenliang202407@163.com/
>
Your "change logs" are equivalent to "made changes" and completely pointless.
As consequence, I'll only handle your patches if and when I have nothing else
to review since I'll have to figure out myself what you changed and if you
implemented the feedback. I don't really hve time for that, so please do not
expect that I'll apply this series anytime soon.
Guenter
> Changes in v3:
> - addressed various review comments.
> - Link to v2: https://lore.kernel.org/linux-hwmon/20250113035023.365697-1-wenliang202407@163.com/
>
> Changes in v2:
> - Explain why sq52206 compatibility has been added to ina2xx.yaml.
> - addressed various review comments
> - Link to v1: https://lore.kernel.org/linux-hwmon/20241224063559.391061-1-wenliang202407@163.com/
>
> Wenliang Yan (2):
> dt-bindings:Add SQ52206 to ina2xx devicetree bindings
> hwmon:(ina238)Add support for SQ52206
>
> .../devicetree/bindings/hwmon/ti,ina2xx.yaml | 4 +
> Documentation/hwmon/ina238.rst | 15 ++
> drivers/hwmon/ina238.c | 209 +++++++++++++++---
> 3 files changed, 195 insertions(+), 33 deletions(-)
>
next prev parent reply other threads:[~2025-01-25 5:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-25 3:02 Wenliang Yan
2025-01-25 3:02 ` [PATCH v4 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings Wenliang Yan
2025-01-25 3:03 ` [PATCH v4 2/2] hwmon:(ina238)Add support for SQ52206 Wenliang Yan
2025-01-25 5:01 ` Guenter Roeck [this message]
2025-01-25 6:44 ` [PATCH v4 0/2] " Wenliang Yan
2025-02-20 7:46 ` Wenliang Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7c3d35a-e8a5-40ee-9b47-c22d87fa7f71@roeck-us.net \
--to=linux@roeck-us.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wenliang202407@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®