From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AF9E1C5D7E for ; Tue, 11 Mar 2025 13:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741700570; cv=none; b=ua5wD4caU2zNbua6VUFAOqvyvESqD6TD8vSLieBx1zwmOE5GvHPsBWnOJQfxFxFZDZAE2Ltu2rmgrH66DMJfQUKoeOwrr9IPJLk5Epk/hkaiq0bneO0nAZdsOKsGGoeBSomha4MA4ht0FsXQ2JhWpZmLSVi9C0NuLOVBrFUkoCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741700570; c=relaxed/simple; bh=0GCrlN5KayRbpEQhJT2RkHo1RFpCIAplefLKyUYmVAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P9wMR9gxwN7FyXE6cIMXL5tK9nB8BRDRWjUdVF9JUEM2/2IKz8yY5QrCtCSPnwyvQY2w5RNXloDwMOWjOlm8/mY/YDctFgXo2AhM0XSAbM2ut6NUPTyuUuFqncpE5PA1Vnq5B0DQ62DaqKCmDxqVMcH+cOR28jZdt6uLPjf8qmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CLkpjdpS; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CLkpjdpS" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ac250d158a8so80375266b.2 for ; Tue, 11 Mar 2025 06:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741700567; x=1742305367; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=OK/mNeXOS3BnFUBUb28LMgXW4oDwAfaEiFXsceleu8s=; b=CLkpjdpSN23fhc+4xAZIImy0Df2meoaScFZ59u1Q7PwLFzOR+7Y3hyJTDZpbLjbKZ0 hyoin1eibtEAXMce2hQxxCsah3GNlz063VlitnbWS3XX9Ermu3SQ0HSAo5hw1yeUg2L9 jh8/YQFjepjK01w/GdOQpsCjGhs5XKxRfI7y+4BTNigmtAqFyZDRD06uyHmamswg0tv3 i8REnoSvv40ie+VoLULb3n9Vkjb3s1erDcDfT7LzgOo3DdZJ8OuoI61IbxmseEb8bhKk NfwHK9YYbAh9CVrDBCQ3gIk4zueh5FCgsMVzkGk/7edTsIuDEinq1OINBNn/4sI3IZo4 aMug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741700567; x=1742305367; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OK/mNeXOS3BnFUBUb28LMgXW4oDwAfaEiFXsceleu8s=; b=wQwhB0gCxxhQ3Kywr/MyHAUEwHqUTY8erMctSY8JGKELaWm4OzjPVf3V3y09ccs+sN krYmPi8PBB8JhcpvQto4sS05i0VhLhxeXWOukMMx1Mwi9YqMIg0jMgIIxqnc5+VKSpIq 6PU4em7uOujJboHmvaTxwJMKfNcbgbL9+8PU0FQ11lS3+4mB+oz1tkUxfshIpYlazCOL WhLOT3/MtvK1KzN2d7QJZozTydPo/FXdAd42zh8WBbYuSLEtKbVvhiB/5ecRJYu79UDv MM17a0jSPqlO9L5AIfcxMadI2HzLtIZXsRXu15Gfcg+BouhF6ULnDh32NGAQa7vU66Ai EUMQ== X-Forwarded-Encrypted: i=1; AJvYcCV41dkhAkwQRHI0X79LZYTh+ZGTM2rdEHKUDki9DETyRbUvk2KxeEcms4xo+PM9NnkZANsPJD1rwDTAGjo=@vger.kernel.org X-Gm-Message-State: AOJu0YzTwO0qReU8wZ2YFhQynGfJFaWjgarFToMIHY+FOBYtE7e7jgRN mu6dCn2KIBqArYRuZUx3mSu1b2Qz0FP8ZWK8XIm9H6wJdcfJUnot92ww1ZFNg/Y= X-Gm-Gg: ASbGncskmtYTuQAPTdn0SqISGb0AHEMtuzX5ncYAO5865haLvVEena9colMu5OLCV14 S6qgtgk5jJsKbqrix1uAta17oy3o3Z6p1A0VF74gfv5YEoMMc4lvjz/fYyjzih/9/G7Qfs+KHra dq6Kwq9TqPeBLuIxfEPntTBfIWV3WqILydVOgMU+y5YeOYjNWC7N63VgHrctORjEfEUjehYn5ko DIJDdOYueAeoXgVMfblW0AACPxeMaIWx+18fMqyKQzW/xbs1VmnYWylfsCAP5RI6x+X8y7Dn3b6 0EhKKfSL1zgVxfIKg+3LkdKJFD1wl2whCt1DyL2ZrW3ZkbiRuiAK4vQDrB9Ktno= X-Google-Smtp-Source: AGHT+IHtY6iWQCXAHAWxWQCwXcAH70yQ6uYRmE6uUNf099ZZ+4osiFbnrB1uJPfMgJq80ObdnKhGcw== X-Received: by 2002:a17:906:f5aa:b0:ac1:4da:3edd with SMTP id a640c23a62f3a-ac2b9db47ddmr183374666b.1.1741700566810; Tue, 11 Mar 2025 06:42:46 -0700 (PDT) Received: from [192.168.1.20] ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac256654fa6sm773804766b.93.2025.03.11.06.42.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Mar 2025 06:42:46 -0700 (PDT) Message-ID: Date: Tue, 11 Mar 2025 14:42:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 19/21] drm/msm/dpu: Implement CTL_PIPE_ACTIVE for v12.0 DPU To: Dmitry Baryshkov Cc: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Jonathan Marek , Kuogee Hsieh , Neil Armstrong , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srini Kandagatla , Rob Clark References: <20250221-b4-sm8750-display-v3-0-3ea95b1630ea@linaro.org> <20250221-b4-sm8750-display-v3-19-3ea95b1630ea@linaro.org> <5rlcxx7pcu32hz3r4qufqcq2jzk2z4g2ep7reecpm2kksttwyi@66p2u4nwfzx6> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <5rlcxx7pcu32hz3r4qufqcq2jzk2z4g2ep7reecpm2kksttwyi@66p2u4nwfzx6> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/02/2025 17:26, Dmitry Baryshkov wrote: > Minot nit below > >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c >> index 43a254cf57da571e2ec8aad38028477652f9283c..3e0bdd1100ebb0d302a852ceeaf8af86835e69a1 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c >> @@ -40,6 +40,7 @@ >> #define CTL_INTF_FLUSH 0x110 >> #define CTL_CDM_FLUSH 0x114 >> #define CTL_PERIPH_FLUSH 0x128 >> +#define CTL_PIPE_ACTIVE 0x12C > > lowercase hex, please. Ack Best regards, Krzysztof