From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: srinivas.pandruvada@linux.intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, rui.zhang@intel.com,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Amit Kucheria <amitk@kernel.org>
Subject: Re: [PATCH 3/3] thermal/drivers/intel: Use generic trip points for intel_soc_dts_iosf
Date: Thu, 2 Feb 2023 15:36:35 +0100 [thread overview]
Message-ID: <c7c7d71d-28e1-310e-2c8f-e5ae53a09f78@linaro.org> (raw)
In-Reply-To: <CAJZ5v0hFG1VjzKubWkLYPXeGHN9sMt4SDdC_f-dLseaXpsAOKg@mail.gmail.com>
Hi Rafael,
On 31/01/2023 20:17, Rafael J. Wysocki wrote:
[ ... ]
>>> Why should temp be overwritten here?
>>
>> You are correct. This is wrong.
>>
>> I think we should call get_trip_temp() before calling update_trip_temp()
>> instead of passing a zero temperature parameter
>
> update_trip_temp() is sort of a misnomer, because it is used for
> initializing a trip point for example in
> intel_soc_dts_iosf_add_read_only_critical_trip() and in this
> particular case get_trip_temp() need not be called before it.
>
> This driver seems to be in need of a cleanup.
Will you take care of this cleanup ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2023-02-02 14:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 18:16 [PATCH 1/3] thermal/drivers/intel: Use generic trip points for quark_dts Daniel Lezcano
2023-01-18 18:16 ` [PATCH 2/3] thermal/drivers/intel: Use generic trip points for processor_thermal_device_pci Daniel Lezcano
2023-01-18 19:09 ` srinivas pandruvada
2023-01-23 18:02 ` Daniel Lezcano
2023-01-23 19:31 ` srinivas pandruvada
2023-01-26 15:18 ` Rafael J. Wysocki
2023-01-18 18:16 ` [PATCH 3/3] thermal/drivers/intel: Use generic trip points for intel_soc_dts_iosf Daniel Lezcano
2023-01-19 20:04 ` Rafael J. Wysocki
2023-01-23 18:09 ` Daniel Lezcano
2023-01-23 20:19 ` Rafael J. Wysocki
2023-01-24 10:28 ` Daniel Lezcano
2023-01-24 14:09 ` Rafael J. Wysocki
2023-01-26 16:47 ` Rafael J. Wysocki
2023-01-31 17:03 ` Daniel Lezcano
2023-01-31 19:17 ` Rafael J. Wysocki
2023-02-02 14:36 ` Daniel Lezcano [this message]
2023-02-02 14:43 ` Rafael J. Wysocki
2023-02-02 15:54 ` Daniel Lezcano
2023-01-26 14:15 ` [PATCH 1/3] thermal/drivers/intel: Use generic trip points for quark_dts Rafael J. Wysocki
2023-01-31 16:41 ` Daniel Lezcano
2023-01-31 19:11 ` Rafael J. Wysocki
2023-01-31 23:55 ` Daniel Lezcano
2023-02-01 10:42 ` Daniel Lezcano
2023-02-01 18:47 ` Rafael J. Wysocki
2023-02-01 19:27 ` Daniel Lezcano
2023-02-02 10:32 ` Rafael J. Wysocki
2023-02-02 13:31 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7c7d71d-28e1-310e-2c8f-e5ae53a09f78@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®