From: Andrew Lunn <andrew@lunn.ch>
To: Jianhui Zhao <zhaojh329@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH] net: mdio: fix duplicate registrations for phy with c45 in __of_mdiobus_register()
Date: Sun, 11 Jun 2023 17:11:58 +0200 [thread overview]
Message-ID: <c7ca97c3-720b-494c-9865-b77252954a04@lunn.ch> (raw)
In-Reply-To: <20230611145728.655524-1-zhaojh329@gmail.com>
On Sun, Jun 11, 2023 at 10:57:28PM +0800, Jianhui Zhao wrote:
> Sorry, I misread the code.
So this is by code inspection, not an actual device tree booting on a
board?
What should happen is that __of_mdiobus_register() has:
/* Mask out all PHYs from auto probing. Instead the PHYs listed in
* the device tree are populated after the bus has been registered */
mdio->phy_mask = ~0;
So when
rc = __mdiobus_register(mdio, owner);
is called, no scanning happens. I _guess_ that is what you missed?
Andrew
--
pw-bot: reject
prev parent reply other threads:[~2023-06-11 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 16:13 Jianhui Zhao
2023-06-10 17:10 ` Andrew Lunn
2023-06-11 8:58 ` Jianhui Zhao
2023-06-11 14:57 ` Jianhui Zhao
2023-06-11 15:11 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7ca97c3-720b-494c-9865-b77252954a04@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhaojh329@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®