mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Will Deacon' <will.deacon@arm.com>, Andy Lutomirski <luto@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Alan Cox <alan@linux.intel.com>,
	"the arch/x86 maintainers" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	Jann Horn <jannh@google.com>,
	Samuel Neves <samuel.c.p.neves@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Kernel Hardening <kernel-hardening@lists.openwall.com>,
	Borislav Petkov <bp@alien8.de>
Subject: RE: [PATCH] x86/retpoline/entry: Disable the entire SYSCALL64 fast path with retpolines on
Date: Mon, 29 Jan 2018 15:23:39 +0000	[thread overview]
Message-ID: <c7d092ebc21e4aedbefa9bce58dcfed4@AcuMS.aculab.com> (raw)
In-Reply-To: <20180129131942.GC25549@arm.com>

From: Will Deacon
> Sent: 29 January 2018 13:20
...
> Another issue with this style of macro definition exists on architectures
> where the calling convention needs you to carry state around depending on
> how you packed the previous parameters. For example, on 32-bit ARM, 64-bit
> values are passed in adjacent pairs of registers but the low numbered
> register needs to be even. This is what stopped me from trying to use
> existing helpers such as syscall_get_arguments to unpack the pt_regs
> and it generally means that anything that says "get me argument n" is going
> to require constructing arguments 0..n-1 first.
> 
> To do this properly I think we'll either need to pass back the size and
> current register offset to the arch code, or just allow the thing to be
> overridden per syscall (the case above isn't especially frequent).

If you generate a structure from the argument list that might work
'by magic'.
Certainly you can add explicit pads to any structure.

	David

	

      reply	other threads:[~2018-01-29 15:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 18:04 Andy Lutomirski
2018-01-22 18:55 ` Linus Torvalds
2018-01-23  8:01   ` Ingo Molnar
2018-01-23 18:36   ` Alan Cox
2018-01-25 18:48   ` Linus Torvalds
2018-01-25 19:16     ` [kernel-hardening] " Linus Torvalds
2018-01-25 20:04       ` Brian Gerst
2018-01-25 20:54         ` Linus Torvalds
2018-01-25 21:02     ` Andy Lutomirski
2018-01-25 21:05       ` Thomas Gleixner
2018-01-25 21:06       ` Linus Torvalds
2018-01-25 21:08         ` Andy Lutomirski
2018-01-25 21:20           ` Linus Torvalds
2018-01-25 21:31             ` Andy Lutomirski
2018-01-25 21:39               ` Dan Williams
2018-01-25 21:53                 ` Andy Lutomirski
2018-01-25 21:53                 ` Linus Torvalds
2018-01-26 11:17               ` David Laight
2018-01-26 14:24                 ` Alan Cox
2018-01-26 15:57                   ` Andy Lutomirski
2018-01-26 17:40                     ` Linus Torvalds
2018-01-26 18:07                       ` Al Viro
2018-01-26 18:13                         ` Linus Torvalds
2018-01-26 18:23                           ` Andy Lutomirski
2018-01-26 18:54                             ` Linus Torvalds
2018-01-26 19:02                               ` Andy Lutomirski
2018-01-29 13:19                             ` Will Deacon
2018-01-29 15:23                               ` David Laight [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7d092ebc21e4aedbefa9bce58dcfed4@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=alan@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jannh@google.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=samuel.c.p.neves@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome