From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 993C746BF for ; Mon, 16 Feb 2026 12:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771246069; cv=none; b=WPsYvcZA3P5TcZ+c99OCf5szFa41LZSxvfyI3/2AUox5MGyQe5DQu5qPDH/vorxOGgEh6oa1MwqItgs/FWsl0cRa5KhV7jKUTT4mSe1VY3t3U3sftqEx2GBFWp0mYD2BONsJwlyUzauxT7jK8w+/+50bteqe31k/lSwLA9T7DZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771246069; c=relaxed/simple; bh=hLvQ2ERd9gaad2BIlid9VmD1bXRObowTgF0ZLINfYCQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jhd3Mz9RJJSbSiIYrQcBHh3Vh9icnFKDRwkgxOkgXomrsncLur0e/bbZ8pnb3ygKUf4ZpKeuJnCw3oeV3oHf5V7EIoIFMuOH8X4F9ycPyOrc43Z7xYtijNRei2pszIO+MvejarcNYbfwtZDMV+mgn2yIJT9rpfFUk/pl+2gc7/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=bJqBM2LS; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=F885Iawp; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=bJqBM2LS; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=F885Iawp; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bJqBM2LS"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="F885Iawp"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bJqBM2LS"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="F885Iawp" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0412A5BDB1; Mon, 16 Feb 2026 12:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771246067; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h5vL66G5r6q57v/fzbHm93pmfk64WqufQIyPieTKSWw=; b=bJqBM2LSCiMvlDbT4R0jjTZwanCMcbQkVb7msKaqgImsrMKyBcpzoGz7qUU+v8YE93rDzu LlwXuNkLHkN41tmhtxQj4SeQufN5nB0HB8s4297YeHheCqlpnECACoLuy9oRJtyDvZ8uEy pwGSMAaSXV+bSIA8rwM1u1uYnZm+tMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771246067; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h5vL66G5r6q57v/fzbHm93pmfk64WqufQIyPieTKSWw=; b=F885IawpfySBCgnXC8ms+FsUcGFZKGEEyPZ0FLtHIl4pWsN5GHlGzXUKlfhvX3LFLJSPKr cc+Pg4tTv0IH2PDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bJqBM2LS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=F885Iawp DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771246067; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h5vL66G5r6q57v/fzbHm93pmfk64WqufQIyPieTKSWw=; b=bJqBM2LSCiMvlDbT4R0jjTZwanCMcbQkVb7msKaqgImsrMKyBcpzoGz7qUU+v8YE93rDzu LlwXuNkLHkN41tmhtxQj4SeQufN5nB0HB8s4297YeHheCqlpnECACoLuy9oRJtyDvZ8uEy pwGSMAaSXV+bSIA8rwM1u1uYnZm+tMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771246067; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h5vL66G5r6q57v/fzbHm93pmfk64WqufQIyPieTKSWw=; b=F885IawpfySBCgnXC8ms+FsUcGFZKGEEyPZ0FLtHIl4pWsN5GHlGzXUKlfhvX3LFLJSPKr cc+Pg4tTv0IH2PDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B967C3EA62; Mon, 16 Feb 2026 12:47:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id lfoJJPIRk2nUQgAAD6G6ig (envelope-from ); Mon, 16 Feb 2026 12:47:46 +0000 Message-ID: Date: Mon, 16 Feb 2026 13:47:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/21] nvme-rdma: Use CCR to recover controller that hits an error To: Mohamed Khalfella , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260214042753.4073668-1-mkhalfella@purestorage.com> <20260214042753.4073668-12-mkhalfella@purestorage.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260214042753.4073668-12-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[purestorage.com,broadcom.com,gmail.com,nvidia.com,lst.de,kernel.dk,kernel.org,grimberg.me]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,purestorage.com:email] X-Spam-Flag: NO X-Spam-Score: -4.51 X-Rspamd-Queue-Id: 0412A5BDB1 X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: On 2/14/26 05:25, Mohamed Khalfella wrote: > An alive nvme controller that hits an error now will move to FENCING > state instead of RESETTING state. ctrl->fencing_work attempts CCR to > terminate inflight IOs. Regardless of the success or failure of CCR > operation the controller is transitioned to RESETTING state to continue > error recovery process. > > Signed-off-by: Mohamed Khalfella > --- > drivers/nvme/host/rdma.c | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich