From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Guodong Liu <guodong.liu@mediatek.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@kernel.org>
Cc: Sean Wang <sean.wang@mediatek.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v1 2/2] pinctrl: add pinctrl driver on mt8186
Date: Mon, 10 Jan 2022 11:09:04 +0100 [thread overview]
Message-ID: <c7d7fbe3-1fe2-8765-5577-b4b06cebe9b6@collabora.com> (raw)
In-Reply-To: <20220110073111.31306-2-guodong.liu@mediatek.com>
Il 10/01/22 08:31, Guodong Liu ha scritto:
> This commit includes pinctrl driver for mt8186.
>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
> ---
> drivers/pinctrl/mediatek/Kconfig | 6 +
> drivers/pinctrl/mediatek/Makefile | 1 +
> drivers/pinctrl/mediatek/pinctrl-mt8186.c | 1313 ++++++++++
> drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h | 2186 +++++++++++++++++
> 4 files changed, 3506 insertions(+)
> create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8186.c
> create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h
>
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index 66db4ac5d169..2cb5963cef4c 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -147,6 +147,12 @@ config PINCTRL_MT8183
> default ARM64 && ARCH_MEDIATEK
> select PINCTRL_MTK_PARIS
>
> +config PINCTRL_MT8186
> + bool "Mediatek MT8186 pin control"
> + depends on OF
> + depends on ARM64 || COMPILE_TEST
Like the other MTK pinctrl drivers, please add:
default ARM64 && ARCH_MEDIATEK
With that fixed,
Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> + select PINCTRL_MTK_PARIS
> +
> config PINCTRL_MT8192
> bool "Mediatek MT8192 pin control"
> depends on OF
> diff --git a/drivers/pinctrl/mediatek/Makefile b/drivers/pinctrl/mediatek/Makefile
> index 1e3931d924e7..29018d6ad0de 100644
> --- a/drivers/pinctrl/mediatek/Makefile
> +++ b/drivers/pinctrl/mediatek/Makefile
> @@ -21,6 +21,7 @@ obj-$(CONFIG_PINCTRL_MT7986) += pinctrl-mt7986.o
> obj-$(CONFIG_PINCTRL_MT8167) += pinctrl-mt8167.o
> obj-$(CONFIG_PINCTRL_MT8173) += pinctrl-mt8173.o
> obj-$(CONFIG_PINCTRL_MT8183) += pinctrl-mt8183.o
> +obj-$(CONFIG_PINCTRL_MT8186) += pinctrl-mt8186.o
> obj-$(CONFIG_PINCTRL_MT8192) += pinctrl-mt8192.o
> obj-$(CONFIG_PINCTRL_MT8195) += pinctrl-mt8195.o
> obj-$(CONFIG_PINCTRL_MT8365) += pinctrl-mt8365.o
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8186.c b/drivers/pinctrl/mediatek/pinctrl-mt8186.c
> new file mode 100644
> index 000000000000..1e550b15b9d4
> --- /dev/null
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt8186.c
> @@ -0,0 +1,1313 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
prev parent reply other threads:[~2022-01-10 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 7:31 [PATCH v1 1/2] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document Guodong Liu
2022-01-10 7:31 ` [PATCH v1 2/2] pinctrl: add pinctrl driver on mt8186 Guodong Liu
2022-01-10 10:09 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7d7fbe3-1fe2-8765-5577-b4b06cebe9b6@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=guodong.liu@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®