From: Dan Carpenter <dan.carpenter@linaro.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Takahiro Kuwano <Takahiro.Kuwano@infineon.com>,
kernel@collabora.com, kernel-janitors@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: core: correct type of i to be signed
Date: Fri, 1 Mar 2024 20:01:36 +0300 [thread overview]
Message-ID: <c7db3fa0-d5a2-43aa-8038-0a722f2b8f26@moroto.mountain> (raw)
In-Reply-To: <20240301144517.2811370-1-usama.anjum@collabora.com>
On Fri, Mar 01, 2024 at 07:45:16PM +0500, Muhammad Usama Anjum wrote:
> The i should be signed to find out the end of the loop. Otherwise,
> i >= 0 is always true and loop becomes infinite.
>
> Fixes: 6a9eda34418f ("mtd: spi-nor: core: set mtd->eraseregions for non-uniform erase map")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/mtd/spi-nor/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 65b32ea59afc6..46bc45b80883f 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3373,7 +3373,7 @@ static u32
> spi_nor_get_region_erasesize(const struct spi_nor_erase_region *region,
> const struct spi_nor_erase_type *erase_type)
> {
> - u8 i;
> + s8 i;
I have a patch in my output which also addresses this bug but you beat
me to the punch. Declaring iterators as "u8 i;" is a canonical bug.
https://staticthinking.wordpress.com/2022/06/01/unsigned-int-i-is-stupid/
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-01 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 14:45 Muhammad Usama Anjum
2024-03-01 15:04 ` Michael Walle
2024-03-04 7:51 ` Tudor Ambarus
2024-03-04 8:46 ` Muhammad Usama Anjum
2024-03-04 8:47 ` Tudor Ambarus
2024-03-01 17:01 ` Dan Carpenter [this message]
2024-03-04 10:21 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7db3fa0-d5a2-43aa-8038-0a722f2b8f26@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=Takahiro.Kuwano@infineon.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=usama.anjum@collabora.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®