From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC84AC04AB6 for ; Fri, 31 May 2019 20:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB41B26E4B for ; Fri, 31 May 2019 20:38:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbfEaUi3 (ORCPT ); Fri, 31 May 2019 16:38:29 -0400 Received: from smtprelay0203.hostedemail.com ([216.40.44.203]:58745 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727576AbfEaUi0 (ORCPT ); Fri, 31 May 2019 16:38:26 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 764EC3D05; Fri, 31 May 2019 20:38:24 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: price00_f062e7ab5c2e X-Filterd-Recvd-Size: 1735 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA; Fri, 31 May 2019 20:38:23 +0000 (UTC) Message-ID: Subject: Re: [PATCH] btrfs: Fix -Wunused-but-set-variable warnings From: Joe Perches To: Andrey Abramov , "clm@fb.com" , "josef@toxicpanda.com" , "dsterba@suse.com" Cc: "linux-btrfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Fri, 31 May 2019 13:38:22 -0700 In-Reply-To: <14843931559334698@myt6-add70abb4f02.qloud-c.yandex.net> References: <20190531195349.31129-1-st5pub@yandex.ru> <14843931559334698@myt6-add70abb4f02.qloud-c.yandex.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-05-31 at 23:31 +0300, Andrey Abramov wrote: > 31.05.2019, 23:05, "Joe Perches" : > > On Fri, 2019-05-31 at 22:53 +0300, Andrey Abramov wrote: > > > Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files > > These uses seem boolean, so perhaps just use bool? > I used int because you use ints (as bools) everywhere (for example > there is only one bool (as a function argument) in the entire raid56.c > file with 3000 lines of code), so with int code looks more consistent. > Are you sure that I should use bool? That's up to you and the btrfs maintainers.