From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07CDCC04AAC for ; Mon, 6 May 2019 07:29:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D89192082F for ; Mon, 6 May 2019 07:29:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbfEFH3X (ORCPT ); Mon, 6 May 2019 03:29:23 -0400 Received: from mga04.intel.com ([192.55.52.120]:25096 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbfEFH3W (ORCPT ); Mon, 6 May 2019 03:29:22 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 00:24:20 -0700 X-ExtLoop1: 1 Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.198]) ([10.237.72.198]) by orsmga002.jf.intel.com with ESMTP; 06 May 2019 00:24:15 -0700 Subject: Re: [PATCH] mmc: block: Fix memory leak in blk-mq when cleaning up To: Douglas Anderson , Ulf Hansson , Linus Walleij Cc: linux-rockchip@lists.infradead.org, groeck@chromium.org, mka@chromium.org, drinkcat@chromium.org, Ming Lei , linux-mmc@vger.kernel.org, Hannes Reinecke , linux-kernel@vger.kernel.org, Jens Axboe , Omar Sandoval References: <20190503233526.226272-1-dianders@chromium.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Mon, 6 May 2019 10:22:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190503233526.226272-1-dianders@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/05/19 2:35 AM, Douglas Anderson wrote: > If I run the following on rk3288-veyron-minnie (a 2GB machine) > > cd /sys/bus/platform/drivers/dwmmc_rockchip > for i in $(seq 1 3000); do > echo "========================" $i > echo ff0f0000.dwmmc > unbind > sleep .5 > echo ff0f0000.dwmmc > bind > while true; do > if [ -e /dev/mmcblk2 ]; then > break; > fi > sleep .1 > done > done > > Then I start OOMing somewhere between iteration 200 and 250. Using > kmemleak, I see reports like: > > unreferenced object 0xe39c5580 (size 64): > comm "kworker/1:0", pid 17, jiffies 4294821091 (age 96.952s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] __kmalloc+0x1ec/0x2dc > [] blk_mq_alloc_tag_set+0x27c/0x2bc > [<0955ae01>] mmc_init_queue+0xa8/0x2a8 > [<5102b986>] mmc_blk_alloc_req+0xf8/0x2d4 > [] mmc_blk_probe+0x4a8/0x6c0 > [<0dfdd9d5>] mmc_bus_probe+0x24/0x28 > > It's pretty clear that we're missing a call to blk_mq_free_tag_set(). > Let's add it. > > Fixes: 81196976ed94 ("mmc: block: Add blk-mq support") > Signed-off-by: Douglas Anderson Same as: https://lore.kernel.org/lkml/20190502190714.181664-1-rrangel@chromium.org/ > --- > > drivers/mmc/core/queue.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > index 7c364a9c4eeb..09071e13282e 100644 > --- a/drivers/mmc/core/queue.c > +++ b/drivers/mmc/core/queue.c > @@ -480,6 +480,8 @@ void mmc_cleanup_queue(struct mmc_queue *mq) > */ > flush_work(&mq->complete_work); > > + blk_mq_free_tag_set(&mq->tag_set); > + > mq->card = NULL; > } > >