From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD3761F76B5 for ; Wed, 22 Jan 2025 10:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737540564; cv=none; b=Er9aACMLjdf+qV/EWl1IZZ7F3qRGtvTziC4+tYnVMq1OY8yZZUmmnG1c3/PyqIOOdMX8Xtxd+fSMM8D5oBUdHyBvUZMaKKP75UwJ4t2mVOHA11PV2B6SbOGP8R3WJYVpxdvJhU4Fh/pkhKaA2h+4o3QfYAGSJNqvTs0e8UmooF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737540564; c=relaxed/simple; bh=yPq21HhdpDlsS14IAW4zQa5skvQJ+MdKpDAy9He2FlU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=flmDYJbxD7xUQeliYospe0pVcAR+VVRPKD1A83zXkw4uE2d7p19ATcs+U8LFRqxVK7RgUvnKE8wwuHwowVsjfFGj2abkK9hp3rbGBfKCi6sVaNr4JiD9znv0oeC/8ApH+CdG/uSYVEJ3rr1m7ZcUJx3IHnw6Wth14gqkZ1ZPMiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=KFzA9LSz; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="KFzA9LSz" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5d3f57582a2so1521141a12.1 for ; Wed, 22 Jan 2025 02:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1737540560; x=1738145360; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wEJEd8faAZ8pH7yQQA5pi8eTwG/AqywjNq66uj965H8=; b=KFzA9LSzGHuyRlka6fwEMjxvVr3860d2TvLHD90/5cziuFiBS3V4zt60ktvNZBH6w6 5CR8OsOR2D8FKMfWQYTsNgmNjUDaqUmbnQooxqXCsDS6dreovqO8xx9eLxwYdpIEQxdv 26EfRSIjj5EfghdyxOV1ZfUgNgWrtOkuyocInLGEaHP4802Iw6SuUoxqMnfVbMwr6ol1 cjd96EjmGUu0n3TXrczLwWmzaHlbHouFSUjjLAEE12BRXv3PLU9oE6sfdfDVsquJTpmX fbRgp36E8aDXedMkE/kkNjigbNzLV0hI7Qo6X1T+mPhOfklnROmQvDWpnmfBaJKcdDC7 VzwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737540560; x=1738145360; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wEJEd8faAZ8pH7yQQA5pi8eTwG/AqywjNq66uj965H8=; b=H6kSoyuId93LyI/NqgOzujBPK0hZhtbA85+Ua2ywjMbS7GP0Scfst6Vhzc9LtrP5U4 gSAw8Jm9o2hCDB9aZurdxugrldTqCloduIwvtQk/7FpVXafLZCDmhc7rRSwhjw82cK2/ yhdW0z6OHjYTPp/5TecF1/J7ZguTuzdLEDnmyy/q7lwSQn6ljud5w5wPan7TCDwYQbVK 9n+30a2d0tEx1X2pP4bUPkqJAdSujIp1KQEg5fMDuqClIapqXFTn6DKutqghsC4crje2 t8uL9fqxIZmZ2/6ODaLwra1FR9FWHcl9GcVKC58AD5/rPa1zA4N8uU2XTiThqv2d7hnp 4Ixw== X-Forwarded-Encrypted: i=1; AJvYcCX1Qu7SVfMGf+dcjiHYJ1xOukwcWpQB0qVVGDaWstRYxvUnNfECDQSH+RYj6R0iT5XtyyvEXmXDcNtlh9I=@vger.kernel.org X-Gm-Message-State: AOJu0YygYvt3MfPPlHYKOfIAQneai7rz/ZYOGTIT9tk5ubX4KEEX7SzQ 4BpJz1g56MCOU9mhAhft7eNNiriN1urLd67avi3Ulih6CtUauoivIJfYshQra98= X-Gm-Gg: ASbGncskSL0srevknjTrVYQoWt8ftJRuooWRCGqpsze4Y2o2e7J7TKydiQ5Jf9xU2Bq sCPQm5DO58jHQS147wtwRCZhEjUxw4mmX9xn6aZ+kKfgPKxYyTnG0ZNjcXy46/GDMS0KvUbb+G7 rvQmkMh505CFu/hEXQ1riVllH4iNdP5l90kPgMporsPOdcUr6J7hk4YUc5Kct+XewJeiYvr+sxK R2mllssGq/l9+Crh/kgpi6H9Apw0qdS0Wx8rIo/j8bbce0GpzKvH9+ji1umi/ICMu1Xd9dlYZyt vg== X-Google-Smtp-Source: AGHT+IFVRPmudokZEYxl+UG1fyhtE2C6e0Eu/TY6D7Z3irDR1ZjFtdV9zGTdFMCb5huVLQghs03L8g== X-Received: by 2002:a17:906:f596:b0:ab3:47cb:5327 with SMTP id a640c23a62f3a-ab36e19cff2mr2054334566b.5.1737540559995; Wed, 22 Jan 2025 02:09:19 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.35]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384ce1f71sm893158566b.61.2025.01.22.02.09.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jan 2025 02:09:19 -0800 (PST) Message-ID: Date: Wed, 22 Jan 2025 12:09:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/4] serial: sh-sci: Update the suspend/resume support To: Krzysztof Kozlowski , geert+renesas@glider.be, magnus.damm@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, p.zabel@pengutronix.de, claudiu.beznea.uj@bp.renesas.com, wsa+renesas@sang-engineering.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20250120130936.1080069-1-claudiu.beznea.uj@bp.renesas.com> <20250120130936.1080069-2-claudiu.beznea.uj@bp.renesas.com> <04fde244-006f-4bda-9d65-7957be74f049@kernel.org> From: Claudiu Beznea Content-Language: en-US In-Reply-To: <04fde244-006f-4bda-9d65-7957be74f049@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21.01.2025 10:54, Krzysztof Kozlowski wrote: > On 20/01/2025 14:09, Claudiu wrote: >> From: Claudiu Beznea >> >> The Renesas RZ/G3S supports a power saving mode where power to most of the >> SoC components is turned off. When returning from this power saving mode, >> SoC components need to be re-configured. >> >> The SCIFs on the Renesas RZ/G3S need to be re-configured as well when >> returning from this power saving mode. The sh-sci code already configures >> the SCIF clocks, power domain and registers by calling uart_resume_port() >> in sci_resume(). On suspend path the SCIF UART ports are suspended >> accordingly (by calling uart_suspend_port() in sci_suspend()). The only >> missing setting is the reset signal. For this assert/de-assert the reset >> signal on driver suspend/resume. >> >> In case the no_console_suspend is specified by the user, the registers need >> to be saved on suspend path and restore on resume path. To do this the >> sci_console_setup() function was added. There is no need to cache/restore >> the status or FIFO registers. Only the control registers. To differentiate >> b/w these, the struct sci_port_params::regs was updated with a new member >> that specifies if the register needs to be chached on suspend. Only the >> RZ_SCIFA instances were updated with this new support as the hardware for >> the rest of variants was missing for testing. >> >> Signed-off-by: Claudiu Beznea >> --- >> >> Changes in v4: >> - none > > > Why are you combining serial patches with DTS? Greg applies entire set > thus you *cannot* send him DTS. It's v4. The initial set contained fixes for serial, support for RZ/G3S (including clocks and dtsi), all that was needed for the enabled RZ/G3S serial IPs. Fixes were posted separately (as requested), the other bringup patches were integrated and this is what remained. I chose it like this for version continuity. Thank you, Claudiu > > Best regards, > Krzysztof