From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751135AbdHZSqU (ORCPT ); Sat, 26 Aug 2017 14:46:20 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34158 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbdHZSqS (ORCPT ); Sat, 26 Aug 2017 14:46:18 -0400 Subject: Re: [PATCH] iommu/mediatek: Fix a build fail of m4u_type From: Matthias Brugger To: Yong Wu , Joerg Roedel Cc: Robin Murphy , Will Deacon , Daniel Kurtz , Tomasz Figa , Rob Herring , Catalin Marinas , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, arnd@arndb.de, honghui.zhang@mediatek.com References: <1503552249-22060-1-git-send-email-yong.wu@mediatek.com> Message-ID: Date: Sat, 26 Aug 2017 21:46:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/26/2017 09:33 PM, Matthias Brugger wrote: > > > On 08/24/2017 08:24 AM, Yong Wu wrote: >> The commit ("iommu/mediatek: Enlarge the validate PA range >> for 4GB mode") introduce the following build error: >> >> drivers/iommu/mtk_iommu.c: In function 'mtk_iommu_hw_init': >>>> drivers/iommu/mtk_iommu.c:536:30: error: 'const struct mtk_iommu_data' >> has no member named 'm4u_type'; did you mean 'm4u_dom'? >> if (data->enable_4GB && data->m4u_type != M4U_MT8173) { >> >> This patch fix it, use "m4u_plat" instead of "m4u_type". >> >> Reported-by: kernel test robot >> Signed-off-by: Yong Wu >> --- >> 1) In the v2 of mt2712 iommu support patch-set, We changed a variant >> name from "m4u_type" to "m4u_plat", But I'm sorry that I forgot to >> change it in the later patch. >> 2) This patch is based on [1]. >> [1]:https://lists.linuxfoundation.org/pipermail/iommu/2017-August/023847.html >> 3) I cann't find the commit id of the patch ("iommu/mediatek: Enlarge >> the validate PA range for 4GB mode") in the [2]. >> So I don't write the commit id for that patch in the commit message. >> [2]https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next > > Because the kernel test robot took the patch from the mailinglist. Please fold > this fix into v3 of the series. > Please ignore this message, I didn't realize that the driver was already queued by Joerg. Regards, Matthias