From: Krzysztof Kozlowski <krzk@kernel.org>
To: Huangzheng Lai <Huangzheng.Lai@unisoc.com>,
Andi Shyti <andi.shyti@kernel.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
huangzheng lai <laihuangzheng@gmail.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Subject: Re: [PATCH V2 3/7] i2c: sprd: Use global variables to record I2C ack/nack status instead of local variables
Date: Fri, 3 Nov 2023 12:59:45 +0100 [thread overview]
Message-ID: <c7eb2642-93ed-46b6-a189-18111bed5435@kernel.org> (raw)
In-Reply-To: <20231023081158.10654-4-Huangzheng.Lai@unisoc.com>
On 23/10/2023 10:11, Huangzheng Lai wrote:
> We found that when the interrupt bit of the I2C controller is cleared,
> the ack/nack bit is also cleared at the same time. After clearing the
> interrupt bit in sprd_i2c_isr(), incorrect ack/nack information will be
> obtained in sprd_i2c_isr_thread(), resulting in incorrect communication
> when nack cannot be recognized. To solve this problem, we used a global
> variable to record ack/nack information before clearing the interrupt
> bit instead of a local variable.
>
> Fixes: 8b9ec0719834 ("i2c: Add Spreadtrum I2C controller driver")
> Cc: <stable@vger.kernel.org> # v4.14+
> Signed-off-by: Huangzheng Lai <Huangzheng.Lai@unisoc.com>
Fixes must be send independent of features.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-03 11:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 8:11 [PATCH V2 0/7] i2c: sprd: Modification of UNISOC Platform I2C Driver Huangzheng Lai
2023-10-23 8:11 ` [PATCH V2 1/7] i2c: sprd: Add configurations that support 1Mhz and 3.4Mhz frequencies Huangzheng Lai
2023-10-23 11:19 ` Baolin Wang
2023-10-24 20:45 ` Andi Shyti
2023-10-23 8:11 ` [PATCH V2 2/7] i2c: sprd: Add I2C driver to use 'reset framework' function Huangzheng Lai
2023-10-23 11:27 ` Baolin Wang
2023-11-03 11:59 ` Krzysztof Kozlowski
2023-10-23 8:11 ` [PATCH V2 3/7] i2c: sprd: Use global variables to record I2C ack/nack status instead of local variables Huangzheng Lai
2023-10-23 11:32 ` Baolin Wang
2023-11-06 3:01 ` huangzheng lai
2023-10-24 21:20 ` Andi Shyti
2023-11-06 9:02 ` huangzheng lai
2023-11-03 11:59 ` Krzysztof Kozlowski [this message]
2023-10-23 8:11 ` [PATCH V2 4/7] i2c: sprd: Add I2C controller driver to support dynamic switching of 400K/1M/3.4M frequency Huangzheng Lai
2023-10-23 11:37 ` Baolin Wang
2023-10-24 21:28 ` Andi Shyti
2023-10-23 8:11 ` [PATCH V2 5/7] i2c: sprd: Configure the enable bit of the I2C controller before each transmission initiation Huangzheng Lai
2023-10-24 21:35 ` Andi Shyti
2023-10-23 8:11 ` [PATCH V2 6/7] i2c: sprd: Increase the waiting time for I2C transmission to avoid system crash issues Huangzheng Lai
2023-10-23 11:39 ` Baolin Wang
2023-10-24 21:38 ` Andi Shyti
2023-10-23 8:11 ` [PATCH V2 7/7] i2c: sprd: Add I2C_NACK_EN and I2C_TRANS_EN control bits Huangzheng Lai
2023-10-23 11:43 ` Baolin Wang
2023-10-23 11:44 ` [PATCH V2 0/7] i2c: sprd: Modification of UNISOC Platform I2C Driver Baolin Wang
2023-10-24 21:40 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-09-21 8:54 Huangzheng Lai
2023-09-21 8:54 ` [PATCH V2 3/7] i2c: sprd: Use global variables to record I2C ack/nack status instead of local variables Huangzheng Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7eb2642-93ed-46b6-a189-18111bed5435@kernel.org \
--to=krzk@kernel.org \
--cc=Huangzheng.Lai@unisoc.com \
--cc=andi.shyti@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=laihuangzheng@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®