From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932434AbdJZRJe (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Oct 2017 13:09:34 -0400
Received: from mout.web.de ([212.227.17.11]:59283 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932127AbdJZRJb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Oct 2017 13:09:31 -0400
Subject: Re: iio/accel/stk8ba50: Use common error handling code in
 stk8ba50_probe()
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Tiberiu Breana <tiberiu.a.breana@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <5ab7e200-2dea-63e2-06db-0e185f563d16@users.sourceforge.net>
 <0f26a13b-7bbf-525b-a864-8aa8e13c3aef@users.sourceforge.net>
 <20171026174200.5c00b06d@archlinux>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <c7ee7221-3feb-1e6c-5e57-abec8c350330@users.sourceforge.net>
Date: Thu, 26 Oct 2017 19:09:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171026174200.5c00b06d@archlinux>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:rSX5n18P1T5s4i6LTqwE7mW1YNui3aHuOIzoKpQdQj9V/iv/PyE
 xgVMnInYxkZTcILXZXewnFm8V/flCEW+H6c0RAPqQRvdgbmWrzsPUThNGlEQyQI7L5S8vZj
 DIe0wYGVPNbQrmXahmmVcx5oYx+eua7+MC8nYebTE4muIeq2+s1a67cPfc501LH7wt01U9l
 tXjzb1LK3yP7ajjf2W1Fg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:WTr/VXyAcMs=:V1DVNUWtBpEMyiQ3PRLfKz
 opRDUgu0zf7FT9A1rSdrbCysWY20O0bKtztwj8yGC6pzQlbWQGmo+ELFWZEyMdUCqiyXKBhzC
 gPbzTu4URzNfFr7LyzOZ6ZVUHhWtWTjvKtUWCgP1Suangft+4stFlz18P+5bsNpkWmyyQb3/a
 8PiQw9iiE2UdWEY+hctigrMRj0zz0zm+ejDaX0JG0DmxXwl62GXV1rjSXn7ifjqlu+tpuTCqr
 6zb8lfqV4KqauU5VW7HezL1uypFCIN0vWLd5lhNokUFfgMhVyJ6DPDDGZMXip1bwKKBmFRivz
 zxiifEf6Tvp2FKh4dJZM/N/8q9ymu5IanpW6vc0CjVxYJ7AgrSrScNJwa2GRYgKNEdHTEmWUP
 soxKzLWRad4ezEYNjpd90Srq1HArkaedSCYdEgFjk/2u3PrKFHFrYAE0HAC+Rk6Qsfp99QUUC
 ms/4pyoilRQnebjtDWZEqOLFg8tovXBrUEbw/LhWvefleXTabqbN5W+eyjui7sk3SIIY25W1z
 jYatLvW4xKx9/jBggj7Ha4yUrv8e/GK25eSpAzmV9n6457SNV1dR2uVusmi8goGrxntkB3WT8
 xPE8xQ+JXNUt+A+xCFg6u4I3pThGmQarC2pGaWRtu4sY3hnqfCTYKzRrHAZE6sIlToqVHpoby
 Mn/0DghYzdpQIPBN9uB67aJOu5/FrVnL3OJNngcAgCl8maTq7+BY2VYkCu1rEnNSU026AkcKb
 +xTf8vVT/5UCnh/dppEOlT7fFrK7JD+ssYyFktV+l5zCmO+oPrbIOZBhZODwcYDDWuG0jUY35
 UkmGT5MR2LwiPPdYuyusX7Tc7xDF/hwAAs7fdyqOQHs09e3QIo=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Again, a general kernel development rule is to float only one
> patch of a given type until you have had feedback on it.

Some update suggestions according also to this general source code
transformation pattern were already integrated in other software areas.


> These backwards goto cases are sufficiently different from your earlier
> patch that got reviews that,

They are required if you would ever like to support software refactorings
in directions which I propose occasionally.


> at most, you should have sent one to the list and then given time
> for it to be properly reviewed (up to a week on IIO list typically).

Did I present my ideas a bit too quick in this case?

Regards,
Markus