From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Pravin Shelar <pshelar@ovn.org>, Matteo Croce <mcroce@redhat.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
ovs dev <dev@openvswitch.org>,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Bindiya Kurle <bindiyakurle@gmail.com>,
Simon Horman <simon.horman@netronome.com>,
Ben Pfaff <blp@ovn.org>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next v3] openvswitch: add TTL decrement action
Date: Thu, 16 Jan 2020 14:38:55 +0100 [thread overview]
Message-ID: <c7f288b2-dd07-f43a-48c9-ce6086137322@6wind.com> (raw)
In-Reply-To: <CAOrHB_D_zM+rceB9U3O_0GbGQW3KUouE-==haQf7MZUJm5p4wg@mail.gmail.com>
Le 16/01/2020 à 08:21, Pravin Shelar a écrit :
> On Wed, Jan 15, 2020 at 8:40 AM Matteo Croce <mcroce@redhat.com> wrote:
[snip]
>> @@ -1050,4 +1051,5 @@ struct ovs_zone_limit {
>> __u32 count;
>> };
>>
>> +#define OVS_DEC_TTL_ATTR_EXEC 0
>
> I am not sure if we need this, But if you want the nested attribute
> then lets define enum with this single attribute and have actions as
> part of its data. This would be optional argument, so userspace can
> skip it, and in that case datapath can drop the packet.
And note that 0 is a reserved value and should not be used. Look at other
attributes.
Regards,
Nicolas
prev parent reply other threads:[~2020-01-16 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 16:40 Matteo Croce
2020-01-16 7:21 ` Pravin Shelar
2020-01-16 13:38 ` Nicolas Dichtel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f288b2-dd07-f43a-48c9-ce6086137322@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=bindiyakurle@gmail.com \
--cc=blp@ovn.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pshelar@ovn.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®